X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_ojoin.cpp;h=c0626ec695357189dd4e4f6e343259176fe35349;hb=e59cb85871f75b7603c63c6cd274d57536cf6794;hp=e26646c3a15a476cdea0ebbf3c3deaae45dd2f50;hpb=f7ec4f3c2724edfdac2e1a64f1ec151f7f35f9e8;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_ojoin.cpp b/src/modules/m_ojoin.cpp
index e26646c3a..c0626ec69 100644
--- a/src/modules/m_ojoin.cpp
+++ b/src/modules/m_ojoin.cpp
@@ -30,14 +30,15 @@ class CommandOjoin : public SplitCommand
 	bool notice;
 	bool op;
 	ModeHandler* npmh;
-	CommandOjoin(Module* parent) :
-		SplitCommand(parent, "OJOIN", 1)
+	CommandOjoin(Module* parent, ModeHandler& mode)
+		: SplitCommand(parent, "OJOIN", 1)
+		, npmh(&mode)
 	{
-		flags_needed = 'o'; Penalty = 0; syntax = "<channel>";
+		flags_needed = 'o'; syntax = "<channel>";
 		active = false;
 	}
 
-	CmdResult HandleLocal(const std::vector<std::string>& parameters, LocalUser* user)
+	CmdResult HandleLocal(LocalUser* user, const Params& parameters) CXX11_OVERRIDE
 	{
 		// Make sure the channel name is allowable.
 		if (!ServerInstance->IsChannel(parameters[0]))
@@ -57,25 +58,24 @@ class CommandOjoin : public SplitCommand
 
 			if (notice)
 			{
-				channel->WriteChannelWithServ(ServerInstance->Config->ServerName, "NOTICE %s :%s joined on official network business.",
-					parameters[0].c_str(), user->nick.c_str());
-				ServerInstance->PI->SendChannelNotice(channel, 0, user->nick + " joined on official network business.");
+				const std::string msg = user->nick + " joined on official network business.";
+				channel->WriteNotice(msg);
+				ServerInstance->PI->SendChannelNotice(channel, 0, msg);
 			}
 		}
 		else
 		{
+			channel = ServerInstance->FindChan(parameters[0]);
+			if (!channel)
+				return CMD_FAILURE;
+
 			ServerInstance->SNO->WriteGlobalSno('a', user->nick+" used OJOIN in "+parameters[0]);
 			// they're already in the channel
-			std::vector<std::string> modes;
-			modes.push_back(parameters[0]);
-			modes.push_back(std::string("+") + npmh->GetModeChar());
+			Modes::ChangeList changelist;
+			changelist.push_add(npmh, user->nick);
 			if (op)
-			{
-				modes[1].push_back('o');
-				modes.push_back(user->nick);
-			}
-			modes.push_back(user->nick);
-			ServerInstance->Modes->Process(modes, ServerInstance->FakeClient);
+				changelist.push_add(ServerInstance->Modes->FindMode('o', MODETYPE_CHANNEL), user->nick);
+			ServerInstance->Modes->Process(ServerInstance->FakeClient, channel, NULL, changelist);
 		}
 		return CMD_SUCCESS;
 	}
@@ -89,10 +89,10 @@ class NetworkPrefix : public PrefixMode
 	NetworkPrefix(Module* parent, char NPrefix)
 		: PrefixMode(parent, "official-join", 'Y', NETWORK_VALUE, NPrefix)
 	{
-		levelrequired = INT_MAX;
+		ranktoset = ranktounset = UINT_MAX;
 	}
 
-	ModResult AccessCheck(User* source, Channel* channel, std::string &parameter, bool adding)
+	ModResult AccessCheck(User* source, Channel* channel, std::string &parameter, bool adding) CXX11_OVERRIDE
 	{
 		User* theuser = ServerInstance->FindNick(parameter);
 		// remove own privs?
@@ -105,33 +105,22 @@ class NetworkPrefix : public PrefixMode
 
 class ModuleOjoin : public Module
 {
-	NetworkPrefix* np;
+	NetworkPrefix np;
 	CommandOjoin mycommand;
 
  public:
 
 	ModuleOjoin()
-		: np(NULL), mycommand(this)
+		: np(this, ServerInstance->Config->ConfValue("ojoin")->getString("prefix").c_str()[0])
+		, mycommand(this, np)
 	{
 	}
 
-	void init() CXX11_OVERRIDE
-	{
-		std::string npre = ServerInstance->Config->ConfValue("ojoin")->getString("prefix");
-		char NPrefix = npre.empty() ? 0 : npre[0];
-
-		/* Initialise module variables */
-		np = new NetworkPrefix(this, NPrefix);
-		mycommand.npmh = np;
-
-		ServerInstance->Modules->AddService(*np);
-	}
-
 	ModResult OnUserPreJoin(LocalUser* user, Channel* chan, const std::string& cname, std::string& privs, const std::string& keygiven) CXX11_OVERRIDE
 	{
 		if (mycommand.active)
 		{
-			privs += np->GetModeChar();
+			privs += np.GetModeChar();
 			if (mycommand.op)
 				privs += 'o';
 			return MOD_RES_ALLOW;
@@ -150,30 +139,25 @@ class ModuleOjoin : public Module
 	ModResult OnUserPreKick(User* source, Membership* memb, const std::string &reason) CXX11_OVERRIDE
 	{
 		// Don't do anything if they're not +Y
-		if (!memb->hasMode(np->GetModeChar()))
+		if (!memb->HasMode(&np))
 			return MOD_RES_PASSTHRU;
 
 		// Let them do whatever they want to themselves.
 		if (source == memb->user)
 			return MOD_RES_PASSTHRU;
 
-		source->WriteNumeric(ERR_RESTRICTED, memb->chan->name+" :Can't kick "+memb->user->nick+" as they're on official network business.");
+		source->WriteNumeric(ERR_RESTRICTED, memb->chan->name, "Can't kick "+memb->user->nick+" as they're on official network business.");
 		return MOD_RES_DENY;
 	}
 
-	~ModuleOjoin()
-	{
-		delete np;
-	}
-
-	void Prioritize()
+	void Prioritize() CXX11_OVERRIDE
 	{
 		ServerInstance->Modules->SetPriority(this, I_OnUserPreJoin, PRIORITY_FIRST);
 	}
 
 	Version GetVersion() CXX11_OVERRIDE
 	{
-		return Version("Network Business Join", VF_VENDOR);
+		return Version("Provides the OJOIN command, allows an oper to join a channel and be immune to kicks", VF_VENDOR);
 	}
 };