X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_redirect.cpp;h=7d18782834dc840473371e8058ea5cd12ec331f7;hb=c4d6ce8c5e1802e5b834d5845e31c3adf7700585;hp=87cb5cb86cecb742f5dec98661886e4516b46754;hpb=43847ec9c7e1a195163eb4c529f1c92fd1ace0a4;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_redirect.cpp b/src/modules/m_redirect.cpp
index 87cb5cb86..7d1878283 100644
--- a/src/modules/m_redirect.cpp
+++ b/src/modules/m_redirect.cpp
@@ -3,7 +3,7 @@
  *       +------------------------------------+
  *
  *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
@@ -20,7 +20,7 @@
 class Redirect : public ModeHandler
 {
  public:
-	Redirect(InspIRCd* Instance) : ModeHandler(Instance, 'L', 1, 0, false, MODETYPE_CHANNEL, false) { }
+	Redirect(Module* Creator) : ModeHandler(Creator, "redirect", 'L', PARAM_SETONLY, MODETYPE_CHANNEL) { }
 
 	ModePair ModeSet(User* source, User* dest, Channel* channel, const std::string &parameter)
 	{
@@ -30,53 +30,49 @@ class Redirect : public ModeHandler
 			return std::make_pair(false, parameter);
 	}
 
-	bool CheckTimeStamp(time_t theirs, time_t ours, const std::string &their_param, const std::string &our_param, Channel* channel)
-	{
-		/* When TS is equal, the alphabetically later one wins */
-		return (their_param < our_param);
-	}
-
-	ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string &parameter, bool adding, bool)
+	ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string &parameter, bool adding)
 	{
 		if (adding)
 		{
-			Channel* c = NULL;
-
-			if (IS_LOCAL(source) && !ServerInstance->IsChannel(parameter.c_str(), ServerInstance->Config->Limits.ChanMax))
-			{
-				source->WriteNumeric(403, "%s %s :Invalid channel name", source->nick.c_str(), parameter.c_str());
-				parameter.clear();
-				return MODEACTION_DENY;
-			}
-
-			c = ServerInstance->FindChan(parameter);
-			if (!c && !IS_OPER(source))
+			if (IS_LOCAL(source))
 			{
-				source->WriteNumeric(690, "%s :Target channel %s must exist to be set as a redirect.",source->nick.c_str(),parameter.c_str());
-				parameter.clear();
-				return MODEACTION_DENY;
+				if (!ServerInstance->IsChannel(parameter.c_str(), ServerInstance->Config->Limits.ChanMax))
+				{
+					source->WriteNumeric(403, "%s %s :Invalid channel name", source->nick.c_str(), parameter.c_str());
+					parameter.clear();
+					return MODEACTION_DENY;
+				}
 			}
 
-			if (c && c->GetStatus(source) < STATUS_OP && !IS_OPER(source))
+			if (IS_LOCAL(source) && !IS_OPER(source))
 			{
-				source->WriteNumeric(690, "%s :You must be opped on %s to set it as a redirect.",source->nick.c_str(),parameter.c_str());
-				parameter.clear();
-				return MODEACTION_DENY;
+				Channel* c = ServerInstance->FindChan(parameter);
+				if (!c)
+				{
+					source->WriteNumeric(690, "%s :Target channel %s must exist to be set as a redirect.",source->nick.c_str(),parameter.c_str());
+					parameter.clear();
+					return MODEACTION_DENY;
+				}
+				else if (c->GetPrefixValue(source) < OP_VALUE)
+				{
+					source->WriteNumeric(690, "%s :You must be opped on %s to set it as a redirect.",source->nick.c_str(),parameter.c_str());
+					parameter.clear();
+					return MODEACTION_DENY;
+				}
 			}
 
 			/*
 			 * We used to do some checking for circular +L here, but there is no real need for this any more especially as we
 			 * now catch +L looping in PreJoin. Remove it, since O(n) logic makes me sad, and we catch it anyway. :) -- w00t
 			 */
-			channel->SetMode('L', true);
-			channel->SetModeParam('L', parameter.c_str(), true);
+			channel->SetModeParam('L', parameter);
 			return MODEACTION_ALLOW;
 		}
 		else
 		{
 			if (channel->IsModeSet('L'))
 			{
-				channel->SetMode('L', false);
+				channel->SetModeParam('L', "");
 				return MODEACTION_ALLOW;
 			}
 		}
@@ -89,23 +85,22 @@ class Redirect : public ModeHandler
 class ModuleRedirect : public Module
 {
 
-	Redirect* re;
+	Redirect re;
 
  public:
 
-	ModuleRedirect(InspIRCd* Me)
-		: Module(Me)
+	ModuleRedirect()
+		: re(this)
 	{
 
-		re = new Redirect(ServerInstance);
-		if (!ServerInstance->Modes->AddMode(re))
+		if (!ServerInstance->Modes->AddMode(&re))
 			throw ModuleException("Could not add new modes!");
 		Implementation eventlist[] = { I_OnUserPreJoin };
 		ServerInstance->Modules->Attach(eventlist, this, 1);
 	}
 
 
-	virtual int OnUserPreJoin(User* user, Channel* chan, const char* cname, std::string &privs, const std::string &keygiven)
+	virtual ModResult OnUserPreJoin(User* user, Channel* chan, const char* cname, std::string &privs, const std::string &keygiven)
 	{
 		if (chan)
 		{
@@ -121,27 +116,25 @@ class ModuleRedirect : public Module
 					if (destchan && destchan->IsModeSet('L'))
 					{
 						user->WriteNumeric(470, "%s %s * :You may not join this channel. A redirect is set, but you may not be redirected as it is a circular loop.", user->nick.c_str(), cname);
-						return 1;
+						return MOD_RES_DENY;
 					}
 
 					user->WriteNumeric(470, "%s %s %s :You may not join this channel, so you are automatically being transferred to the redirect channel.", user->nick.c_str(), cname, channel.c_str());
-					Channel::JoinUser(ServerInstance, user, channel.c_str(), false, "", false, ServerInstance->Time());
-					return 1;
+					Channel::JoinUser(user, channel.c_str(), false, "", false, ServerInstance->Time());
+					return MOD_RES_DENY;
 				}
 			}
 		}
-		return 0;
+		return MOD_RES_PASSTHRU;
 	}
 
 	virtual ~ModuleRedirect()
 	{
-		ServerInstance->Modes->DelMode(re);
-		delete re;
 	}
 
 	virtual Version GetVersion()
 	{
-		return Version("$Id$", VF_COMMON | VF_VENDOR, API_VERSION);
+		return Version("Provides channel mode +L (limit redirection)", VF_COMMON | VF_VENDOR, API_VERSION);
 	}
 };