X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_spanningtree%2Fnick.cpp;h=1d853a2dfe1c98332801886a4c86a9fbe80395ec;hb=304b6dbbf56710b1310fce8c5cf71b73334c060a;hp=c689a0fddb81ef3b2f0425f774ce71b4fcbff905;hpb=430072e7ff13f067cd770d1bdd0515ec24c5b134;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/modules/m_spanningtree/nick.cpp b/src/modules/m_spanningtree/nick.cpp index c689a0fdd..1d853a2df 100644 --- a/src/modules/m_spanningtree/nick.cpp +++ b/src/modules/m_spanningtree/nick.cpp @@ -35,8 +35,8 @@ CmdResult CommandNick::HandleRemote(RemoteUser* user, std::vector& if ((isdigit(params[0][0])) && (params[0] != user->uuid)) throw ProtocolException("Attempted to change nick to an invalid or non-matching UUID"); - /* Update timestamp on user when they change nicks */ - const time_t newts = ConvToInt(params[1]); + // Timestamp of the new nick + time_t newts = ServerCommand::ExtractTS(params[1]); /* * On nick messages, check that the nick doesn't already exist here. @@ -45,13 +45,16 @@ CmdResult CommandNick::HandleRemote(RemoteUser* user, std::vector& User* x = ServerInstance->FindNickOnly(params[0]); if ((x) && (x != user) && (x->registered == REG_ALL)) { - /* x is local, who is remote */ - int collideret = Utils->DoCollision(x, TreeServer::Get(user), newts, user->ident, user->GetIPString(), user->uuid); - if (collideret != 1) + // 'x' is the already existing user using the same nick as params[0] + // 'user' is the user trying to change nick to the in use nick + bool they_change = Utils->DoCollision(x, TreeServer::Get(user), newts, user->ident, user->GetIPString(), user->uuid, "NICK"); + if (they_change) { // Remote client lost, or both lost, rewrite this nick change as a change to uuid before // calling ChangeNick() and forwarding the message params[0] = user->uuid; + params[1] = ConvToStr(CommandSave::SavedTimestamp); + newts = CommandSave::SavedTimestamp; } }