X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_spanningtree%2Fnick.cpp;h=4f53941ceb9ecb2f28c9bc6aab8ff1773b5f610f;hb=36899e44eec416f5cd74cfe2d61baa984963dbe0;hp=eb6c9396ff9a460c86bae90a6d39e6b9bafefbea;hpb=11916574f67962dce1d7a2fdf7ef6a3d2d1fa49f;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_spanningtree/nick.cpp b/src/modules/m_spanningtree/nick.cpp
index eb6c9396f..4f53941ce 100644
--- a/src/modules/m_spanningtree/nick.cpp
+++ b/src/modules/m_spanningtree/nick.cpp
@@ -30,33 +30,35 @@
 #include "commands.h"
 #include "treeserver.h"
 
-CmdResult CommandNick::HandleRemote(RemoteUser* user, std::vector<std::string>& params)
+CmdResult CommandNick::HandleRemote(::RemoteUser* user, Params& params)
 {
 	if ((isdigit(params[0][0])) && (params[0] != user->uuid))
-		return CMD_INVALID;
+		throw ProtocolException("Attempted to change nick to an invalid or non-matching UUID");
 
-	/* Update timestamp on user when they change nicks */
-	user->age = ConvToInt(params[1]);
+	// Timestamp of the new nick
+	time_t newts = ServerCommand::ExtractTS(params[1]);
 
 	/*
 	 * On nick messages, check that the nick doesn't already exist here.
 	 * If it does, perform collision logic.
 	 */
 	User* x = ServerInstance->FindNickOnly(params[0]);
-	if ((x) && (x != user))
+	if ((x) && (x != user) && (x->registered == REG_ALL))
 	{
-		/* x is local, who is remote */
-		int collideret = Utils->DoCollision(x, TreeServer::Get(user), user->age, user->ident, user->GetIPString(), user->uuid);
-		if (collideret != 1)
+		// 'x' is the already existing user using the same nick as params[0]
+		// 'user' is the user trying to change nick to the in use nick
+		bool they_change = Utils->DoCollision(x, TreeServer::Get(user), newts, user->ident, user->GetIPString(), user->uuid, "NICK");
+		if (they_change)
 		{
-			/*
-			 * Remote client lost, or both lost, parsing or passing on this
-			 * nickchange would be pointless, as the incoming client's server will
-			 * soon receive SAVE to change its nick to its UID. :) -- w00t
-			 */
-			return CMD_FAILURE;
+			// Remote client lost, or both lost, rewrite this nick change as a change to uuid before
+			// calling ChangeNick() and forwarding the message
+			params[0] = user->uuid;
+			params[1] = ConvToStr(CommandSave::SavedTimestamp);
+			newts = CommandSave::SavedTimestamp;
 		}
 	}
-	user->ForceNickChange(params[0]);
+
+	user->ChangeNick(params[0], newts);
+
 	return CMD_SUCCESS;
 }