X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_spanningtree%2Fpostcommand.cpp;h=c10bccaf9bcaeda151230b03423fb5e55e207c0c;hb=e9e75e50bc25e67af22dd88b39b12217a553d5cb;hp=6afe8e2c9c1fe808adf9176a7c26037b0a8a1206;hpb=fcacc8e0306382bc3f938073092c3729d77e2b41;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_spanningtree/postcommand.cpp b/src/modules/m_spanningtree/postcommand.cpp
index 6afe8e2c9..c10bccaf9 100644
--- a/src/modules/m_spanningtree/postcommand.cpp
+++ b/src/modules/m_spanningtree/postcommand.cpp
@@ -17,19 +17,13 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-
-/* $ModDesc: Provides a spanning tree server link protocol */
-
 #include "inspircd.h"
-#include "socket.h"
-#include "xline.h"
 
 #include "main.h"
 #include "utils.h"
 #include "treeserver.h"
-#include "treesocket.h"
 
-/* $ModDep: m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/treesocket.h */
+/* $ModDep: m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h */
 
 void ModuleSpanningTree::OnPostCommand(const std::string &command, const std::vector<std::string>& parameters, LocalUser *user, CmdResult result, const std::string &original_line)
 {
@@ -39,10 +33,10 @@ void ModuleSpanningTree::OnPostCommand(const std::string &command, const std::ve
 
 void SpanningTreeUtilities::RouteCommand(TreeServer* origin, const std::string &command, const parameterlist& parameters, User *user)
 {
-	if (!ServerInstance->IsValidModuleCommand(command, parameters.size(), user))
+	if (!ServerInstance->Parser->IsValidCommand(command, parameters.size(), user))
 		return;
 
-	/* We know it's non-null because IsValidModuleCommand returned true */
+	/* We know it's non-null because IsValidCommand returned true */
 	Command* thiscmd = ServerInstance->Parser->GetHandler(command);
 
 	RouteDescriptor routing = thiscmd->GetRouting(user, parameters);
@@ -52,15 +46,15 @@ void SpanningTreeUtilities::RouteCommand(TreeServer* origin, const std::string &
 
 	if (routing.type == ROUTE_TYPE_LOCALONLY)
 	{
-		Module* srcmodule = thiscmd->creator;
-		Version ver = srcmodule->GetVersion();
+		/* Broadcast when it's a core command with the default route descriptor and the source is a
+		 * remote user or a remote server
+		 */
 
-		if ((ver.Flags & VF_CORE) && !IS_LOCAL(user))
-			routing = ROUTE_BROADCAST;
-		else
-			return;
-		if (IS_SERVER(user) && user != ServerInstance->FakeClient)
+		Version ver = thiscmd->creator->GetVersion();
+		if ((!(ver.Flags & VF_CORE)) || (IS_LOCAL(user)) || (IS_SERVER(user) == ServerInstance->FakeClient))
 			return;
+
+		routing = ROUTE_BROADCAST;
 	}
 	else if (routing.type == ROUTE_TYPE_OPT_BCAST)
 	{
@@ -73,7 +67,7 @@ void SpanningTreeUtilities::RouteCommand(TreeServer* origin, const std::string &
 		TreeServer* sdest = FindServer(routing.serverdest);
 		if (!sdest)
 		{
-			ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"Trying to route ENCAP to nonexistant server %s",
+			ServerInstance->Logs->Log("m_spanningtree",LOG_DEFAULT,"Trying to route ENCAP to nonexistant server %s",
 				routing.serverdest.c_str());
 			return;
 		}
@@ -88,7 +82,7 @@ void SpanningTreeUtilities::RouteCommand(TreeServer* origin, const std::string &
 
 		if (!(ver.Flags & (VF_COMMON | VF_CORE)) && srcmodule != Creator)
 		{
-			ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"Routed command %s from non-VF_COMMON module %s",
+			ServerInstance->Logs->Log("m_spanningtree",LOG_DEFAULT,"Routed command %s from non-VF_COMMON module %s",
 				command.c_str(), srcmodule->ModuleSourceFile.c_str());
 			return;
 		}
@@ -121,7 +115,7 @@ void SpanningTreeUtilities::RouteCommand(TreeServer* origin, const std::string &
 				data += " " + params[x];
 			for (TreeServerList::iterator i = list.begin(); i != list.end(); i++)
 			{
-				TreeSocket* Sock = i->second->GetSocket();
+				TreeSocket* Sock = (*i)->GetSocket();
 				if (origin && origin->GetSocket() == Sock)
 					continue;
 				if (Sock)