X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_spanningtree%2Fsvsnick.cpp;h=8d1bc80ba20cb2dd4a04c6ba7c0024c20fab4b4d;hb=bf3bfec6d58f566b98eb09ba0bf83d6a46ca400f;hp=fda150012f1f845a5db01b3c8c3fc1fcd0db5b1d;hpb=0d69fdd92c5444910860be2c03c5c259b33b1931;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_spanningtree/svsnick.cpp b/src/modules/m_spanningtree/svsnick.cpp
index fda150012..8d1bc80ba 100644
--- a/src/modules/m_spanningtree/svsnick.cpp
+++ b/src/modules/m_spanningtree/svsnick.cpp
@@ -1,52 +1,81 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2018-2019 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2013-2016 Attila Molnar <attilamolnar@hush.com>
+ *   Copyright (C) 2012 Robby <robby@chatbelgie.be>
+ *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2009 Uli Schlachter <psychon@inspircd.org>
+ *   Copyright (C) 2008 Robin Burchell <robin+git@viroteck.net>
  *
- * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+
 #include "inspircd.h"
 
 #include "main.h"
-#include "utils.h"
 #include "commands.h"
 
-CmdResult CommandSVSNick::Handle(const std::vector<std::string>& parameters, User *user)
+CmdResult CommandSVSNick::Handle(User* user, Params& parameters)
 {
 	User* u = ServerInstance->FindNick(parameters[0]);
 
 	if (u && IS_LOCAL(u))
 	{
+		// The 4th parameter is optional and it is the expected nick TS of the target user. If this parameter is
+		// present and it doesn't match the user's nick TS, the SVSNICK is not acted upon.
+		// This makes it possible to detect the case when services wants to change the nick of a user, but the
+		// user changes their nick before the SVSNICK arrives, making the SVSNICK nick change (usually to a guest nick)
+		// unnecessary. Consider the following for example:
+		//
+		// 1. test changes nick to Attila which is protected by services
+		// 2. Services SVSNICKs the user to Guest12345
+		// 3. Attila changes nick to Attila_ which isn't protected by services
+		// 4. SVSNICK arrives
+		// 5. Attila_ gets his nick changed to Guest12345 unnecessarily
+		//
+		// In this case when the SVSNICK is processed the target has already changed their nick to something
+		// which isn't protected, so changing the nick again to a Guest nick is not desired.
+		// However, if the expected nick TS parameter is present in the SVSNICK then the nick change in step 5
+		// won't happen because the timestamps won't match.
+		if (parameters.size() > 3)
+		{
+			time_t ExpectedTS = ConvToNum<time_t>(parameters[3]);
+			if (u->age != ExpectedTS)
+				return CMD_FAILURE; // Ignore SVSNICK
+		}
+
 		std::string nick = parameters[1];
 		if (isdigit(nick[0]))
 			nick = u->uuid;
 
-		if (!u->ForceNickChange(nick.c_str()))
+		time_t NickTS = ConvToNum<time_t>(parameters[2]);
+		if (NickTS <= 0)
+			return CMD_FAILURE;
+
+		if (!u->ChangeNick(nick, NickTS))
 		{
-			/* buh. UID them */
-			if (!u->ForceNickChange(u->uuid.c_str()))
-			{
-				ServerInstance->Users->QuitUser(u, "Nickname collision");
-				return CMD_SUCCESS;
-			}
+			// Changing to 'nick' failed (it may already be in use), change to the uuid
+			u->WriteNumeric(RPL_SAVENICK, u->uuid, "Your nickname is in use by an older user on a new server.");
+			u->ChangeNick(u->uuid);
 		}
-
-		u->age = atoi(parameters[2].c_str());
 	}
 
 	return CMD_SUCCESS;
 }
 
-RouteDescriptor CommandSVSNick::GetRouting(User* user, const std::vector<std::string>& parameters)
+RouteDescriptor CommandSVSNick::GetRouting(User* user, const Params& parameters)
 {
-	User* u = ServerInstance->FindNick(parameters[0]);
-	if (u)
-		return ROUTE_OPT_UCAST(u->server);
-	return ROUTE_LOCALONLY;
+	return ROUTE_OPT_UCAST(parameters[0]);
 }