X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_watch.cpp;h=28c809d5bb4ab2bfc065e3b58ae834eda981eb24;hb=7f00015727fab50e37de46aa90d218b31c852c87;hp=70257af11dd8a735b3b772a03ca0d6bb8dbcdf0d;hpb=bd9be879cbd0ae0010e9699094e79fc38df37ec1;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/modules/m_watch.cpp b/src/modules/m_watch.cpp index 70257af11..28c809d5b 100644 --- a/src/modules/m_watch.cpp +++ b/src/modules/m_watch.cpp @@ -2,39 +2,73 @@ * | Inspire Internet Relay Chat Daemon | * +------------------------------------+ * - * InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev. - * E-mail: - * - * - * - * Written by Craig Edwards, Craig McLure, and others. + * InspIRCd: (C) 2002-2007 InspIRCd Development Team + * See: http://www.inspircd.org/wiki/index.php/Credits + * * This program is free but copyrighted software; see - * the file COPYING for details. + * the file COPYING for details. * * --------------------------------------------------- */ -using namespace std; - -#include -#include -#include #include "users.h" #include "channels.h" #include "modules.h" #include "hashcomp.h" #include "inspircd.h" -/* $ModDesc: Provides support for the /watch command */ +/* $ModDesc: Provides support for the /WATCH command */ -/* nickname list of users watching the nick */ -typedef std::map > watchentries; +/* This module has been refactored to provide a very efficient (in terms of cpu time) + * implementation of /WATCH. + * + * To improve the efficiency of watch, many lists are kept. The first primary list is + * a hash_map of who's being watched by who. For example: + * + * KEY: Brain ---> Watched by: Boo, w00t, Om + * KEY: Boo ---> Watched by: Brain, w00t + * + * This is used when we want to tell all the users that are watching someone that + * they are now available or no longer available. For example, if the hash was + * populated as shown above, then when Brain signs on, messages are sent to Boo, w00t + * and Om by reading their 'watched by' list. When this occurs, their online status + * in each of these users lists (see below) is also updated. + * + * Each user also has a seperate (smaller) map attached to their userrec whilst they + * have any watch entries, which is managed by class Extensible. When they add or remove + * a watch entry from their list, it is inserted here, as well as the main list being + * maintained. This map also contains the user's online status. For users that are + * offline, the key points at an empty string, and for users that are online, the key + * points at a string containing "users-ident users-host users-signon-time". This is + * stored in this manner so that we don't have to FindUser() to fetch this info, the + * users signon can populate the field for us. + * + * For example, going again on the example above, this would be w00t's watchlist: + * + * KEY: Boo ---> Status: "Boo brains.sexy.babe 535342348" + * KEY: Brain ---> Status: "" + * + * In this list we can see that Boo is online, and Brain is offline. We can then + * use this list for 'WATCH L', and 'WATCH S' can be implemented as a combination + * of the above two data structures, with minimum CPU penalty for doing so. + * + * In short, the least efficient this ever gets is O(n), and thats only because + * there are parts that *must* loop (e.g. telling all users that are watching a + * nick that the user online), however this is a *major* improvement over the + * 1.0 implementation, which in places had O(n^n) and worse in it, because this + * implementation scales based upon the sizes of the watch entries, whereas the + * old system would scale (or not as the case may be) according to the total number + * of users using WATCH. + */ -/* nickname 'ident host signon', or empty if not online */ -typedef std::map watchlist; +typedef nspace::hash_map, nspace::hash > watchentries; +typedef std::map watchlist; -/* Whos watching each nickname */ -watchentries whos_watching_me; +/* Who's watching each nickname. + * NOTE: We do NOT iterate this to display a user's WATCH list! + * See the comments above! + */ +watchentries* whos_watching_me; /** Handle /WATCH */ @@ -72,8 +106,8 @@ class cmd_watch : public command_t delete wl; } - watchentries::iterator x = whos_watching_me.find(nick); - if (x != whos_watching_me.end()) + watchentries::iterator x = whos_watching_me->find(nick); + if (x != whos_watching_me->end()) { /* People are watching this user, am i one of them? */ std::deque::iterator n = std::find(x->second.begin(), x->second.end(), user); @@ -82,7 +116,7 @@ class cmd_watch : public command_t x->second.erase(n); if (!x->second.size()) - whos_watching_me.erase(nick); + whos_watching_me->erase(nick); } } @@ -104,7 +138,6 @@ class cmd_watch : public command_t watchlist* wl; if (!user->GetExt("watchlist", wl)) { - ServerInstance->Log(DEBUG,"Allocate new watchlist"); wl = new watchlist(); user->Extend("watchlist", wl); } @@ -118,10 +151,9 @@ class cmd_watch : public command_t watchlist::iterator n = wl->find(nick); if (n == wl->end()) { - ServerInstance->Log(DEBUG,"*** Add to WATCH: '%s'", nick); /* Don't already have the user on my watch list, proceed */ - watchentries::iterator x = whos_watching_me.find(nick); - if (x != whos_watching_me.end()) + watchentries::iterator x = whos_watching_me->find(nick); + if (x != whos_watching_me->end()) { /* People are watching this user, add myself */ x->second.push_back(user); @@ -130,7 +162,7 @@ class cmd_watch : public command_t { std::deque newlist; newlist.push_back(user); - whos_watching_me[nick] = newlist; + (*(whos_watching_me))[nick] = newlist; } userrec* target = ServerInstance->FindNick(nick); @@ -145,10 +177,6 @@ class cmd_watch : public command_t user->WriteServ("605 %s %s * * 0 :is offline",user->nick, nick); } } - else - { - ServerInstance->Log(DEBUG,"*** WATCH entry '%s' already exists!", nick); - } return CMD_FAILURE; } @@ -179,7 +207,6 @@ class cmd_watch : public command_t for (int x = 0; x < pcnt; x++) { const char *nick = parameters[x]; - ServerInstance->Log(DEBUG,"WATCH iterate item '%s'", nick); if (!strcasecmp(nick,"C")) { // watch clear @@ -188,8 +215,8 @@ class cmd_watch : public command_t { for (watchlist::iterator i = wl->begin(); i != wl->end(); i++) { - watchentries::iterator x = whos_watching_me.find(i->first); - if (x != whos_watching_me.end()) + watchentries::iterator x = whos_watching_me->find(i->first); + if (x != whos_watching_me->end()) { /* People are watching this user, am i one of them? */ std::deque::iterator n = std::find(x->second.begin(), x->second.end(), user); @@ -198,7 +225,7 @@ class cmd_watch : public command_t x->second.erase(n); if (!x->second.size()) - whos_watching_me.erase(user->nick); + whos_watching_me->erase(user->nick); } } @@ -235,8 +262,8 @@ class cmd_watch : public command_t you_have = wl->size(); } - watchentries::iterator x = whos_watching_me.find(user->nick); - if (x != whos_watching_me.end()) + watchentries::iterator x = whos_watching_me->find(user->nick); + if (x != whos_watching_me->end()) youre_on = x->second.size(); user->WriteServ("603 %s :You have %d and are on %d WATCH entries", user->nick, you_have, youre_on); @@ -269,20 +296,20 @@ class Modulewatch : public Module Modulewatch(InspIRCd* Me) : Module::Module(Me), maxwatch(32) { + whos_watching_me = new watchentries(); mycommand = new cmd_watch(ServerInstance, maxwatch); ServerInstance->AddCommand(mycommand); } void Implements(char* List) { - List[I_OnUserQuit] = List[I_OnPostConnect] = List[I_OnUserPostNick] = List[I_On005Numeric] = 1; + List[I_OnGarbageCollect] = List[I_OnCleanup] = List[I_OnUserQuit] = List[I_OnPostConnect] = List[I_OnUserPostNick] = List[I_On005Numeric] = 1; } - virtual void OnUserQuit(userrec* user, const std::string &reason) + virtual void OnUserQuit(userrec* user, const std::string &reason, const std::string &oper_message) { - ServerInstance->Log(DEBUG,"*** WATCH: On global quit: user %s",user->nick); - watchentries::iterator x = whos_watching_me.find(user->nick); - if (x != whos_watching_me.end()) + watchentries::iterator x = whos_watching_me->find(user->nick); + if (x != whos_watching_me->end()) { for (std::deque::iterator n = x->second.begin(); n != x->second.end(); n++) { @@ -301,8 +328,8 @@ class Modulewatch : public Module /* Iterate every user on my watch list, and take me out of the whos_watching_me map for each one we're watching */ for (watchlist::iterator i = wl->begin(); i != wl->end(); i++) { - watchentries::iterator x = whos_watching_me.find(i->first); - if (x != whos_watching_me.end()) + watchentries::iterator x = whos_watching_me->find(i->first); + if (x != whos_watching_me->end()) { /* People are watching this user, am i one of them? */ std::deque::iterator n = std::find(x->second.begin(), x->second.end(), user); @@ -311,17 +338,45 @@ class Modulewatch : public Module x->second.erase(n); if (!x->second.size()) - whos_watching_me.erase(user->nick); + whos_watching_me->erase(user->nick); } } + + /* User's quitting, we're done with this. */ + delete wl; + } + } + + virtual void OnGarbageCollect() + { + watchentries* old_watch = whos_watching_me; + whos_watching_me = new watchentries(); + + for (watchentries::const_iterator n = old_watch->begin(); n != old_watch->end(); n++) + whos_watching_me->insert(*n); + + delete old_watch; + } + + virtual void OnCleanup(int target_type, void* item) + { + if (target_type == TYPE_USER) + { + watchlist* wl; + userrec* user = (userrec*)item; + + if (user->GetExt("watchlist", wl)) + { + user->Shrink("watchlist"); + delete wl; + } } } virtual void OnPostConnect(userrec* user) { - ServerInstance->Log(DEBUG,"*** WATCH: On global connect: user %s",user->nick); - watchentries::iterator x = whos_watching_me.find(user->nick); - if (x != whos_watching_me.end()) + watchentries::iterator x = whos_watching_me->find(user->nick); + if (x != whos_watching_me->end()) { for (std::deque::iterator n = x->second.begin(); n != x->second.end(); n++) { @@ -336,12 +391,10 @@ class Modulewatch : public Module virtual void OnUserPostNick(userrec* user, const std::string &oldnick) { - ServerInstance->Log(DEBUG,"*** WATCH: On global nickchange: old nick: %s new nick: %s",oldnick.c_str(),user->nick); - - watchentries::iterator new_online = whos_watching_me.find(user->nick); - watchentries::iterator new_offline = whos_watching_me.find(assign(oldnick)); + watchentries::iterator new_online = whos_watching_me->find(user->nick); + watchentries::iterator new_offline = whos_watching_me->find(assign(oldnick)); - if (new_online != whos_watching_me.end()) + if (new_online != whos_watching_me->end()) { for (std::deque::iterator n = new_online->second.begin(); n != new_online->second.end(); n++) { @@ -349,19 +402,19 @@ class Modulewatch : public Module if ((*n)->GetExt("watchlist", wl)) { (*wl)[user->nick] = std::string(user->ident).append(" ").append(user->dhost).append(" ").append(ConvToStr(user->age)); - (*n)->WriteServ("600 %s %s %s %s %lu :arrived online", (*n)->nick, (*wl)[user->nick].c_str()); + (*n)->WriteServ("600 %s %s %s :arrived online", (*n)->nick, user->nick, (*wl)[user->nick].c_str()); } } } - if (new_offline != whos_watching_me.end()) + if (new_offline != whos_watching_me->end()) { for (std::deque::iterator n = new_offline->second.begin(); n != new_offline->second.end(); n++) { watchlist* wl; if ((*n)->GetExt("watchlist", wl)) { - (*n)->WriteServ("601 %s %s %s :went offline", (*n)->nick, (*wl)[user->nick].c_str()); + (*n)->WriteServ("601 %s %s %s %s %lu :went offline", (*n)->nick, oldnick.c_str(), user->ident, user->dhost, user->age); (*wl)[user->nick] = ""; } } @@ -376,6 +429,7 @@ class Modulewatch : public Module virtual ~Modulewatch() { + delete whos_watching_me; } virtual Version GetVersion()