X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Ftestsuite.cpp;h=b27f6e18c991d7e685a6ba202230f525d6acd669;hb=67de413cad88194972d55a8ff88464370890c5a9;hp=c107217b74d6ab68315187bffefdd2de3912c3bc;hpb=48f7fa6b11a0a6b1526c54914e60ddbe51ede8c4;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/testsuite.cpp b/src/testsuite.cpp
index c107217b7..b27f6e18c 100644
--- a/src/testsuite.cpp
+++ b/src/testsuite.cpp
@@ -19,8 +19,6 @@
  */
 
 
-/* $Core */
-
 #include "inspircd.h"
 #include "testsuite.h"
 #include "threadengine.h"
@@ -76,7 +74,7 @@ TestSuite::TestSuite()
 		switch (choice)
 		{
 			case '1':
-				FOREACH_MOD(I_OnRunTestSuite, OnRunTestSuite());
+				FOREACH_MOD(OnRunTestSuite, ());
 				break;
 			case '2':
 				std::cout << "Enter module filename to load: ";
@@ -331,23 +329,25 @@ bool TestSuite::DoThreadTests()
 
 bool TestSuite::DoGenerateUIDTests()
 {
+	const unsigned int UUID_LENGTH = UIDGenerator::UUID_LENGTH;
 	UIDGenerator uidgen;
 	uidgen.init(ServerInstance->Config->GetSID());
 	std::string first_uid = uidgen.GetUID();
-	if (first_uid.length() != UUID_LENGTH-1)
+
+	if (first_uid.length() != UUID_LENGTH)
 	{
 		std::cout << "GENERATEUID: Generated UID is " << first_uid.length() << " characters long instead of " << UUID_LENGTH-1 << std::endl;
 		return false;
 	}
 
-	if (uidgen.current_uid[UUID_LENGTH-1] != '\0')
+	if (uidgen.current_uid.c_str()[UUID_LENGTH] != '\0')
 	{
 		std::cout << "GENERATEUID: The null terminator is missing from the end of current_uid" << std::endl;
 		return false;
 	}
 
 	// The correct UID when generating one for the first time is ...AAAAAA
-	std::string correct_uid = ServerInstance->Config->sid + std::string(UUID_LENGTH - 4, 'A');
+	std::string correct_uid = ServerInstance->Config->sid + std::string(UUID_LENGTH - 3, 'A');
 	if (first_uid != correct_uid)
 	{
 		std::cout << "GENERATEUID: Generated an invalid first UID: " << first_uid << " instead of " << correct_uid << std::endl;
@@ -356,7 +356,7 @@ bool TestSuite::DoGenerateUIDTests()
 
 	// Set current_uid to be ...Z99999
 	uidgen.current_uid[3] = 'Z';
-	for (unsigned int i = 4; i < UUID_LENGTH-1; i++)
+	for (unsigned int i = 4; i < UUID_LENGTH; i++)
 		uidgen.current_uid[i] = '9';
 
 	// Store the UID we'll be incrementing so we can display what's wrong later if necessary
@@ -364,7 +364,7 @@ bool TestSuite::DoGenerateUIDTests()
 	std::string generated_uid = uidgen.GetUID();
 
 	// Correct UID after incrementing ...Z99999 is ...0AAAAA
-	correct_uid = ServerInstance->Config->sid + "0" + std::string(UUID_LENGTH - 5, 'A');
+	correct_uid = ServerInstance->Config->sid + "0" + std::string(UUID_LENGTH - 4, 'A');
 
 	if (generated_uid != correct_uid)
 	{
@@ -373,7 +373,7 @@ bool TestSuite::DoGenerateUIDTests()
 	}
 
 	// Set current_uid to be ...999999 to see if it rolls over correctly
-	for (unsigned int i = 3; i < UUID_LENGTH-1; i++)
+	for (unsigned int i = 3; i < UUID_LENGTH; i++)
 		uidgen.current_uid[i] = '9';
 
 	before_increment.assign(uidgen.current_uid);