-pedantic tidyups, lets see if it finds anything worthy of a fix

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@8313 e03df62e-2008-0410-955e-edbf42e46eb7

diff --git a/include/caller.h b/include/caller.h
index 5cf08905a41e947e706d64915c817189927ad81b..de28f4489116b65705e86c833145bdd022757449 100644 (file)
--- a/include/caller.h
+++ b/include/caller.h
@@ -255,31 +255,31 @@ template <typename ReturnType, typename Param1, typename Param2, typename Param3
  */
 
 #define DEFINE_HANDLER0(NAME, RETURN) \
-       class CoreExport NAME : public HandlerBase0<RETURN> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(); };
+       class CoreExport NAME : public HandlerBase0<RETURN> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(); }
 
 #define DEFINE_HANDLER1(NAME, RETURN, V1) \
-       class CoreExport NAME : public HandlerBase1<RETURN, V1> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1); };
+       class CoreExport NAME : public HandlerBase1<RETURN, V1> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1); }
 
 #define DEFINE_HANDLER2(NAME, RETURN, V1, V2) \
-       class CoreExport NAME : public HandlerBase2<RETURN, V1, V2> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2); };
+       class CoreExport NAME : public HandlerBase2<RETURN, V1, V2> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2); }
 
 #define DEFINE_HANDLER3(NAME, RETURN, V1, V2, V3) \
-       class CoreExport NAME : public HandlerBase3<RETURN, V1, V2, V3> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3); };
+       class CoreExport NAME : public HandlerBase3<RETURN, V1, V2, V3> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3); }
 
 #define DEFINE_HANDLER4(NAME, RETURN, V1, V2, V3, V4) \
-       class CoreExport NAME : public HandlerBase4<RETURN, V1, V2, V3, V4> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4); };
+       class CoreExport NAME : public HandlerBase4<RETURN, V1, V2, V3, V4> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4); }
 
 #define DEFINE_HANDLER5(NAME, RETURN, V1, V2, V3, V4, V5) \
-       class CoreExport NAME : public HandlerBase5<RETURN, V1, V2, V3, V4, V5> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5); };
+       class CoreExport NAME : public HandlerBase5<RETURN, V1, V2, V3, V4, V5> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5); }
 
 #define DEFINE_HANDLER6(NAME, RETURN, V1, V2, V3, V4, V5, V6) \
-       class CoreExport NAME : public HandlerBase6<RETURN, V1, V2, V3, V4, V5, V6> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6); };
+       class CoreExport NAME : public HandlerBase6<RETURN, V1, V2, V3, V4, V5, V6> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6); }
 
 #define DEFINE_HANDLER7(NAME, RETURN, V1, V2, V3, V4, V5, V6, V7) \
-       class CoreExport NAME : public HandlerBase7<RETURN, V1, V2, V3, V4, V5, V6, V7> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6, V7); };
+       class CoreExport NAME : public HandlerBase7<RETURN, V1, V2, V3, V4, V5, V6, V7> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6, V7); }
 
 #define DEFINE_HANDLER8(NAME, RETURN, V1, V2, V3, V4, V5, V6, V7, V8) \
-       class CoreExport NAME : public HandlerBase8<RETURN, V1, V2, V3, V4, V5, V6, V7, V8> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6, V7, V8); };
+       class CoreExport NAME : public HandlerBase8<RETURN, V1, V2, V3, V4, V5, V6, V7, V8> { InspIRCd* Server; public: NAME(InspIRCd* Srv) : Server(Srv) { } virtual ~NAME() { } virtual RETURN Call(V1, V2, V3, V4, V5, V6, V7, V8); }
 
 #endif
 

diff --git a/include/ctables.h b/include/ctables.h
index ee972adaad914fe4013fdf85a974bf779a60076b..aafd27e4a9f643ef33534c1b3948bbfb166c50b5 100644 (file)
--- a/include/ctables.h
+++ b/include/ctables.h
@@ -132,7 +132,7 @@ class CoreExport Command : public Extensible
         * If the command succeeds but should remain local to this server,
         * return CMD_LOCALONLY.
         */
-       virtual CmdResult HandleInternal(const unsigned int id, const std::deque<classbase*> &params)
+       virtual CmdResult HandleInternal(const unsigned int /* id */, const std::deque<classbase*>& /* params */)
        {
                return CMD_INVALID;
        }
@@ -146,7 +146,7 @@ class CoreExport Command : public Extensible
         * If the command succeeds but should remain local to this server,
         * return CMD_LOCALONLY.
         */
-       virtual CmdResult HandleServer(const char** parameters, int pcnt, const std::string &servername)
+       virtual CmdResult HandleServer(const char** /* parameters */, int /* pcnt */, const std::string& /* servername */)
        {
                return CMD_INVALID;
        }

diff --git a/include/hashcomp.h b/include/hashcomp.h
index 78792d1abda1d5bb38a2d6ac64b171e2e793a1e9..00c9b692488e3c0a9c6b12dd755a9038f0ca39e8 100644 (file)
--- a/include/hashcomp.h
+++ b/include/hashcomp.h
@@ -546,7 +546,7 @@ namespace irc
 
                /** Set free bits mask
                 */
-               virtual void SetFreeBits(unsigned char* freebits) { }
+               virtual void SetFreeBits(unsigned char* freebits) { freebits = freebits; }
        };
 
        /** Turn _ characters in a string into spaces

diff --git a/include/inspircd.h b/include/inspircd.h
index eef05116b9fe3eb2738398ac2aa979329a52a333..67408ad6e195d52ee978297fdcf4cc2d3f0349f9 100644 (file)
--- a/include/inspircd.h
+++ b/include/inspircd.h
@@ -77,7 +77,7 @@ template<typename T> inline std::string ConvNumeric(const T &in)
                ++out;
                quotient /= 10;
        }
-       if ( in < 0)
+       if (in < 0)
                *out++ = '-';
        *out = 0;
        std::reverse(res,out);
@@ -98,13 +98,6 @@ inline std::string ConvToStr(const long in)
        return ConvNumeric(in);
 }
 
-/** Template function to convert any input type to std::string
- */
-inline std::string ConvToStr(const unsigned long in)
-{
-       return ConvNumeric(in);
-}
-
 /** Template function to convert any input type to std::string
  */
 inline std::string ConvToStr(const char* in)

diff --git a/include/users.h b/include/users.h
index 42dccfeb6a13fe37c15a11979aadeb19739e5154..f1dd935e0ff034b66260e2a9dbec4401c93d868d 100644 (file)
--- a/include/users.h
+++ b/include/users.h
@@ -177,7 +177,7 @@ public:
 
        /** Create a new connect class based on an existing connect class. This is required for std::vector (at least under windows).
         */
-       ConnectClass(const ConnectClass& source) : type(source.type), name(source.name),
+       ConnectClass(const ConnectClass& source) : classbase(), type(source.type), name(source.name),
                registration_timeout(source.registration_timeout), flood(source.flood), host(source.host),
                pingtime(source.pingtime), pass(source.pass), threshold(source.threshold), sendqmax(source.sendqmax),
                recvqmax(source.recvqmax), maxlocal(source.maxlocal), maxglobal(source.maxglobal), maxchans(source.maxchans),

diff --git a/src/commands/cmd_stats.cpp b/src/commands/cmd_stats.cpp
index 52172df0675c5fc85d490ce1a8d0aed18624f7b1..fb2e32232859dc60ce727d8845440162a345ee71 100644 (file)
--- a/src/commands/cmd_stats.cpp
+++ b/src/commands/cmd_stats.cpp
@@ -31,7 +31,7 @@ extern "C" DllExport Command* init_command(InspIRCd* Instance)
        return new CommandStats(Instance);
 }
 
-CmdResult CommandStats::Handle (const char** parameters, int pcnt, User *user)
+CmdResult CommandStats::Handle (const char** parameters, int /* pcnt */, User *user)
 {
        if (IS_LOCAL(user))
        {