Either store the Resolver in DNS::AddResolverClass() or delete it before returning

diff --git a/src/dns.cpp b/src/dns.cpp
index ced8b637faf332d1f639f74794c9f6fa01cdaec5..aa340a1de480ba4bef68110098efd489d8e49c98 100644 (file)
--- a/src/dns.cpp
+++ b/src/dns.cpp
@@ -1068,20 +1068,13 @@ bool DNS::AddResolverClass(Resolver* r)
                        Classes[r->GetId()] = r;
                        return true;
                }
-               else
-                       /* Duplicate id */
-                       return false;
        }
-       else
-       {
-               /* Pointer or id not valid.
-                * Free the item and return
-                */
-               if (r)
-                       delete r;
 
-               return false;
-       }
+       /* Pointer or id not valid, or duplicate id.
+        * Free the item and return
+        */
+       delete r;
+       return false;
 }
 
 void DNS::CleanResolvers(Module* module)