Improve launch_here script with the suggestions from ticket #112

diff --git a/launch_here.rb b/launch_here.rb
index 6c48ae08f5cecbf15c994e4bab645816fdad7e1b..ad149d68c6aa96d1eca7ce2b175e1535f0792009 100755 (executable)
--- a/launch_here.rb
+++ b/launch_here.rb
@@ -1,23 +1,18 @@
-#!/usr/bin/ruby\r
-#\r
-# Load rbot from this directory. (No need to install it with setup.rb)\r
-#\r
-\r
-BASEDIR = Dir.pwd\r
-\r
-#puts "Load path: #{$LOAD_PATH.inspect}"\r
+#!/usr/bin/ruby
+#
+# Load rbot from this directory. (No need to install it with setup.rb)
+#
+
+SVN_DIR = File.expand_path(File.dirname('__FILE__'))
+puts "Running from #{SVN_DIR}"
+
+$:.unshift File.join(SVN_DIR, 'lib')
 
-def add_to_path(dir)
-  $LOAD_PATH.unshift dir
-end
-\r
 module Irc
-  module PKGConfig
-    DATADIR = File.join BASEDIR, 'data/rbot'
-    COREDIR = File.join BASEDIR, 'lib/rbot/core'
+  module Config
+    @@datadir = File.join SVN_DIR, 'data/rbot'
+    @@coredir = File.join SVN_DIR, 'lib/rbot/core'
   end
-end\r
-\r
-add_to_path( File.join BASEDIR, 'lib' )\r
-\r
-load( File.join BASEDIR, 'bin/rbot' )
+end
+
+load File.join(SVN_DIR, 'bin/rbot')

diff --git a/lib/rbot/rbotconfig.rb b/lib/rbot/rbotconfig.rb
index 409ab9f8d415fb0feda07cbc3cc9e39527cf25f7..a282d77090b1641f7dd4226bb772d2bda705ed44 100644 (file)
--- a/lib/rbot/rbotconfig.rb
+++ b/lib/rbot/rbotconfig.rb
@@ -1,18 +1,23 @@
 module Irc
   module Config
-    @@datadir = nil
-    @@coredir = nil
+    unless defined?(@@datadir)
+      @@datadir = nil
 
-    # first try for the default path to the data dir
-    defaultdatadir = File.expand_path(File.dirname($0) + '/../data/rbot')
-    defaultcoredir = File.expand_path(File.dirname($0) + '/../lib/rbot/core')
+      defaultdatadir = File.expand_path(File.dirname($0) + '/../data/rbot')
 
-    if File.directory? defaultdatadir
-      @@datadir = defaultdatadir
+      if File.directory? defaultdatadir
+        @@datadir = defaultdatadir
+      end
     end
 
-    if File.directory? defaultcoredir
-      @@coredir = defaultcoredir
+    unless defined?(@@coredir)
+      @@coredir = nil
+
+      defaultcoredir = File.expand_path(File.dirname($0) + '/../lib/rbot/core')
+
+      if File.directory? defaultcoredir
+        @@coredir = defaultcoredir
+      end
     end
 
     # setup pkg-based configuration - i.e. where were we installed to, where