]> git.netwichtig.de Git - user/henk/code/inspircd.git/commitdiff
Merge insp20
authorAttila Molnar <attilamolnar@hush.com>
Sun, 10 May 2015 17:20:06 +0000 (19:20 +0200)
committerAttila Molnar <attilamolnar@hush.com>
Sun, 10 May 2015 17:20:06 +0000 (19:20 +0200)
1  2 
src/modules/extra/m_ssl_gnutls.cpp
src/modules/extra/m_ssl_openssl.cpp
src/modules/m_restrictmsg.cpp

index a2bdb76eebdfa8133cdf21db9617662df608109c,59ac1acb3bcd62295ba9ea5e531ef7479ed480e0..d33403abade42dfef29d4f625f8dc9df1814b1f7
  
  
  #include "inspircd.h"
 -#include <gnutls/gnutls.h>
 -#include <gnutls/x509.h>
 -#include "ssl.h"
 -#include "m_cap.h"
 -
 -#ifdef _WIN32
 -# pragma comment(lib, "libgnutls-28.lib")
 +#include "modules/ssl.h"
 +#include <memory>
 +
 +// Fix warnings about the use of commas at end of enumerator lists on C++03.
 +#if defined __clang__
 +# pragma clang diagnostic ignored "-Wc++11-extensions"
 +#elif defined __GNUC__
 +# pragma GCC diagnostic ignored "-pedantic"
  #endif
  
 -/* $ModDesc: Provides SSL support for clients */
 -/* $CompileFlags: pkgconfincludes("gnutls","/gnutls/gnutls.h","") iflt("pkg-config --modversion gnutls","2.12") exec("libgcrypt-config --cflags") */
 -/* $LinkerFlags: rpath("pkg-config --libs gnutls") pkgconflibs("gnutls","/libgnutls.so","-lgnutls") iflt("pkg-config --modversion gnutls","2.12") exec("libgcrypt-config --libs") */
 -/* $NoPedantic */
 +#include <gnutls/gnutls.h>
 +#include <gnutls/x509.h>
  
 -#ifndef GNUTLS_VERSION_MAJOR
 -#define GNUTLS_VERSION_MAJOR LIBGNUTLS_VERSION_MAJOR
 -#define GNUTLS_VERSION_MINOR LIBGNUTLS_VERSION_MINOR
 -#define GNUTLS_VERSION_PATCH LIBGNUTLS_VERSION_PATCH
 +#ifndef GNUTLS_VERSION_NUMBER
 +#define GNUTLS_VERSION_NUMBER LIBGNUTLS_VERSION_NUMBER
  #endif
  
 -// These don't exist in older GnuTLS versions
 -#if ((GNUTLS_VERSION_MAJOR > 2) || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR > 1) || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR == 1 && GNUTLS_VERSION_PATCH >= 7))
 -#define GNUTLS_NEW_PRIO_API
 -#endif
 +// Check if the GnuTLS library is at least version major.minor.patch
 +#define INSPIRCD_GNUTLS_HAS_VERSION(major, minor, patch) (GNUTLS_VERSION_NUMBER >= ((major << 16) | (minor << 8) | patch))
  
 -#if(GNUTLS_VERSION_MAJOR < 2)
 -typedef gnutls_certificate_credentials_t gnutls_certificate_credentials;
 -typedef gnutls_dh_params_t gnutls_dh_params;
 +#if INSPIRCD_GNUTLS_HAS_VERSION(2, 9, 8)
 +#define GNUTLS_HAS_MAC_GET_ID
 +#include <gnutls/crypto.h>
  #endif
  
 -#if (GNUTLS_VERSION_MAJOR > 2 || (GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR >= 12))
 +#if INSPIRCD_GNUTLS_HAS_VERSION(2, 12, 0)
  # define GNUTLS_HAS_RND
 -# include <gnutls/crypto.h>
  #else
  # include <gcrypt.h>
  #endif
  
 -enum issl_status { ISSL_NONE, ISSL_HANDSHAKING_READ, ISSL_HANDSHAKING_WRITE, ISSL_HANDSHAKEN, ISSL_CLOSING, ISSL_CLOSED };
 -
 -struct SSLConfig : public refcountbase
 -{
 -      gnutls_certificate_credentials_t x509_cred;
 -      std::vector<gnutls_x509_crt_t> x509_certs;
 -      gnutls_x509_privkey_t x509_key;
 -      gnutls_dh_params_t dh_params;
 -#ifdef GNUTLS_NEW_PRIO_API
 -      gnutls_priority_t priority;
 -#endif
 -
 -      SSLConfig()
 -              : x509_cred(NULL)
 -              , x509_key(NULL)
 -              , dh_params(NULL)
 -#ifdef GNUTLS_NEW_PRIO_API
 -              , priority(NULL)
 +#ifdef _WIN32
 +# pragma comment(lib, "libgnutls-28.lib")
  #endif
 -      {
 -      }
 -
 -      ~SSLConfig()
 -      {
 -              ServerInstance->Logs->Log("m_ssl_gnutls", DEBUG, "Destroying SSLConfig %p", (void*)this);
  
 -              if (x509_cred)
 -                      gnutls_certificate_free_credentials(x509_cred);
 +/* $CompileFlags: pkgconfincludes("gnutls","/gnutls/gnutls.h","") eval("print `libgcrypt-config --cflags | tr -d \r` if `pkg-config --modversion gnutls 2>/dev/null | tr -d \r` lt '2.12'") */
 +/* $LinkerFlags: rpath("pkg-config --libs gnutls") pkgconflibs("gnutls","/libgnutls.so","-lgnutls") eval("print `libgcrypt-config --libs | tr -d \r` if `pkg-config --modversion gnutls 2>/dev/null | tr -d \r` lt '2.12'") */
  
 -              for (unsigned int i = 0; i < x509_certs.size(); i++)
 -                      gnutls_x509_crt_deinit(x509_certs[i]);
 -
 -              if (x509_key)
 -                      gnutls_x509_privkey_deinit(x509_key);
 -
 -              if (dh_params)
 -                      gnutls_dh_params_deinit(dh_params);
 +// These don't exist in older GnuTLS versions
 +#if INSPIRCD_GNUTLS_HAS_VERSION(2, 1, 7)
 +#define GNUTLS_NEW_PRIO_API
 +#endif
  
 -#ifdef GNUTLS_NEW_PRIO_API
 -              if (priority)
 -                      gnutls_priority_deinit(priority);
 +#if (!INSPIRCD_GNUTLS_HAS_VERSION(2, 0, 0))
 +typedef gnutls_certificate_credentials_t gnutls_certificate_credentials;
 +typedef gnutls_dh_params_t gnutls_dh_params;
  #endif
 -      }
 -};
  
 -static reference<SSLConfig> currconf;
 +enum issl_status { ISSL_NONE, ISSL_HANDSHAKING, ISSL_HANDSHAKEN };
  
 -static SSLConfig* GetSessionConfig(gnutls_session_t session);
 +#if INSPIRCD_GNUTLS_HAS_VERSION(2, 12, 0)
 +#define INSPIRCD_GNUTLS_HAS_VECTOR_PUSH
 +#define GNUTLS_NEW_CERT_CALLBACK_API
 +typedef gnutls_retr2_st cert_cb_last_param_type;
 +#else
 +typedef gnutls_retr_st cert_cb_last_param_type;
 +#endif
  
 -#if(GNUTLS_VERSION_MAJOR < 2 || ( GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR < 12 ) )
 -static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
 -      const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr_st * st) {
 +#if INSPIRCD_GNUTLS_HAS_VERSION(3, 3, 5)
 +#define INSPIRCD_GNUTLS_HAS_RECV_PACKET
 +#endif
  
 -      st->type = GNUTLS_CRT_X509;
 +#if INSPIRCD_GNUTLS_HAS_VERSION(2, 99, 0)
 +// The second parameter of gnutls_init() has changed in 2.99.0 from gnutls_connection_end_t to unsigned int
 +// (it became a general flags parameter) and the enum has been deprecated and generates a warning on use.
 +typedef unsigned int inspircd_gnutls_session_init_flags_t;
  #else
 -static int cert_callback (gnutls_session_t session, const gnutls_datum_t * req_ca_rdn, int nreqs,
 -      const gnutls_pk_algorithm_t * sign_algos, int sign_algos_length, gnutls_retr2_st * st) {
 -      st->cert_type = GNUTLS_CRT_X509;
 -      st->key_type = GNUTLS_PRIVKEY_X509;
 +typedef gnutls_connection_end_t inspircd_gnutls_session_init_flags_t;
  #endif
 -      SSLConfig* conf = GetSessionConfig(session);
 -      std::vector<gnutls_x509_crt_t>& x509_certs = conf->x509_certs;
 -      st->ncerts = x509_certs.size();
 -      st->cert.x509 = &x509_certs[0];
 -      st->key.x509 = conf->x509_key;
 -      st->deinit_all = 0;
 -
 -      return 0;
 -}
  
  class RandGen : public HandlerBase2<void, char*, size_t>
  {
   public:
 -      RandGen() {}
        void Call(char* buffer, size_t len)
        {
  #ifdef GNUTLS_HAS_RND
        }
  };
  
 -/** Represents an SSL user's extra data
 - */
 -class issl_session
 -{
 -public:
 -      StreamSocket* socket;
 -      gnutls_session_t sess;
 -      issl_status status;
 -      reference<ssl_cert> cert;
 -      reference<SSLConfig> config;
 -
 -      issl_session() : socket(NULL), sess(NULL), status(ISSL_NONE) {}
 -};
 -
 -static SSLConfig* GetSessionConfig(gnutls_session_t sess)
 -{
 -      issl_session* session = reinterpret_cast<issl_session*>(gnutls_transport_get_ptr(sess));
 -      return session->config;
 -}
 -
 -class CommandStartTLS : public SplitCommand
 +namespace GnuTLS
  {
 - public:
 -      bool enabled;
 -      CommandStartTLS (Module* mod) : SplitCommand(mod, "STARTTLS")
 +      class Init
        {
 -              enabled = true;
 -              works_before_reg = true;
 -      }
 +       public:
 +              Init() { gnutls_global_init(); }
 +              ~Init() { gnutls_global_deinit(); }
 +      };
  
 -      CmdResult HandleLocal(const std::vector<std::string> &parameters, LocalUser *user)
 +      class Exception : public ModuleException
        {
 -              if (!enabled)
 -              {
 -                      user->WriteNumeric(691, "%s :STARTTLS is not enabled", user->nick.c_str());
 -                      return CMD_FAILURE;
 -              }
 +       public:
 +              Exception(const std::string& reason)
 +                      : ModuleException(reason) { }
 +      };
  
 -              if (user->registered == REG_ALL)
 -              {
 -                      user->WriteNumeric(691, "%s :STARTTLS is not permitted after client registration is complete", user->nick.c_str());
 -              }
 -              else
 +      void ThrowOnError(int errcode, const char* msg)
 +      {
 +              if (errcode < 0)
                {
 -                      if (!user->eh.GetIOHook())
 -                      {
 -                              user->WriteNumeric(670, "%s :STARTTLS successful, go ahead with TLS handshake", user->nick.c_str());
 -                              /* We need to flush the write buffer prior to adding the IOHook,
 -                               * otherwise we'll be sending this line inside the SSL session - which
 -                               * won't start its handshake until the client gets this line. Currently,
 -                               * we assume the write will not block here; this is usually safe, as
 -                               * STARTTLS is sent very early on in the registration phase, where the
 -                               * user hasn't built up much sendq. Handling a blocked write here would
 -                               * be very annoying.
 -                               */
 -                              user->eh.DoWrite();
 -                              user->eh.AddIOHook(creator);
 -                              creator->OnStreamSocketAccept(&user->eh, NULL, NULL);
 -                      }
 -                      else
 -                              user->WriteNumeric(691, "%s :STARTTLS failure", user->nick.c_str());
 +                      std::string reason = msg;
 +                      reason.append(" :").append(gnutls_strerror(errcode));
 +                      throw Exception(reason);
                }
 -
 -              return CMD_FAILURE;
        }
 -};
 -
 -class ModuleSSLGnuTLS : public Module
 -{
 -      issl_session* sessions;
  
 -      gnutls_digest_algorithm_t hash;
 -
 -      std::string sslports;
 -      int dh_bits;
 +      /** Used to create a gnutls_datum_t* from a std::string
 +       */
 +      class Datum
 +      {
 +              gnutls_datum_t datum;
  
 -      RandGen randhandler;
 -      CommandStartTLS starttls;
 +       public:
 +              Datum(const std::string& dat)
 +              {
 +                      datum.data = (unsigned char*)dat.data();
 +                      datum.size = static_cast<unsigned int>(dat.length());
 +              }
  
 -      GenericCap capHandler;
 -      ServiceProvider iohook;
 +              const gnutls_datum_t* get() const { return &datum; }
 +      };
  
 -      inline static const char* UnknownIfNULL(const char* str)
 +      class Hash
        {
 -              return str ? str : "UNKNOWN";
 -      }
 +              gnutls_digest_algorithm_t hash;
  
 -      static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t session_wrap, void* buffer, size_t size)
 -      {
 -              issl_session* session = reinterpret_cast<issl_session*>(session_wrap);
 -              if (session->socket->GetEventMask() & FD_READ_WILL_BLOCK)
 +       public:
 +              // Nothing to deallocate, constructor may throw freely
 +              Hash(const std::string& hashname)
                {
 -#ifdef _WIN32
 -                      gnutls_transport_set_errno(session->sess, EAGAIN);
 +                      // As older versions of gnutls can't do this, let's disable it where needed.
 +#ifdef GNUTLS_HAS_MAC_GET_ID
 +                      // As gnutls_digest_algorithm_t and gnutls_mac_algorithm_t are mapped 1:1, we can do this
 +                      // There is no gnutls_dig_get_id() at the moment, but it may come later
 +                      hash = (gnutls_digest_algorithm_t)gnutls_mac_get_id(hashname.c_str());
 +                      if (hash == GNUTLS_DIG_UNKNOWN)
 +                              throw Exception("Unknown hash type " + hashname);
 +
 +                      // Check if the user is giving us something that is a valid MAC but not digest
 +                      gnutls_hash_hd_t is_digest;
 +                      if (gnutls_hash_init(&is_digest, hash) < 0)
 +                              throw Exception("Unknown hash type " + hashname);
 +                      gnutls_hash_deinit(is_digest, NULL);
  #else
 -                      errno = EAGAIN;
 +                      if (hashname == "md5")
 +                              hash = GNUTLS_DIG_MD5;
 +                      else if (hashname == "sha1")
 +                              hash = GNUTLS_DIG_SHA1;
 +#ifdef INSPIRCD_GNUTLS_ENABLE_SHA256_FINGERPRINT
 +                      else if (hashname == "sha256")
 +                              hash = GNUTLS_DIG_SHA256;
 +#endif
 +                      else
 +                              throw Exception("Unknown hash type " + hashname);
  #endif
 -                      return -1;
                }
  
 -              int rv = ServerInstance->SE->Recv(session->socket, reinterpret_cast<char *>(buffer), size, 0);
 +              gnutls_digest_algorithm_t get() const { return hash; }
 +      };
  
 -#ifdef _WIN32
 -              if (rv < 0)
 +      class DHParams
 +      {
 +              gnutls_dh_params_t dh_params;
 +
 +              DHParams()
                {
 -                      /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
 -                       * and then set errno appropriately.
 -                       * The gnutls library may also have a different errno variable than us, see
 -                       * gnutls_transport_set_errno(3).
 -                       */
 -                      gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
 +                      ThrowOnError(gnutls_dh_params_init(&dh_params), "gnutls_dh_params_init() failed");
                }
 -#endif
 -
 -              if (rv < (int)size)
 -                      ServerInstance->SE->ChangeEventMask(session->socket, FD_READ_WILL_BLOCK);
 -              return rv;
 -      }
  
 -      static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t session_wrap, const void* buffer, size_t size)
 -      {
 -              issl_session* session = reinterpret_cast<issl_session*>(session_wrap);
 -              if (session->socket->GetEventMask() & FD_WRITE_WILL_BLOCK)
 +       public:
 +              /** Import */
 +              static std::auto_ptr<DHParams> Import(const std::string& dhstr)
                {
 -#ifdef _WIN32
 -                      gnutls_transport_set_errno(session->sess, EAGAIN);
 -#else
 -                      errno = EAGAIN;
 -#endif
 -                      return -1;
 +                      std::auto_ptr<DHParams> dh(new DHParams);
 +                      int ret = gnutls_dh_params_import_pkcs3(dh->dh_params, Datum(dhstr).get(), GNUTLS_X509_FMT_PEM);
 +                      ThrowOnError(ret, "Unable to import DH params");
 +                      return dh;
                }
  
 -              int rv = ServerInstance->SE->Send(session->socket, reinterpret_cast<const char *>(buffer), size, 0);
 -
 -#ifdef _WIN32
 -              if (rv < 0)
 +              /** Generate */
 +              static std::auto_ptr<DHParams> Generate(unsigned int bits)
                {
 -                      /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
 -                       * and then set errno appropriately.
 -                       * The gnutls library may also have a different errno variable than us, see
 -                       * gnutls_transport_set_errno(3).
 -                       */
 -                      gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
 +                      std::auto_ptr<DHParams> dh(new DHParams);
 +                      ThrowOnError(gnutls_dh_params_generate2(dh->dh_params, bits), "Unable to generate DH params");
 +                      return dh;
                }
 -#endif
  
 -              if (rv < (int)size)
 -                      ServerInstance->SE->ChangeEventMask(session->socket, FD_WRITE_WILL_BLOCK);
 -              return rv;
 -      }
 +              ~DHParams()
 +              {
 +                      gnutls_dh_params_deinit(dh_params);
 +              }
  
 - public:
 +              const gnutls_dh_params_t& get() const { return dh_params; }
 +      };
  
 -      ModuleSSLGnuTLS()
 -              : starttls(this), capHandler(this, "tls"), iohook(this, "ssl/gnutls", SERVICE_IOHOOK)
 +      class X509Key
        {
 -#ifndef GNUTLS_HAS_RND
 -              gcry_control (GCRYCTL_INITIALIZATION_FINISHED, 0);
 -#endif
 -
 -              sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 -
 -              gnutls_global_init(); // This must be called once in the program
 -      }
 +              /** Ensure that the key is deinited in case the constructor of X509Key throws
 +               */
 +              class RAIIKey
 +              {
 +               public:
 +                      gnutls_x509_privkey_t key;
  
 -      void init()
 -      {
 -              currconf = new SSLConfig;
 -              InitSSLConfig(currconf);
 +                      RAIIKey()
 +                      {
 +                              ThrowOnError(gnutls_x509_privkey_init(&key), "gnutls_x509_privkey_init() failed");
 +                      }
  
 -              ServerInstance->GenRandom = &randhandler;
 +                      ~RAIIKey()
 +                      {
 +                              gnutls_x509_privkey_deinit(key);
 +                      }
 +              } key;
  
 -              Implementation eventlist[] = { I_On005Numeric, I_OnRehash, I_OnModuleRehash, I_OnUserConnect,
 -                      I_OnEvent, I_OnHookIO, I_OnCheckReady };
 -              ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 +       public:
 +              /** Import */
 +              X509Key(const std::string& keystr)
 +              {
 +                      int ret = gnutls_x509_privkey_import(key.key, Datum(keystr).get(), GNUTLS_X509_FMT_PEM);
 +                      ThrowOnError(ret, "Unable to import private key");
 +              }
  
 -              ServerInstance->Modules->AddService(iohook);
 -              ServerInstance->Modules->AddService(starttls);
 -      }
 +              gnutls_x509_privkey_t& get() { return key.key; }
 +      };
  
 -      void OnRehash(User* user)
 +      class X509CertList
        {
 -              sslports.clear();
 +              std::vector<gnutls_x509_crt_t> certs;
  
 -              ConfigTag* Conf = ServerInstance->Config->ConfValue("gnutls");
 -              starttls.enabled = Conf->getBool("starttls", true);
 -
 -              if (Conf->getBool("showports", true))
 +       public:
 +              /** Import */
 +              X509CertList(const std::string& certstr)
                {
 -                      sslports = Conf->getString("advertisedports");
 -                      if (!sslports.empty())
 -                              return;
 +                      unsigned int certcount = 3;
 +                      certs.resize(certcount);
 +                      Datum datum(certstr);
  
 -                      for (size_t i = 0; i < ServerInstance->ports.size(); i++)
 +                      int ret = gnutls_x509_crt_list_import(raw(), &certcount, datum.get(), GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
 +                      if (ret == GNUTLS_E_SHORT_MEMORY_BUFFER)
                        {
 -                              ListenSocket* port = ServerInstance->ports[i];
 -                              if (port->bind_tag->getString("ssl") != "gnutls")
 -                                      continue;
 -
 -                              const std::string& portid = port->bind_desc;
 -                              ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Enabling SSL for port %s", portid.c_str());
 -
 -                              if (port->bind_tag->getString("type", "clients") == "clients" && port->bind_addr != "127.0.0.1")
 -                              {
 -                                      /*
 -                                       * Found an SSL port for clients that is not bound to 127.0.0.1 and handled by us, display
 -                                       * the IP:port in ISUPPORT.
 -                                       *
 -                                       * We used to advertise all ports seperated by a ';' char that matched the above criteria,
 -                                       * but this resulted in too long ISUPPORT lines if there were lots of ports to be displayed.
 -                                       * To solve this by default we now only display the first IP:port found and let the user
 -                                       * configure the exact value for the 005 token, if necessary.
 -                                       */
 -                                      sslports = portid;
 -                                      break;
 -                              }
 +                              // the buffer wasn't big enough to hold all certs but gnutls changed certcount to the number of available certs,
 +                              // try again with a bigger buffer
 +                              certs.resize(certcount);
 +                              ret = gnutls_x509_crt_list_import(raw(), &certcount, datum.get(), GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
                        }
 -              }
 -      }
  
 -      void OnModuleRehash(User* user, const std::string &param)
 -      {
 -              if(param != "ssl")
 -                      return;
 +                      ThrowOnError(ret, "Unable to load certificates");
  
 -              reference<SSLConfig> newconf = new SSLConfig;
 -              try
 -              {
 -                      InitSSLConfig(newconf);
 +                      // Resize the vector to the actual number of certs because we rely on its size being correct
 +                      // when deallocating the certs
 +                      certs.resize(certcount);
                }
 -              catch (ModuleException& ex)
 +
 +              ~X509CertList()
                {
 -                      ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls: Not applying new config. %s", ex.GetReason());
 -                      return;
 +                      for (std::vector<gnutls_x509_crt_t>::iterator i = certs.begin(); i != certs.end(); ++i)
 +                              gnutls_x509_crt_deinit(*i);
                }
  
 -              ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls: Applying new config, old config is in use by %d connection(s)", currconf->GetReferenceCount()-1);
 -              currconf = newconf;
 -      }
 +              gnutls_x509_crt_t* raw() { return &certs[0]; }
 +              unsigned int size() const { return certs.size(); }
 +      };
  
 -      void InitSSLConfig(SSLConfig* config)
 +      class X509CRL : public refcountbase
        {
 -              ServerInstance->Logs->Log("m_ssl_gnutls", DEBUG, "Initializing new SSLConfig %p", (void*)config);
 -
 -              std::string keyfile;
 -              std::string certfile;
 -              std::string cafile;
 -              std::string crlfile;
 -              OnRehash(NULL);
 -
 -              ConfigTag* Conf = ServerInstance->Config->ConfValue("gnutls");
 -
 -              cafile = Conf->getString("cafile", CONFIG_PATH "/ca.pem");
 -              crlfile = Conf->getString("crlfile", CONFIG_PATH "/crl.pem");
 -              certfile = Conf->getString("certfile", CONFIG_PATH "/cert.pem");
 -              keyfile = Conf->getString("keyfile", CONFIG_PATH "/key.pem");
 -              dh_bits = Conf->getInt("dhbits");
 -              std::string hashname = Conf->getString("hash", "md5");
 -
 -              // The GnuTLS manual states that the gnutls_set_default_priority()
 -              // call we used previously when initializing the session is the same
 -              // as setting the "NORMAL" priority string.
 -              // Thus if the setting below is not in the config we will behave exactly
 -              // the same as before, when the priority setting wasn't available.
 -              std::string priorities = Conf->getString("priority", "NORMAL");
 -
 -              if((dh_bits != 768) && (dh_bits != 1024) && (dh_bits != 2048) && (dh_bits != 3072) && (dh_bits != 4096))
 -                      dh_bits = 1024;
 -
 -              if (hashname == "md5")
 -                      hash = GNUTLS_DIG_MD5;
 -              else if (hashname == "sha1")
 -                      hash = GNUTLS_DIG_SHA1;
 -#ifdef INSPIRCD_GNUTLS_ENABLE_SHA256_FINGERPRINT
 -              else if (hashname == "sha256")
 -                      hash = GNUTLS_DIG_SHA256;
 -#endif
 -              else
 -                      throw ModuleException("Unknown hash type " + hashname);
 -
 +              class RAIICRL
 +              {
 +               public:
 +                      gnutls_x509_crl_t crl;
  
 -              int ret;
 +                      RAIICRL()
 +                      {
 +                              ThrowOnError(gnutls_x509_crl_init(&crl), "gnutls_x509_crl_init() failed");
 +                      }
  
 -              gnutls_certificate_credentials_t& x509_cred = config->x509_cred;
 +                      ~RAIICRL()
 +                      {
 +                              gnutls_x509_crl_deinit(crl);
 +                      }
 +              } crl;
  
 -              ret = gnutls_certificate_allocate_credentials(&x509_cred);
 -              if (ret < 0)
 +       public:
 +              /** Import */
 +              X509CRL(const std::string& crlstr)
                {
 -                      // Set to NULL because we can't be sure what value is in it and we must not try to
 -                      // deallocate it in case of an error
 -                      x509_cred = NULL;
 -                      throw ModuleException("Failed to allocate certificate credentials: " + std::string(gnutls_strerror(ret)));
 +                      int ret = gnutls_x509_crl_import(get(), Datum(crlstr).get(), GNUTLS_X509_FMT_PEM);
 +                      ThrowOnError(ret, "Unable to load certificate revocation list");
                }
  
 -              if((ret =gnutls_certificate_set_x509_trust_file(x509_cred, cafile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
 -                      ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to set X.509 trust file '%s': %s", cafile.c_str(), gnutls_strerror(ret));
 -
 -              if((ret = gnutls_certificate_set_x509_crl_file (x509_cred, crlfile.c_str(), GNUTLS_X509_FMT_PEM)) < 0)
 -                      ServerInstance->Logs->Log("m_ssl_gnutls",DEBUG, "m_ssl_gnutls.so: Failed to set X.509 CRL file '%s': %s", crlfile.c_str(), gnutls_strerror(ret));
 +              gnutls_x509_crl_t& get() { return crl.crl; }
 +      };
  
 -              FileReader reader;
 -
 -              reader.LoadFile(certfile);
 -              std::string cert_string = reader.Contents();
 -              gnutls_datum_t cert_datum = { (unsigned char*)cert_string.data(), static_cast<unsigned int>(cert_string.length()) };
 +#ifdef GNUTLS_NEW_PRIO_API
 +      class Priority
 +      {
 +              gnutls_priority_t priority;
  
 -              reader.LoadFile(keyfile);
 -              std::string key_string = reader.Contents();
 -              gnutls_datum_t key_datum = { (unsigned char*)key_string.data(), static_cast<unsigned int>(key_string.length()) };
 +       public:
 +              Priority(const std::string& priorities)
 +              {
 +                      // Try to set the priorities for ciphers, kex methods etc. to the user supplied string
 +                      // If the user did not supply anything then the string is already set to "NORMAL"
 +                      const char* priocstr = priorities.c_str();
 +                      const char* prioerror;
  
 -              std::vector<gnutls_x509_crt_t>& x509_certs = config->x509_certs;
 +                      int ret = gnutls_priority_init(&priority, priocstr, &prioerror);
 +                      if (ret < 0)
 +                      {
 +                              // gnutls did not understand the user supplied string
 +                              throw Exception("Unable to initialize priorities to \"" + priorities + "\": " + gnutls_strerror(ret) + " Syntax error at position " + ConvToStr((unsigned int) (prioerror - priocstr)));
 +                      }
 +              }
  
 -              // If this fails, no SSL port will work. At all. So, do the smart thing - throw a ModuleException
 -              unsigned int certcount = 3;
 -              x509_certs.resize(certcount);
 -              ret = gnutls_x509_crt_list_import(&x509_certs[0], &certcount, &cert_datum, GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
 -              if (ret == GNUTLS_E_SHORT_MEMORY_BUFFER)
 +              ~Priority()
                {
 -                      // the buffer wasn't big enough to hold all certs but gnutls updated certcount to the number of available certs, try again with a bigger buffer
 -                      x509_certs.resize(certcount);
 -                      ret = gnutls_x509_crt_list_import(&x509_certs[0], &certcount, &cert_datum, GNUTLS_X509_FMT_PEM, GNUTLS_X509_CRT_LIST_IMPORT_FAIL_IF_EXCEED);
 +                      gnutls_priority_deinit(priority);
                }
  
 -              if (ret <= 0)
 +              void SetupSession(gnutls_session_t sess)
                {
 -                      // clear the vector so we won't call gnutls_x509_crt_deinit() on the (uninited) certs later
 -                      x509_certs.clear();
 -                      throw ModuleException("Unable to load GnuTLS server certificate (" + certfile + "): " + ((ret < 0) ? (std::string(gnutls_strerror(ret))) : "No certs could be read"));
 +                      gnutls_priority_set(sess, priority);
                }
 -              x509_certs.resize(ret);
 -
 -              gnutls_x509_privkey_t& x509_key = config->x509_key;
 -              if (gnutls_x509_privkey_init(&x509_key) < 0)
 +      };
 +#else
 +      /** Dummy class, used when gnutls_priority_set() is not available
 +       */
 +      class Priority
 +      {
 +       public:
 +              Priority(const std::string& priorities)
                {
 -                      // Make sure the destructor does not try to deallocate this, see above
 -                      x509_key = NULL;
 -                      throw ModuleException("Unable to initialize private key");
 +                      if (priorities != "NORMAL")
 +                              throw Exception("You've set a non-default priority string, but GnuTLS lacks support for it");
                }
  
 -              if((ret = gnutls_x509_privkey_import(x509_key, &key_datum, GNUTLS_X509_FMT_PEM)) < 0)
 -                      throw ModuleException("Unable to load GnuTLS server private key (" + keyfile + "): " + std::string(gnutls_strerror(ret)));
 -
 -              if((ret = gnutls_certificate_set_x509_key(x509_cred, &x509_certs[0], certcount, x509_key)) < 0)
 -                      throw ModuleException("Unable to set GnuTLS cert/key pair: " + std::string(gnutls_strerror(ret)));
 -
 -              #ifdef GNUTLS_NEW_PRIO_API
 -              // Try to set the priorities for ciphers, kex methods etc. to the user supplied string
 -              // If the user did not supply anything then the string is already set to "NORMAL"
 -              const char* priocstr = priorities.c_str();
 -              const char* prioerror;
 -
 -              gnutls_priority_t& priority = config->priority;
 -              if ((ret = gnutls_priority_init(&priority, priocstr, &prioerror)) < 0)
 +              static void SetupSession(gnutls_session_t sess)
                {
 -                      // gnutls did not understand the user supplied string, log and fall back to the default priorities
 -                      ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to set priorities to \"%s\": %s Syntax error at position %u, falling back to default (NORMAL)", priorities.c_str(), gnutls_strerror(ret), (unsigned int) (prioerror - priocstr));
 -                      gnutls_priority_init(&priority, "NORMAL", NULL);
 +                      // Always set the default priorities
 +                      gnutls_set_default_priority(sess);
                }
 +      };
 +#endif
  
 -              #else
 -              if (priorities != "NORMAL")
 -                      ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: You've set <gnutls:priority> to a value other than the default, but this is only supported with GnuTLS v2.1.7 or newer. Your GnuTLS version is older than that so the option will have no effect.");
 -              #endif
 +      class CertCredentials
 +      {
 +              /** DH parameters associated with these credentials
 +               */
 +              std::auto_ptr<DHParams> dh;
  
 -              #if(GNUTLS_VERSION_MAJOR < 2 || ( GNUTLS_VERSION_MAJOR == 2 && GNUTLS_VERSION_MINOR < 12 ) )
 -              gnutls_certificate_client_set_retrieve_function (x509_cred, cert_callback);
 -              #else
 -              gnutls_certificate_set_retrieve_function (x509_cred, cert_callback);
 -              #endif
 +       protected:
 +              gnutls_certificate_credentials_t cred;
  
 -              gnutls_dh_params_t& dh_params = config->dh_params;
 -              ret = gnutls_dh_params_init(&dh_params);
 -              if (ret < 0)
 +       public:
 +              CertCredentials()
                {
 -                      // Make sure the destructor does not try to deallocate this, see above
 -                      dh_params = NULL;
 -                      ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to initialise DH parameters: %s", gnutls_strerror(ret));
 -                      return;
 +                      ThrowOnError(gnutls_certificate_allocate_credentials(&cred), "Cannot allocate certificate credentials");
                }
  
 -              std::string dhfile = Conf->getString("dhfile");
 -              if (!dhfile.empty())
 +              ~CertCredentials()
                {
 -                      // Try to load DH params from file
 -                      reader.LoadFile(dhfile);
 -                      std::string dhstring = reader.Contents();
 -                      gnutls_datum_t dh_datum = { (unsigned char*)dhstring.data(), static_cast<unsigned int>(dhstring.length()) };
 -
 -                      if ((ret = gnutls_dh_params_import_pkcs3(dh_params, &dh_datum, GNUTLS_X509_FMT_PEM)) < 0)
 -                      {
 -                              // File unreadable or GnuTLS was unhappy with the contents, generate the DH primes now
 -                              ServerInstance->Logs->Log("m_ssl_gnutls", DEFAULT, "m_ssl_gnutls.so: Generating DH parameters because I failed to load them from file '%s': %s", dhfile.c_str(), gnutls_strerror(ret));
 -                              GenerateDHParams(dh_params);
 -                      }
 +                      gnutls_certificate_free_credentials(cred);
                }
 -              else
 +
 +              /** Associates these credentials with the session
 +               */
 +              void SetupSession(gnutls_session_t sess)
                {
 -                      GenerateDHParams(dh_params);
 +                      gnutls_credentials_set(sess, GNUTLS_CRD_CERTIFICATE, cred);
                }
  
 -              gnutls_certificate_set_dh_params(x509_cred, dh_params);
 -      }
 +              /** Set the given DH parameters to be used with these credentials
 +               */
 +              void SetDH(std::auto_ptr<DHParams>& DH)
 +              {
 +                      dh = DH;
 +                      gnutls_certificate_set_dh_params(cred, dh->get());
 +              }
 +      };
  
 -      void GenerateDHParams(gnutls_dh_params_t dh_params)
 +      class X509Credentials : public CertCredentials
        {
 -              // Generate Diffie Hellman parameters - for use with DHE
 -              // kx algorithms. These should be discarded and regenerated
 -              // once a day, once a week or once a month. Depending on the
 -              // security requirements.
 +              /** Private key
 +               */
 +              X509Key key;
  
 -              int ret;
 +              /** Certificate list, presented to the peer
 +               */
 +              X509CertList certs;
  
 -              if((ret = gnutls_dh_params_generate2(dh_params, dh_bits)) < 0)
 -                      ServerInstance->Logs->Log("m_ssl_gnutls",DEFAULT, "m_ssl_gnutls.so: Failed to generate DH parameters (%d bits): %s", dh_bits, gnutls_strerror(ret));
 -      }
 +              /** Trusted CA, may be NULL
 +               */
 +              std::auto_ptr<X509CertList> trustedca;
  
 -      ~ModuleSSLGnuTLS()
 -      {
 -              currconf = NULL;
 +              /** Certificate revocation list, may be NULL
 +               */
 +              std::auto_ptr<X509CRL> crl;
  
 -              gnutls_global_deinit();
 -              delete[] sessions;
 -              ServerInstance->GenRandom = &ServerInstance->HandleGenRandom;
 -      }
 +              static int cert_callback(gnutls_session_t session, const gnutls_datum_t* req_ca_rdn, int nreqs, const gnutls_pk_algorithm_t* sign_algos, int sign_algos_length, cert_cb_last_param_type* st);
  
 -      void OnCleanup(int target_type, void* item)
 -      {
 -              if(target_type == TYPE_USER)
 +       public:
 +              X509Credentials(const std::string& certstr, const std::string& keystr)
 +                      : key(keystr)
 +                      , certs(certstr)
                {
 -                      LocalUser* user = IS_LOCAL(static_cast<User*>(item));
 +                      // Throwing is ok here, the destructor of Credentials is called in that case
 +                      int ret = gnutls_certificate_set_x509_key(cred, certs.raw(), certs.size(), key.get());
 +                      ThrowOnError(ret, "Unable to set cert/key pair");
  
 -                      if (user && user->eh.GetIOHook() == this)
 -                      {
 -                              // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
 -                              // Potentially there could be multiple SSL modules loaded at once on different ports.
 -                              ServerInstance->Users->QuitUser(user, "SSL module unloading");
 -                      }
 +#ifdef GNUTLS_NEW_CERT_CALLBACK_API
 +                      gnutls_certificate_set_retrieve_function(cred, cert_callback);
 +#else
 +                      gnutls_certificate_client_set_retrieve_function(cred, cert_callback);
 +#endif
                }
 -      }
  
 -      Version GetVersion()
 -      {
 -              return Version("Provides SSL support for clients", VF_VENDOR);
 -      }
 +              /** Sets the trusted CA and the certificate revocation list
 +               * to use when verifying certificates
 +               */
 +              void SetCA(std::auto_ptr<X509CertList>& certlist, std::auto_ptr<X509CRL>& CRL)
 +              {
 +                      // Do nothing if certlist is NULL
 +                      if (certlist.get())
 +                      {
 +                              int ret = gnutls_certificate_set_x509_trust(cred, certlist->raw(), certlist->size());
 +                              ThrowOnError(ret, "gnutls_certificate_set_x509_trust() failed");
  
 +                              if (CRL.get())
 +                              {
 +                                      ret = gnutls_certificate_set_x509_crl(cred, &CRL->get(), 1);
 +                                      ThrowOnError(ret, "gnutls_certificate_set_x509_crl() failed");
 +                              }
  
 -      void On005Numeric(std::string &output)
 -      {
 -              if (!sslports.empty())
 -                      output.append(" SSL=" + sslports);
 -              if (starttls.enabled)
 -                      output.append(" STARTTLS");
 -      }
 +                              trustedca = certlist;
 +                              crl = CRL;
 +                      }
 +              }
 +      };
  
 -      void OnHookIO(StreamSocket* user, ListenSocket* lsb)
 +      class DataReader
        {
 -              if (!user->GetIOHook() && lsb->bind_tag->getString("ssl") == "gnutls")
 +              int retval;
 +#ifdef INSPIRCD_GNUTLS_HAS_RECV_PACKET
 +              gnutls_packet_t packet;
 +
 +       public:
 +              DataReader(gnutls_session_t sess)
                {
 -                      /* Hook the user with our module */
 -                      user->AddIOHook(this);
 +                      // Using the packet API avoids the final copy of the data which GnuTLS does if we supply
 +                      // our own buffer. Instead, we get the buffer containing the data from GnuTLS and copy it
 +                      // to the recvq directly from there in appendto().
 +                      retval = gnutls_record_recv_packet(sess, &packet);
                }
 -      }
  
 -      void OnRequest(Request& request)
 -      {
 -              if (strcmp("GET_SSL_CERT", request.id) == 0)
 +              void appendto(std::string& recvq)
                {
 -                      SocketCertificateRequest& req = static_cast<SocketCertificateRequest&>(request);
 -                      int fd = req.sock->GetFd();
 -                      issl_session* session = &sessions[fd];
 +                      // Copy data from GnuTLS buffers to recvq
 +                      gnutls_datum_t datum;
 +                      gnutls_packet_get(packet, &datum, NULL);
 +                      recvq.append(reinterpret_cast<const char*>(datum.data), datum.size);
  
 -                      req.cert = session->cert;
 +                      gnutls_packet_deinit(packet);
                }
 -              else if (!strcmp("GET_RAW_SSL_SESSION", request.id))
 +#else
 +              char* const buffer;
 +
 +       public:
 +              DataReader(gnutls_session_t sess)
 +                      : buffer(ServerInstance->GetReadBuffer())
                {
 -                      SSLRawSessionRequest& req = static_cast<SSLRawSessionRequest&>(request);
 -                      if ((req.fd >= 0) && (req.fd < ServerInstance->SE->GetMaxFds()))
 -                              req.data = reinterpret_cast<void*>(sessions[req.fd].sess);
 +                      // Read data from GnuTLS buffers into ReadBuffer
 +                      retval = gnutls_record_recv(sess, buffer, ServerInstance->Config->NetBufferSize);
                }
 -      }
  
 -      void InitSession(StreamSocket* user, bool me_server)
 -      {
 -              issl_session* session = &sessions[user->GetFd()];
 +              void appendto(std::string& recvq)
 +              {
 +                      // Copy data from ReadBuffer to recvq
 +                      recvq.append(buffer, retval);
 +              }
 +#endif
  
 -              gnutls_init(&session->sess, me_server ? GNUTLS_SERVER : GNUTLS_CLIENT);
 -              session->socket = user;
 -              session->config = currconf;
 +              int ret() const { return retval; }
 +      };
  
 -              #ifdef GNUTLS_NEW_PRIO_API
 -              gnutls_priority_set(session->sess, currconf->priority);
 -              #else
 -              gnutls_set_default_priority(session->sess);
 -              #endif
 -              gnutls_credentials_set(session->sess, GNUTLS_CRD_CERTIFICATE, currconf->x509_cred);
 -              gnutls_dh_set_prime_bits(session->sess, dh_bits);
 -              gnutls_transport_set_ptr(session->sess, reinterpret_cast<gnutls_transport_ptr_t>(session));
 -              gnutls_transport_set_push_function(session->sess, gnutls_push_wrapper);
 -              gnutls_transport_set_pull_function(session->sess, gnutls_pull_wrapper);
 +      class Profile : public refcountbase
 +      {
 +              /** Name of this profile
 +               */
 +              const std::string name;
  
 -              if (me_server)
 -                      gnutls_certificate_server_set_request(session->sess, GNUTLS_CERT_REQUEST); // Request client certificate if any.
 +              /** X509 certificate(s) and key
 +               */
 +              X509Credentials x509cred;
  
 -              Handshake(session, user);
 -      }
 -
 -      void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
 -      {
 -              issl_session* session = &sessions[user->GetFd()];
 -
 -              /* For STARTTLS: Don't try and init a session on a socket that already has a session */
 -              if (session->sess)
 -                      return;
 -
 -              InitSession(user, true);
 -      }
 -
 -      void OnStreamSocketConnect(StreamSocket* user)
 -      {
 -              InitSession(user, false);
 -      }
 -
 -      void OnStreamSocketClose(StreamSocket* user)
 -      {
 -              CloseSession(&sessions[user->GetFd()]);
 -      }
 +              /** The minimum length in bits for the DH prime to be accepted as a client
 +               */
 +              unsigned int min_dh_bits;
  
 -      int OnStreamSocketRead(StreamSocket* user, std::string& recvq)
 -      {
 -              issl_session* session = &sessions[user->GetFd()];
 +              /** Hashing algorithm to use when generating certificate fingerprints
 +               */
 +              Hash hash;
  
 -              if (!session->sess)
 +              /** Priorities for ciphers, compression methods, etc.
 +               */
 +              Priority priority;
 +
 +              Profile(const std::string& profilename, const std::string& certstr, const std::string& keystr,
 +                              std::auto_ptr<DHParams>& DH, unsigned int mindh, const std::string& hashstr,
 +                              const std::string& priostr, std::auto_ptr<X509CertList>& CA, std::auto_ptr<X509CRL>& CRL)
 +                      : name(profilename)
 +                      , x509cred(certstr, keystr)
 +                      , min_dh_bits(mindh)
 +                      , hash(hashstr)
 +                      , priority(priostr)
                {
 -                      CloseSession(session);
 -                      user->SetError("No SSL session");
 -                      return -1;
 +                      x509cred.SetDH(DH);
 +                      x509cred.SetCA(CA, CRL);
                }
  
 -              if (session->status == ISSL_HANDSHAKING_READ || session->status == ISSL_HANDSHAKING_WRITE)
 +              static std::string ReadFile(const std::string& filename)
                {
 -                      // The handshake isn't finished, try to finish it.
 -
 -                      if(!Handshake(session, user))
 -                      {
 -                              if (session->status != ISSL_CLOSING)
 -                                      return 0;
 -                              return -1;
 -                      }
 +                      FileReader reader(filename);
 +                      std::string ret = reader.GetString();
 +                      if (ret.empty())
 +                              throw Exception("Cannot read file " + filename);
 +                      return ret;
                }
  
 -              // If we resumed the handshake then session->status will be ISSL_HANDSHAKEN.
 -
 -              if (session->status == ISSL_HANDSHAKEN)
 +       public:
 +              static reference<Profile> Create(const std::string& profilename, ConfigTag* tag)
                {
 -                      char* buffer = ServerInstance->GetReadBuffer();
 -                      size_t bufsiz = ServerInstance->Config->NetBufferSize;
 -                      int ret = gnutls_record_recv(session->sess, buffer, bufsiz);
 -                      if (ret > 0)
 -                      {
 -                              recvq.append(buffer, ret);
 -                              return 1;
 -                      }
 -                      else if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED)
 -                      {
 -                              return 0;
 -                      }
 -                      else if (ret == 0)
 +                      std::string certstr = ReadFile(tag->getString("certfile", "cert.pem"));
 +                      std::string keystr = ReadFile(tag->getString("keyfile", "key.pem"));
 +
 +                      std::auto_ptr<DHParams> dh;
 +                      int gendh = tag->getInt("gendh");
 +                      if (gendh)
                        {
 -                              user->SetError("Connection closed");
 -                              CloseSession(session);
 -                              return -1;
 +                              gendh = (gendh < 1024 ? 1024 : gendh);
 +                              dh = DHParams::Generate(gendh);
                        }
                        else
 +                              dh = DHParams::Import(ReadFile(tag->getString("dhfile", "dhparams.pem")));
 +
 +                      // Use default priority string if this tag does not specify one
 +                      std::string priostr = tag->getString("priority", "NORMAL");
 +                      unsigned int mindh = tag->getInt("mindhbits", 1024);
 +                      std::string hashstr = tag->getString("hash", "md5");
 +
 +                      // Load trusted CA and revocation list, if set
 +                      std::auto_ptr<X509CertList> ca;
 +                      std::auto_ptr<X509CRL> crl;
 +                      std::string filename = tag->getString("cafile");
 +                      if (!filename.empty())
                        {
 -                              user->SetError(gnutls_strerror(ret));
 -                              CloseSession(session);
 -                              return -1;
 -                      }
 -              }
 -              else if (session->status == ISSL_CLOSING)
 -                      return -1;
 -
 -              return 0;
 -      }
 +                              ca.reset(new X509CertList(ReadFile(filename)));
  
 -      int OnStreamSocketWrite(StreamSocket* user, std::string& sendq)
 -      {
 -              issl_session* session = &sessions[user->GetFd()];
 +                              filename = tag->getString("crlfile");
 +                              if (!filename.empty())
 +                                      crl.reset(new X509CRL(ReadFile(filename)));
 +                      }
  
 -              if (!session->sess)
 -              {
 -                      CloseSession(session);
 -                      user->SetError("No SSL session");
 -                      return -1;
 +                      return new Profile(profilename, certstr, keystr, dh, mindh, hashstr, priostr, ca, crl);
                }
  
 -              if (session->status == ISSL_HANDSHAKING_WRITE || session->status == ISSL_HANDSHAKING_READ)
 +              /** Set up the given session with the settings in this profile
 +               */
 +              void SetupSession(gnutls_session_t sess)
                {
 -                      // The handshake isn't finished, try to finish it.
 -                      Handshake(session, user);
 -                      if (session->status != ISSL_CLOSING)
 -                              return 0;
 -                      return -1;
 +                      priority.SetupSession(sess);
 +                      x509cred.SetupSession(sess);
 +                      gnutls_dh_set_prime_bits(sess, min_dh_bits);
 +
 +                      // Request client certificate if we are a server, no-op if we're a client
 +                      gnutls_certificate_server_set_request(sess, GNUTLS_CERT_REQUEST);
                }
  
 -              int ret = 0;
 +              const std::string& GetName() const { return name; }
 +              X509Credentials& GetX509Credentials() { return x509cred; }
 +              gnutls_digest_algorithm_t GetHash() const { return hash.get(); }
 +      };
 +}
  
 -              if (session->status == ISSL_HANDSHAKEN)
 -              {
 -                      ret = gnutls_record_send(session->sess, sendq.data(), sendq.length());
 +class GnuTLSIOHook : public SSLIOHook
 +{
 + private:
 +      gnutls_session_t sess;
 +      issl_status status;
 +      reference<GnuTLS::Profile> profile;
  
 -                      if (ret == (int)sendq.length())
 -                      {
 -                              ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_WRITE);
 -                              return 1;
 -                      }
 -                      else if (ret > 0)
 -                      {
 -                              sendq = sendq.substr(ret);
 -                              ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
 -                              return 0;
 -                      }
 -                      else if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED || ret == 0)
 -                      {
 -                              ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
 -                              return 0;
 -                      }
 -                      else // (ret < 0)
 -                      {
 -                              user->SetError(gnutls_strerror(ret));
 -                              CloseSession(session);
 -                              return -1;
 -                      }
 +      void CloseSession()
 +      {
 +              if (this->sess)
 +              {
 +                      gnutls_bye(this->sess, GNUTLS_SHUT_WR);
 +                      gnutls_deinit(this->sess);
                }
 -
 -              return 0;
 +              sess = NULL;
 +              certificate = NULL;
 +              status = ISSL_NONE;
        }
  
 -      bool Handshake(issl_session* session, StreamSocket* user)
 +      // Returns 1 if handshake succeeded, 0 if it is still in progress, -1 if it failed
 +      int Handshake(StreamSocket* user)
        {
 -              int ret = gnutls_handshake(session->sess);
 +              int ret = gnutls_handshake(this->sess);
  
                if (ret < 0)
                {
                        if(ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED)
                        {
                                // Handshake needs resuming later, read() or write() would have blocked.
 +                              this->status = ISSL_HANDSHAKING;
  
 -                              if(gnutls_record_get_direction(session->sess) == 0)
 +                              if (gnutls_record_get_direction(this->sess) == 0)
                                {
                                        // gnutls_handshake() wants to read() again.
 -                                      session->status = ISSL_HANDSHAKING_READ;
 -                                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
 +                                      SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
                                }
                                else
                                {
                                        // gnutls_handshake() wants to write() again.
 -                                      session->status = ISSL_HANDSHAKING_WRITE;
 -                                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
 +                                      SocketEngine::ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
                                }
 +
 +                              return 0;
                        }
                        else
                        {
                                user->SetError("Handshake Failed - " + std::string(gnutls_strerror(ret)));
 -                              CloseSession(session);
 -                              session->status = ISSL_CLOSING;
 +                              CloseSession();
 +                              return -1;
                        }
 -
 -                      return false;
                }
                else
                {
                        // Change the seesion state
 -                      session->status = ISSL_HANDSHAKEN;
 +                      this->status = ISSL_HANDSHAKEN;
  
 -                      VerifyCertificate(session,user);
 +                      VerifyCertificate();
  
                        // Finish writing, if any left
 -                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE | FD_ADD_TRIAL_WRITE);
 -
 -                      return true;
 -              }
 -      }
 +                      SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE | FD_ADD_TRIAL_WRITE);
  
 -      void OnUserConnect(LocalUser* user)
 -      {
 -              if (user->eh.GetIOHook() == this)
 -              {
 -                      if (sessions[user->eh.GetFd()].sess)
 -                      {
 -                              const gnutls_session_t& sess = sessions[user->eh.GetFd()].sess;
 -                              std::string cipher = UnknownIfNULL(gnutls_kx_get_name(gnutls_kx_get(sess)));
 -                              cipher.append("-").append(UnknownIfNULL(gnutls_cipher_get_name(gnutls_cipher_get(sess)))).append("-");
 -                              cipher.append(UnknownIfNULL(gnutls_mac_get_name(gnutls_mac_get(sess))));
 -
 -                              ssl_cert* cert = sessions[user->eh.GetFd()].cert;
 -                              if (cert->fingerprint.empty())
 -                                      user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), cipher.c_str());
 -                              else
 -                                      user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\""
 -                                              " and your SSL fingerprint is %s", user->nick.c_str(), cipher.c_str(), cert->fingerprint.c_str());
 -                      }
 -              }
 -      }
 -
 -      void CloseSession(issl_session* session)
 -      {
 -              if (session->sess)
 -              {
 -                      gnutls_bye(session->sess, GNUTLS_SHUT_WR);
 -                      gnutls_deinit(session->sess);
 +                      return 1;
                }
 -              session->socket = NULL;
 -              session->sess = NULL;
 -              session->cert = NULL;
 -              session->status = ISSL_NONE;
 -              session->config = NULL;
        }
  
 -      void VerifyCertificate(issl_session* session, StreamSocket* user)
 +      void VerifyCertificate()
        {
 -              if (!session->sess || !user)
 -                      return;
 -
 -              unsigned int status;
 +              unsigned int certstatus;
                const gnutls_datum_t* cert_list;
                int ret;
                unsigned int cert_list_size;
                gnutls_x509_crt_t cert;
 -              char name[MAXBUF];
 -              unsigned char digest[MAXBUF];
 +              char str[512];
 +              unsigned char digest[512];
                size_t digest_size = sizeof(digest);
 -              size_t name_size = sizeof(name);
 +              size_t name_size = sizeof(str);
                ssl_cert* certinfo = new ssl_cert;
 -              session->cert = certinfo;
 +              this->certificate = certinfo;
  
                /* This verification function uses the trusted CAs in the credentials
                 * structure. So you must have installed one or more CA certificates.
                 */
 -              ret = gnutls_certificate_verify_peers2(session->sess, &status);
 +              ret = gnutls_certificate_verify_peers2(this->sess, &certstatus);
  
                if (ret < 0)
                {
                        return;
                }
  
 -              certinfo->invalid = (status & GNUTLS_CERT_INVALID);
 -              certinfo->unknownsigner = (status & GNUTLS_CERT_SIGNER_NOT_FOUND);
 -              certinfo->revoked = (status & GNUTLS_CERT_REVOKED);
 -              certinfo->trusted = !(status & GNUTLS_CERT_SIGNER_NOT_CA);
 +              certinfo->invalid = (certstatus & GNUTLS_CERT_INVALID);
 +              certinfo->unknownsigner = (certstatus & GNUTLS_CERT_SIGNER_NOT_FOUND);
 +              certinfo->revoked = (certstatus & GNUTLS_CERT_REVOKED);
 +              certinfo->trusted = !(certstatus & GNUTLS_CERT_SIGNER_NOT_CA);
  
                /* Up to here the process is the same for X.509 certificates and
                 * OpenPGP keys. From now on X.509 certificates are assumed. This can
                 * be easily extended to work with openpgp keys as well.
                 */
 -              if (gnutls_certificate_type_get(session->sess) != GNUTLS_CRT_X509)
 +              if (gnutls_certificate_type_get(this->sess) != GNUTLS_CRT_X509)
                {
                        certinfo->error = "No X509 keys sent";
                        return;
                }
  
                cert_list_size = 0;
 -              cert_list = gnutls_certificate_get_peers(session->sess, &cert_list_size);
 +              cert_list = gnutls_certificate_get_peers(this->sess, &cert_list_size);
                if (cert_list == NULL)
                {
                        certinfo->error = "No certificate was found";
                        goto info_done_dealloc;
                }
  
 -              if (gnutls_x509_crt_get_dn(cert, name, &name_size) == 0)
 +              if (gnutls_x509_crt_get_dn(cert, str, &name_size) == 0)
                {
                        std::string& dn = certinfo->dn;
 -                      dn = name;
 +                      dn = str;
                        // Make sure there are no chars in the string that we consider invalid
                        if (dn.find_first_of("\r\n") != std::string::npos)
                                dn.clear();
                }
  
 -              name_size = sizeof(name);
 -              if (gnutls_x509_crt_get_issuer_dn(cert, name, &name_size) == 0)
 +              name_size = sizeof(str);
 +              if (gnutls_x509_crt_get_issuer_dn(cert, str, &name_size) == 0)
                {
                        std::string& issuer = certinfo->issuer;
 -                      issuer = name;
 +                      issuer = str;
                        if (issuer.find_first_of("\r\n") != std::string::npos)
                                issuer.clear();
                }
  
 -              if ((ret = gnutls_x509_crt_get_fingerprint(cert, hash, digest, &digest_size)) < 0)
 +              if ((ret = gnutls_x509_crt_get_fingerprint(cert, profile->GetHash(), digest, &digest_size)) < 0)
                {
                        certinfo->error = gnutls_strerror(ret);
                }
                else
                {
 -                      certinfo->fingerprint = irc::hex(digest, digest_size);
 +                      certinfo->fingerprint = BinToHex(digest, digest_size);
                }
  
                /* Beware here we do not check for errors.
@@@ -777,433 -969,18 +777,446 @@@ info_done_dealloc
                gnutls_x509_crt_deinit(cert);
        }
  
 -      void OnEvent(Event& ev)
 +      // Returns 1 if application I/O should proceed, 0 if it must wait for the underlying protocol to progress, -1 on fatal error
 +      int PrepareIO(StreamSocket* sock)
 +      {
 +              if (status == ISSL_HANDSHAKEN)
 +                      return 1;
 +              else if (status == ISSL_HANDSHAKING)
 +              {
 +                      // The handshake isn't finished, try to finish it
 +                      return Handshake(sock);
 +              }
 +
 +              CloseSession();
 +              sock->SetError("No SSL session");
 +              return -1;
 +      }
 +
 +      static const char* UnknownIfNULL(const char* str)
 +      {
 +              return str ? str : "UNKNOWN";
 +      }
 +
 +      static ssize_t gnutls_pull_wrapper(gnutls_transport_ptr_t session_wrap, void* buffer, size_t size)
 +      {
 +              StreamSocket* sock = reinterpret_cast<StreamSocket*>(session_wrap);
 +#ifdef _WIN32
 +              GnuTLSIOHook* session = static_cast<GnuTLSIOHook*>(sock->GetIOHook());
 +#endif
 +
 +              if (sock->GetEventMask() & FD_READ_WILL_BLOCK)
 +              {
 +#ifdef _WIN32
 +                      gnutls_transport_set_errno(session->sess, EAGAIN);
 +#else
 +                      errno = EAGAIN;
 +#endif
 +                      return -1;
 +              }
 +
 +              int rv = SocketEngine::Recv(sock, reinterpret_cast<char *>(buffer), size, 0);
 +
 +#ifdef _WIN32
 +              if (rv < 0)
 +              {
 +                      /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
 +                       * and then set errno appropriately.
 +                       * The gnutls library may also have a different errno variable than us, see
 +                       * gnutls_transport_set_errno(3).
 +                       */
 +                      gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
 +              }
 +#endif
 +
 +              if (rv < (int)size)
 +                      SocketEngine::ChangeEventMask(sock, FD_READ_WILL_BLOCK);
 +              return rv;
 +      }
 +
 +#ifdef INSPIRCD_GNUTLS_HAS_VECTOR_PUSH
 +      static ssize_t VectorPush(gnutls_transport_ptr_t transportptr, const giovec_t* iov, int iovcnt)
 +      {
 +              StreamSocket* sock = reinterpret_cast<StreamSocket*>(transportptr);
 +#ifdef _WIN32
 +              GnuTLSIOHook* session = static_cast<GnuTLSIOHook*>(sock->GetIOHook());
 +#endif
 +
 +              if (sock->GetEventMask() & FD_WRITE_WILL_BLOCK)
 +              {
 +#ifdef _WIN32
 +                      gnutls_transport_set_errno(session->sess, EAGAIN);
 +#else
 +                      errno = EAGAIN;
 +#endif
 +                      return -1;
 +              }
 +
 +              // Cast the giovec_t to iovec not to IOVector so the correct function is called on Windows
 +              int ret = SocketEngine::WriteV(sock, reinterpret_cast<const iovec*>(iov), iovcnt);
 +#ifdef _WIN32
 +              // See the function above for more info about the usage of gnutls_transport_set_errno() on Windows
 +              if (ret < 0)
 +                      gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
 +#endif
 +
 +              int size = 0;
 +              for (int i = 0; i < iovcnt; i++)
 +                      size += iov[i].iov_len;
 +
 +              if (ret < size)
 +                      SocketEngine::ChangeEventMask(sock, FD_WRITE_WILL_BLOCK);
 +              return ret;
 +      }
 +
 +#else // INSPIRCD_GNUTLS_HAS_VECTOR_PUSH
 +      static ssize_t gnutls_push_wrapper(gnutls_transport_ptr_t session_wrap, const void* buffer, size_t size)
 +      {
 +              StreamSocket* sock = reinterpret_cast<StreamSocket*>(session_wrap);
 +#ifdef _WIN32
 +              GnuTLSIOHook* session = static_cast<GnuTLSIOHook*>(sock->GetIOHook());
 +#endif
 +
 +              if (sock->GetEventMask() & FD_WRITE_WILL_BLOCK)
 +              {
 +#ifdef _WIN32
 +                      gnutls_transport_set_errno(session->sess, EAGAIN);
 +#else
 +                      errno = EAGAIN;
 +#endif
 +                      return -1;
 +              }
 +
 +              int rv = SocketEngine::Send(sock, reinterpret_cast<const char *>(buffer), size, 0);
 +
 +#ifdef _WIN32
 +              if (rv < 0)
 +              {
 +                      /* Windows doesn't use errno, but gnutls does, so check SocketEngine::IgnoreError()
 +                       * and then set errno appropriately.
 +                       * The gnutls library may also have a different errno variable than us, see
 +                       * gnutls_transport_set_errno(3).
 +                       */
 +                      gnutls_transport_set_errno(session->sess, SocketEngine::IgnoreError() ? EAGAIN : errno);
 +              }
 +#endif
 +
 +              if (rv < (int)size)
 +                      SocketEngine::ChangeEventMask(sock, FD_WRITE_WILL_BLOCK);
 +              return rv;
 +      }
 +#endif // INSPIRCD_GNUTLS_HAS_VECTOR_PUSH
 +
 + public:
 +      GnuTLSIOHook(IOHookProvider* hookprov, StreamSocket* sock, inspircd_gnutls_session_init_flags_t flags, const reference<GnuTLS::Profile>& sslprofile)
 +              : SSLIOHook(hookprov)
 +              , sess(NULL)
 +              , status(ISSL_NONE)
 +              , profile(sslprofile)
 +      {
 +              gnutls_init(&sess, flags);
 +              gnutls_transport_set_ptr(sess, reinterpret_cast<gnutls_transport_ptr_t>(sock));
 +#ifdef INSPIRCD_GNUTLS_HAS_VECTOR_PUSH
 +              gnutls_transport_set_vec_push_function(sess, VectorPush);
 +#else
 +              gnutls_transport_set_push_function(sess, gnutls_push_wrapper);
 +#endif
 +              gnutls_transport_set_pull_function(sess, gnutls_pull_wrapper);
 +              profile->SetupSession(sess);
 +
 +              sock->AddIOHook(this);
 +              Handshake(sock);
 +      }
 +
 +      void OnStreamSocketClose(StreamSocket* user) CXX11_OVERRIDE
 +      {
 +              CloseSession();
 +      }
 +
 +      int OnStreamSocketRead(StreamSocket* user, std::string& recvq) CXX11_OVERRIDE
 +      {
 +              // Finish handshake if needed
 +              int prepret = PrepareIO(user);
 +              if (prepret <= 0)
 +                      return prepret;
 +
 +              // If we resumed the handshake then this->status will be ISSL_HANDSHAKEN.
 +              {
 +                      GnuTLS::DataReader reader(sess);
 +                      int ret = reader.ret();
 +                      if (ret > 0)
 +                      {
 +                              reader.appendto(recvq);
 +                              return 1;
 +                      }
 +                      else if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED)
 +                      {
 +                              return 0;
 +                      }
 +                      else if (ret == 0)
 +                      {
 +                              user->SetError("Connection closed");
 +                              CloseSession();
 +                              return -1;
 +                      }
 +                      else
 +                      {
 +                              user->SetError(gnutls_strerror(ret));
 +                              CloseSession();
 +                              return -1;
 +                      }
 +              }
 +      }
 +
 +      int OnStreamSocketWrite(StreamSocket* user, std::string& sendq) CXX11_OVERRIDE
 +      {
 +              // Finish handshake if needed
 +              int prepret = PrepareIO(user);
 +              if (prepret <= 0)
 +                      return prepret;
 +
 +              // Session is ready for transferring application data
 +              int ret = 0;
 +
 +              {
 +                      ret = gnutls_record_send(this->sess, sendq.data(), sendq.length());
 +
 +                      if (ret == (int)sendq.length())
 +                      {
 +                              SocketEngine::ChangeEventMask(user, FD_WANT_NO_WRITE);
 +                              return 1;
 +                      }
 +                      else if (ret > 0)
 +                      {
 +                              sendq.erase(0, ret);
 +                              SocketEngine::ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
 +                              return 0;
 +                      }
 +                      else if (ret == GNUTLS_E_AGAIN || ret == GNUTLS_E_INTERRUPTED || ret == 0)
 +                      {
 +                              SocketEngine::ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
 +                              return 0;
 +                      }
 +                      else // (ret < 0)
 +                      {
 +                              user->SetError(gnutls_strerror(ret));
 +                              CloseSession();
 +                              return -1;
 +                      }
 +              }
 +      }
 +
 +      void TellCiphersAndFingerprint(LocalUser* user)
 +      {
 +              if (sess)
 +              {
 +                      std::string text = "*** You are connected using SSL cipher '";
 +                      GetCiphersuite(text);
 +                      text += '\'';
 +                      if (!certificate->fingerprint.empty())
 +                              text += " and your SSL certificate fingerprint is " + certificate->fingerprint;
 +
 +                      user->WriteNotice(text);
 +              }
 +      }
 +
 +      void GetCiphersuite(std::string& out) const
 +      {
 +              out.append(UnknownIfNULL(gnutls_protocol_get_name(gnutls_protocol_get_version(sess)))).push_back('-');
 +              out.append(UnknownIfNULL(gnutls_kx_get_name(gnutls_kx_get(sess)))).push_back('-');
 +              out.append(UnknownIfNULL(gnutls_cipher_get_name(gnutls_cipher_get(sess)))).push_back('-');
 +              out.append(UnknownIfNULL(gnutls_mac_get_name(gnutls_mac_get(sess))));
 +      }
 +
 +      GnuTLS::Profile* GetProfile() { return profile; }
++      bool IsHandshakeDone() const { return (status == ISSL_HANDSHAKEN); }
 +};
 +
 +int GnuTLS::X509Credentials::cert_callback(gnutls_session_t sess, const gnutls_datum_t* req_ca_rdn, int nreqs, const gnutls_pk_algorithm_t* sign_algos, int sign_algos_length, cert_cb_last_param_type* st)
 +{
 +#ifndef GNUTLS_NEW_CERT_CALLBACK_API
 +      st->type = GNUTLS_CRT_X509;
 +#else
 +      st->cert_type = GNUTLS_CRT_X509;
 +      st->key_type = GNUTLS_PRIVKEY_X509;
 +#endif
 +      StreamSocket* sock = reinterpret_cast<StreamSocket*>(gnutls_transport_get_ptr(sess));
 +      GnuTLS::X509Credentials& cred = static_cast<GnuTLSIOHook*>(sock->GetIOHook())->GetProfile()->GetX509Credentials();
 +
 +      st->ncerts = cred.certs.size();
 +      st->cert.x509 = cred.certs.raw();
 +      st->key.x509 = cred.key.get();
 +      st->deinit_all = 0;
 +
 +      return 0;
 +}
 +
 +class GnuTLSIOHookProvider : public refcountbase, public IOHookProvider
 +{
 +      reference<GnuTLS::Profile> profile;
 +
 + public:
 +      GnuTLSIOHookProvider(Module* mod, reference<GnuTLS::Profile>& prof)
 +              : IOHookProvider(mod, "ssl/" + prof->GetName(), IOHookProvider::IOH_SSL)
 +              , profile(prof)
 +      {
 +              ServerInstance->Modules->AddService(*this);
 +      }
 +
 +      ~GnuTLSIOHookProvider()
 +      {
 +              ServerInstance->Modules->DelService(*this);
 +      }
 +
 +      void OnAccept(StreamSocket* sock, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server) CXX11_OVERRIDE
        {
 -              if (starttls.enabled)
 -                      capHandler.HandleEvent(ev);
 +              new GnuTLSIOHook(this, sock, GNUTLS_SERVER, profile);
 +      }
 +
 +      void OnConnect(StreamSocket* sock) CXX11_OVERRIDE
 +      {
 +              new GnuTLSIOHook(this, sock, GNUTLS_CLIENT, profile);
 +      }
 +};
 +
 +class ModuleSSLGnuTLS : public Module
 +{
 +      typedef std::vector<reference<GnuTLSIOHookProvider> > ProfileList;
 +
 +      // First member of the class, gets constructed first and destructed last
 +      GnuTLS::Init libinit;
 +      RandGen randhandler;
 +      ProfileList profiles;
 +
 +      void ReadProfiles()
 +      {
 +              // First, store all profiles in a new, temporary container. If no problems occur, swap the two
 +              // containers; this way if something goes wrong we can go back and continue using the current profiles,
 +              // avoiding unpleasant situations where no new SSL connections are possible.
 +              ProfileList newprofiles;
 +
 +              ConfigTagList tags = ServerInstance->Config->ConfTags("sslprofile");
 +              if (tags.first == tags.second)
 +              {
 +                      // No <sslprofile> tags found, create a profile named "gnutls" from settings in the <gnutls> block
 +                      const std::string defname = "gnutls";
 +                      ConfigTag* tag = ServerInstance->Config->ConfValue(defname);
 +                      ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "No <sslprofile> tags found; using settings from the <gnutls> tag");
 +
 +                      try
 +                      {
 +                              reference<GnuTLS::Profile> profile(GnuTLS::Profile::Create(defname, tag));
 +                              newprofiles.push_back(new GnuTLSIOHookProvider(this, profile));
 +                      }
 +                      catch (CoreException& ex)
 +                      {
 +                              throw ModuleException("Error while initializing the default SSL profile - " + ex.GetReason());
 +                      }
 +              }
 +
 +              for (ConfigIter i = tags.first; i != tags.second; ++i)
 +              {
 +                      ConfigTag* tag = i->second;
 +                      if (tag->getString("provider") != "gnutls")
 +                              continue;
 +
 +                      std::string name = tag->getString("name");
 +                      if (name.empty())
 +                      {
 +                              ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Ignoring <sslprofile> tag without name at " + tag->getTagLocation());
 +                              continue;
 +                      }
 +
 +                      reference<GnuTLS::Profile> profile;
 +                      try
 +                      {
 +                              profile = GnuTLS::Profile::Create(name, tag);
 +                      }
 +                      catch (CoreException& ex)
 +                      {
 +                              throw ModuleException("Error while initializing SSL profile \"" + name + "\" at " + tag->getTagLocation() + " - " + ex.GetReason());
 +                      }
 +
 +                      newprofiles.push_back(new GnuTLSIOHookProvider(this, profile));
 +              }
 +
 +              // New profiles are ok, begin using them
 +              // Old profiles are deleted when their refcount drops to zero
 +              profiles.swap(newprofiles);
        }
  
 -      ModResult OnCheckReady(LocalUser* user)
 + public:
 +      ModuleSSLGnuTLS()
        {
 -              if ((user->eh.GetIOHook() == this) && (sessions[user->eh.GetFd()].status != ISSL_HANDSHAKEN))
 -                      return MOD_RES_DENY;
 +#ifndef GNUTLS_HAS_RND
 +              gcry_control (GCRYCTL_INITIALIZATION_FINISHED, 0);
 +#endif
 +      }
 +
 +      void init() CXX11_OVERRIDE
 +      {
 +              ReadProfiles();
 +              ServerInstance->GenRandom = &randhandler;
 +      }
 +
 +      void OnModuleRehash(User* user, const std::string &param) CXX11_OVERRIDE
 +      {
 +              if(param != "ssl")
 +                      return;
 +
 +              try
 +              {
 +                      ReadProfiles();
 +              }
 +              catch (ModuleException& ex)
 +              {
 +                      ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, ex.GetReason() + " Not applying settings.");
 +              }
 +      }
 +
 +      ~ModuleSSLGnuTLS()
 +      {
 +              ServerInstance->GenRandom = &ServerInstance->HandleGenRandom;
 +      }
 +
 +      void OnCleanup(int target_type, void* item) CXX11_OVERRIDE
 +      {
 +              if(target_type == TYPE_USER)
 +              {
 +                      LocalUser* user = IS_LOCAL(static_cast<User*>(item));
 +
 +                      if (user && user->eh.GetIOHook() && user->eh.GetIOHook()->prov->creator == this)
 +                      {
 +                              // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
 +                              // Potentially there could be multiple SSL modules loaded at once on different ports.
 +                              ServerInstance->Users->QuitUser(user, "SSL module unloading");
 +                      }
 +              }
 +      }
 +
 +      Version GetVersion() CXX11_OVERRIDE
 +      {
 +              return Version("Provides SSL support for clients", VF_VENDOR);
 +      }
 +
 +      void OnUserConnect(LocalUser* user) CXX11_OVERRIDE
 +      {
 +              IOHook* hook = user->eh.GetIOHook();
 +              if (hook && hook->prov->creator == this)
 +                      static_cast<GnuTLSIOHook*>(hook)->TellCiphersAndFingerprint(user);
 +      }
++
++      ModResult OnCheckReady(LocalUser* user) CXX11_OVERRIDE
++      {
++              if ((user->eh.GetIOHook()) && (user->eh.GetIOHook()->prov->creator == this))
++              {
++                      GnuTLSIOHook* iohook = static_cast<GnuTLSIOHook*>(user->eh.GetIOHook());
++                      if (!iohook->IsHandshakeDone())
++                              return MOD_RES_DENY;
++              }
++
+               return MOD_RES_PASSTHRU;
+       }
  };
  
  MODULE_INIT(ModuleSSLGnuTLS)
index 0fd4608be21702e28abf82807e6e735ba646e37d,b21091d3fddc6f2b6c5ca53bdd26ebd3a0b95c70..c8a035fac60d41702cda6c5bf37ffbd3a102ced2
   * along with this program.  If not, see <http://www.gnu.org/licenses/>.
   */
  
 - /* HACK: This prevents OpenSSL on OS X 10.7 and later from spewing deprecation
 -  * warnings for every single function call. As far as I (SaberUK) know, Apple
 -  * have no plans to remove OpenSSL so this warning just causes needless spam.
 -  */
 -#ifdef __APPLE__
 -# define __AVAILABILITYMACROS__
 -# define DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER
 -#endif
 - 
 +
  #include "inspircd.h"
 +#include "iohook.h"
 +#include "modules/ssl.h"
 +
 +// Ignore OpenSSL deprecation warnings on OS X Lion and newer.
 +#if defined __APPLE__
 +# pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 +#endif
 +
 +// Fix warnings about the use of `long long` on C++03.
 +#if defined __clang__
 +# pragma clang diagnostic ignored "-Wc++11-long-long"
 +#elif defined __GNUC__
 +# pragma GCC diagnostic ignored "-Wlong-long"
 +#endif
 +
  #include <openssl/ssl.h>
  #include <openssl/err.h>
 -#include "ssl.h"
  
  #ifdef _WIN32
  # pragma comment(lib, "ssleay32.lib")
  # pragma comment(lib, "libeay32.lib")
 -# undef MAX_DESCRIPTORS
 -# define MAX_DESCRIPTORS 10000
  #endif
  
 -/* $ModDesc: Provides SSL support for clients */
 -
 -/* $LinkerFlags: if("USE_FREEBSD_BASE_SSL") -lssl -lcrypto */
 -/* $CompileFlags: if(!"USE_FREEBSD_BASE_SSL") pkgconfversion("openssl","0.9.7") pkgconfincludes("openssl","/openssl/ssl.h","") */
 -/* $LinkerFlags: if(!"USE_FREEBSD_BASE_SSL") rpath("pkg-config --libs openssl") pkgconflibs("openssl","/libssl.so","-lssl -lcrypto -ldl") */
 -
 -/* $NoPedantic */
 -
 -
 -class ModuleSSLOpenSSL;
 +/* $CompileFlags: pkgconfversion("openssl","0.9.7") pkgconfincludes("openssl","/openssl/ssl.h","") */
 +/* $LinkerFlags: rpath("pkg-config --libs openssl") pkgconflibs("openssl","/libssl.so","-lssl -lcrypto") */
  
  enum issl_status { ISSL_NONE, ISSL_HANDSHAKING, ISSL_OPEN };
  
  static bool SelfSigned = false;
 -
 -#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
 -static ModuleSSLOpenSSL* opensslmod = NULL;
 -#endif
 +static int exdataindex;
  
  char* get_error()
  {
        return ERR_error_string(ERR_get_error(), NULL);
  }
  
 -static int error_callback(const char *str, size_t len, void *u);
 +static int OnVerify(int preverify_ok, X509_STORE_CTX* ctx);
 +static void StaticSSLInfoCallback(const SSL* ssl, int where, int rc);
  
 -/** Represents an SSL user's extra data
 - */
 -class issl_session
 +namespace OpenSSL
  {
 -public:
 -      SSL* sess;
 -      issl_status status;
 -      reference<ssl_cert> cert;
 -
 -      bool outbound;
 -      bool data_to_write;
 -
 -      issl_session()
 -              : sess(NULL)
 -              , status(ISSL_NONE)
 +      class Exception : public ModuleException
        {
 -              outbound = false;
 -              data_to_write = false;
 -      }
 -};
 -
 -static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 -{
 -      /* XXX: This will allow self signed certificates.
 -       * In the future if we want an option to not allow this,
 -       * we can just return preverify_ok here, and openssl
 -       * will boot off self-signed and invalid peer certs.
 -       */
 -      int ve = X509_STORE_CTX_get_error(ctx);
 +       public:
 +              Exception(const std::string& reason)
 +                      : ModuleException(reason) { }
 +      };
  
 -      SelfSigned = (ve == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT);
 -
 -      return 1;
 -}
 +      class DHParams
 +      {
 +              DH* dh;
  
 -class ModuleSSLOpenSSL : public Module
 -{
 -      issl_session* sessions;
 +       public:
 +              DHParams(const std::string& filename)
 +              {
 +                      BIO* dhpfile = BIO_new_file(filename.c_str(), "r");
 +                      if (dhpfile == NULL)
 +                              throw Exception("Couldn't open DH file " + filename);
  
 -      SSL_CTX* ctx;
 -      SSL_CTX* clictx;
 +                      dh = PEM_read_bio_DHparams(dhpfile, NULL, NULL, NULL);
 +                      BIO_free(dhpfile);
  
 -      long ctx_options;
 -      long clictx_options;
 +                      if (!dh)
 +                              throw Exception("Couldn't read DH params from file " + filename);
 +              }
  
 -      std::string sslports;
 -      bool use_sha;
 +              ~DHParams()
 +              {
 +                      DH_free(dh);
 +              }
  
 -      ServiceProvider iohook;
 +              DH* get()
 +              {
 +                      return dh;
 +              }
 +      };
  
 -      static void SetContextOptions(SSL_CTX* ctx, long defoptions, const std::string& ctxname, ConfigTag* tag)
 +      class Context
        {
 -              long setoptions = tag->getInt(ctxname + "setoptions");
 -              // User-friendly config options for setting context options
 -#ifdef SSL_OP_CIPHER_SERVER_PREFERENCE
 -              if (tag->getBool("cipherserverpref"))
 -                      setoptions |= SSL_OP_CIPHER_SERVER_PREFERENCE;
 +              SSL_CTX* const ctx;
 +              long ctx_options;
 +
 +       public:
 +              Context(SSL_CTX* context)
 +                      : ctx(context)
 +              {
 +                      // Sane default options for OpenSSL see https://www.openssl.org/docs/ssl/SSL_CTX_set_options.html
 +                      // and when choosing a cipher, use the server's preferences instead of the client preferences.
 +                      long opts = SSL_OP_NO_SSLv2 | SSL_OP_NO_SESSION_RESUMPTION_ON_RENEGOTIATION | SSL_OP_CIPHER_SERVER_PREFERENCE | SSL_OP_SINGLE_DH_USE;
 +                      // Only turn options on if they exist
 +#ifdef SSL_OP_SINGLE_ECDH_USE
 +                      opts |= SSL_OP_SINGLE_ECDH_USE;
  #endif
 -#ifdef SSL_OP_NO_COMPRESSION
 -              if (!tag->getBool("compression", true))
 -                      setoptions |= SSL_OP_NO_COMPRESSION;
 +#ifdef SSL_OP_NO_TICKET
 +                      opts |= SSL_OP_NO_TICKET;
  #endif
 -              if (!tag->getBool("sslv3", true))
 -                      setoptions |= SSL_OP_NO_SSLv3;
 -              if (!tag->getBool("tlsv1", true))
 -                      setoptions |= SSL_OP_NO_TLSv1;
  
 -              long clearoptions = tag->getInt(ctxname + "clearoptions");
 -              ServerInstance->Logs->Log("m_ssl_openssl", DEBUG, "Setting OpenSSL %s context options, default: %ld set: %ld clear: %ld", ctxname.c_str(), defoptions, setoptions, clearoptions);
 +                      ctx_options = SSL_CTX_set_options(ctx, opts);
 +                      SSL_CTX_set_mode(ctx, SSL_MODE_ENABLE_PARTIAL_WRITE | SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER);
 +                      SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
 +                      SSL_CTX_set_session_cache_mode(ctx, SSL_SESS_CACHE_OFF);
 +                      SSL_CTX_set_info_callback(ctx, StaticSSLInfoCallback);
 +              }
  
 -              // Clear everything
 -              SSL_CTX_clear_options(ctx, SSL_CTX_get_options(ctx));
 +              ~Context()
 +              {
 +                      SSL_CTX_free(ctx);
 +              }
  
 -              // Set the default options and what is in the conf
 -              SSL_CTX_set_options(ctx, defoptions | setoptions);
 -              long final = SSL_CTX_clear_options(ctx, clearoptions);
 -              ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "OpenSSL %s context options: %ld", ctxname.c_str(), final);
 -      }
 +              bool SetDH(DHParams& dh)
 +              {
 +                      ERR_clear_error();
 +                      return (SSL_CTX_set_tmp_dh(ctx, dh.get()) >= 0);
 +              }
  
  #ifdef INSPIRCD_OPENSSL_ENABLE_ECDH
 -      void SetupECDH(ConfigTag* tag)
 -      {
 -              std::string curvename = tag->getString("ecdhcurve", "prime256v1");
 -              if (curvename.empty())
 -                      return;
 -
 -              int nid = OBJ_sn2nid(curvename.c_str());
 -              if (nid == 0)
 +              void SetECDH(const std::string& curvename)
                {
 -                      ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Unknown curve: \"%s\"", curvename.c_str());
 -                      return;
 +                      int nid = OBJ_sn2nid(curvename.c_str());
 +                      if (nid == 0)
 +                              throw Exception("Unknown curve: " + curvename);
 +
 +                      EC_KEY* eckey = EC_KEY_new_by_curve_name(nid);
 +                      if (!eckey)
 +                              throw Exception("Unable to create EC key object");
 +
 +                      ERR_clear_error();
 +                      bool ret = (SSL_CTX_set_tmp_ecdh(ctx, eckey) >= 0);
 +                      EC_KEY_free(eckey);
 +                      if (!ret)
 +                              throw Exception("Couldn't set ECDH parameters");
                }
 +#endif
  
 -              EC_KEY* eckey = EC_KEY_new_by_curve_name(nid);
 -              if (!eckey)
 +              bool SetCiphers(const std::string& ciphers)
                {
 -                      ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Unable to create EC key object");
 -                      return;
 +                      ERR_clear_error();
 +                      return SSL_CTX_set_cipher_list(ctx, ciphers.c_str());
                }
  
 -              ERR_clear_error();
 -              if (SSL_CTX_set_tmp_ecdh(ctx, eckey) < 0)
 +              bool SetCerts(const std::string& filename)
                {
 -                      ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Couldn't set ECDH parameters");
 -                      ERR_print_errors_cb(error_callback, this);
 +                      ERR_clear_error();
 +                      return SSL_CTX_use_certificate_chain_file(ctx, filename.c_str());
                }
  
 -              EC_KEY_free(eckey);
 -      }
 -#endif
 -
 -#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
 -      static void SSLInfoCallback(const SSL* ssl, int where, int rc)
 -      {
 -              int fd = SSL_get_fd(const_cast<SSL*>(ssl));
 -              issl_session& session = opensslmod->sessions[fd];
 +              bool SetPrivateKey(const std::string& filename)
 +              {
 +                      ERR_clear_error();
 +                      return SSL_CTX_use_PrivateKey_file(ctx, filename.c_str(), SSL_FILETYPE_PEM);
 +              }
  
 -              if ((where & SSL_CB_HANDSHAKE_START) && (session.status == ISSL_OPEN))
 +              bool SetCA(const std::string& filename)
                {
 -                      // The other side is trying to renegotiate, kill the connection and change status
 -                      // to ISSL_NONE so CheckRenego() closes the session
 -                      session.status = ISSL_NONE;
 -                      ServerInstance->SE->Shutdown(fd, 2);
 +                      ERR_clear_error();
 +                      return SSL_CTX_load_verify_locations(ctx, filename.c_str(), 0);
                }
 -      }
  
 -      bool CheckRenego(StreamSocket* sock, issl_session* session)
 -      {
 -              if (session->status != ISSL_NONE)
 -                      return true;
 +              long GetDefaultContextOptions() const
 +              {
 +                      return ctx_options;
 +              }
  
 -              ServerInstance->Logs->Log("m_ssl_openssl", DEBUG, "Session %p killed, attempted to renegotiate", (void*)session->sess);
 -              CloseSession(session);
 -              sock->SetError("Renegotiation is not allowed");
 -              return false;
 -      }
 -#endif
 +              long SetRawContextOptions(long setoptions, long clearoptions)
 +              {
 +                      // Clear everything
 +                      SSL_CTX_clear_options(ctx, SSL_CTX_get_options(ctx));
  
 - public:
 +                      // Set the default options and what is in the conf
 +                      SSL_CTX_set_options(ctx, ctx_options | setoptions);
 +                      return SSL_CTX_clear_options(ctx, clearoptions);
 +              }
  
 -      ModuleSSLOpenSSL() : iohook(this, "ssl/openssl", SERVICE_IOHOOK)
 -      {
 -#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
 -              opensslmod = this;
 -#endif
 -              sessions = new issl_session[ServerInstance->SE->GetMaxFds()];
 +              SSL* CreateServerSession()
 +              {
 +                      SSL* sess = SSL_new(ctx);
 +                      SSL_set_accept_state(sess); // Act as server
 +                      return sess;
 +              }
  
 -              /* Global SSL library initialization*/
 -              SSL_library_init();
 -              SSL_load_error_strings();
 +              SSL* CreateClientSession()
 +              {
 +                      SSL* sess = SSL_new(ctx);
 +                      SSL_set_connect_state(sess); // Act as client
 +                      return sess;
 +              }
 +      };
  
 -              /* Build our SSL contexts:
 -               * NOTE: OpenSSL makes us have two contexts, one for servers and one for clients. ICK.
 +      class Profile : public refcountbase
 +      {
 +              /** Name of this profile
                 */
 -              ctx = SSL_CTX_new( SSLv23_server_method() );
 -              clictx = SSL_CTX_new( SSLv23_client_method() );
 -
 -              SSL_CTX_set_mode(ctx, SSL_MODE_ENABLE_PARTIAL_WRITE | SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER);
 -              SSL_CTX_set_mode(clictx, SSL_MODE_ENABLE_PARTIAL_WRITE | SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER);
 +              const std::string name;
  
 -              SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
 -              SSL_CTX_set_verify(clictx, SSL_VERIFY_PEER | SSL_VERIFY_CLIENT_ONCE, OnVerify);
 +              /** DH parameters in use
 +               */
 +              DHParams dh;
  
 -              SSL_CTX_set_session_cache_mode(ctx, SSL_SESS_CACHE_OFF);
 -              SSL_CTX_set_session_cache_mode(clictx, SSL_SESS_CACHE_OFF);
 +              /** OpenSSL makes us have two contexts, one for servers and one for clients
 +               */
 +              Context ctx;
 +              Context clictx;
  
 -              long opts = SSL_OP_NO_SSLv2 | SSL_OP_SINGLE_DH_USE;
 -              // Only turn options on if they exist
 -#ifdef SSL_OP_SINGLE_ECDH_USE
 -              opts |= SSL_OP_SINGLE_ECDH_USE;
 -#endif
 -#ifdef SSL_OP_NO_TICKET
 -              opts |= SSL_OP_NO_TICKET;
 -#endif
 +              /** Digest to use when generating fingerprints
 +               */
 +              const EVP_MD* digest;
  
 -              ctx_options = SSL_CTX_set_options(ctx, opts);
 -              clictx_options = SSL_CTX_set_options(clictx, opts);
 -      }
 +              /** Last error, set by error_callback()
 +               */
 +              std::string lasterr;
  
 -      void init()
 -      {
 -              // Needs the flag as it ignores a plain /rehash
 -              OnModuleRehash(NULL,"ssl");
 -              Implementation eventlist[] = { I_On005Numeric, I_OnRehash, I_OnModuleRehash, I_OnHookIO, I_OnUserConnect };
 -              ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 -              ServerInstance->Modules->AddService(iohook);
 -      }
 +              /** True if renegotiations are allowed, false if not
 +               */
 +              const bool allowrenego;
  
 -      void OnHookIO(StreamSocket* user, ListenSocket* lsb)
 -      {
 -              if (!user->GetIOHook() && lsb->bind_tag->getString("ssl") == "openssl")
 +              static int error_callback(const char* str, size_t len, void* u)
                {
 -                      /* Hook the user with our module */
 -                      user->AddIOHook(this);
 +                      Profile* profile = reinterpret_cast<Profile*>(u);
 +                      profile->lasterr = std::string(str, len - 1);
 +                      return 0;
                }
 -      }
  
 -      void OnRehash(User* user)
 -      {
 -              sslports.clear();
 +              /** Set raw OpenSSL context (SSL_CTX) options from a config tag
 +               * @param ctxname Name of the context, client or server
 +               * @param tag Config tag defining this profile
 +               * @param context Context object to manipulate
 +               */
 +              void SetContextOptions(const std::string& ctxname, ConfigTag* tag, Context& context)
 +              {
 +                      long setoptions = tag->getInt(ctxname + "setoptions");
 +                      long clearoptions = tag->getInt(ctxname + "clearoptions");
 +#ifdef SSL_OP_NO_COMPRESSION
 +                      if (!tag->getBool("compression", true))
 +                              setoptions |= SSL_OP_NO_COMPRESSION;
 +#endif
 +                      if (!tag->getBool("sslv3", true))
 +                              setoptions |= SSL_OP_NO_SSLv3;
 +                      if (!tag->getBool("tlsv1", true))
 +                              setoptions |= SSL_OP_NO_TLSv1;
  
 -              ConfigTag* Conf = ServerInstance->Config->ConfValue("openssl");
 +                      if (!setoptions && !clearoptions)
 +                              return; // Nothing to do
  
 -#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
 -              // Set the callback if we are not allowing renegotiations, unset it if we do
 -              if (Conf->getBool("renegotiation", true))
 -              {
 -                      SSL_CTX_set_info_callback(ctx, NULL);
 -                      SSL_CTX_set_info_callback(clictx, NULL);
 +                      ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Setting %s %s context options, default: %ld set: %ld clear: %ld", name.c_str(), ctxname.c_str(), ctx.GetDefaultContextOptions(), setoptions, clearoptions);
 +                      long final = context.SetRawContextOptions(setoptions, clearoptions);
 +                      ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "%s %s context options: %ld", name.c_str(), ctxname.c_str(), final);
                }
 -              else
 -              {
 -                      SSL_CTX_set_info_callback(ctx, SSLInfoCallback);
 -                      SSL_CTX_set_info_callback(clictx, SSLInfoCallback);
 -              }
 -#endif
  
 -              if (Conf->getBool("showports", true))
 +       public:
 +              Profile(const std::string& profilename, ConfigTag* tag)
 +                      : name(profilename)
 +                      , dh(ServerInstance->Config->Paths.PrependConfig(tag->getString("dhfile", "dh.pem")))
 +                      , ctx(SSL_CTX_new(SSLv23_server_method()))
 +                      , clictx(SSL_CTX_new(SSLv23_client_method()))
 +                      , allowrenego(tag->getBool("renegotiation", true))
                {
 -                      sslports = Conf->getString("advertisedports");
 -                      if (!sslports.empty())
 -                              return;
 -
 -                      for (size_t i = 0; i < ServerInstance->ports.size(); i++)
 -                      {
 -                              ListenSocket* port = ServerInstance->ports[i];
 -                              if (port->bind_tag->getString("ssl") != "openssl")
 -                                      continue;
 +                      if ((!ctx.SetDH(dh)) || (!clictx.SetDH(dh)))
 +                              throw Exception("Couldn't set DH parameters");
  
 -                              const std::string& portid = port->bind_desc;
 -                              ServerInstance->Logs->Log("m_ssl_openssl", DEFAULT, "m_ssl_openssl.so: Enabling SSL for port %s", portid.c_str());
 +                      std::string hash = tag->getString("hash", "md5");
 +                      digest = EVP_get_digestbyname(hash.c_str());
 +                      if (digest == NULL)
 +                              throw Exception("Unknown hash type " + hash);
  
 -                              if (port->bind_tag->getString("type", "clients") == "clients" && port->bind_addr != "127.0.0.1")
 +                      std::string ciphers = tag->getString("ciphers");
 +                      if (!ciphers.empty())
 +                      {
 +                              if ((!ctx.SetCiphers(ciphers)) || (!clictx.SetCiphers(ciphers)))
                                {
 -                                      /*
 -                                       * Found an SSL port for clients that is not bound to 127.0.0.1 and handled by us, display
 -                                       * the IP:port in ISUPPORT.
 -                                       *
 -                                       * We used to advertise all ports seperated by a ';' char that matched the above criteria,
 -                                       * but this resulted in too long ISUPPORT lines if there were lots of ports to be displayed.
 -                                       * To solve this by default we now only display the first IP:port found and let the user
 -                                       * configure the exact value for the 005 token, if necessary.
 -                                       */
 -                                      sslports = portid;
 -                                      break;
 +                                      ERR_print_errors_cb(error_callback, this);
 +                                      throw Exception("Can't set cipher list to \"" + ciphers + "\" " + lasterr);
                                }
                        }
 -              }
 -      }
 -
 -      void OnModuleRehash(User* user, const std::string &param)
 -      {
 -              if (param != "ssl")
 -                      return;
  
 -              std::string keyfile;
 -              std::string certfile;
 -              std::string cafile;
 -              std::string dhfile;
 -              OnRehash(user);
 -
 -              ConfigTag* conf = ServerInstance->Config->ConfValue("openssl");
 +#ifdef INSPIRCD_OPENSSL_ENABLE_ECDH
 +                      std::string curvename = tag->getString("ecdhcurve", "prime256v1");
 +                      if (!curvename.empty())
 +                              ctx.SetECDH(curvename);
 +#endif
  
 -              cafile   = conf->getString("cafile", CONFIG_PATH "/ca.pem");
 -              certfile = conf->getString("certfile", CONFIG_PATH "/cert.pem");
 -              keyfile  = conf->getString("keyfile", CONFIG_PATH "/key.pem");
 -              dhfile   = conf->getString("dhfile", CONFIG_PATH "/dhparams.pem");
 -              std::string hash = conf->getString("hash", "md5");
 -              if (hash != "sha1" && hash != "md5")
 -                      throw ModuleException("Unknown hash type " + hash);
 -              use_sha = (hash == "sha1");
 +                      SetContextOptions("server", tag, ctx);
 +                      SetContextOptions("client", tag, clictx);
  
 -              if (conf->getBool("customcontextoptions"))
 -              {
 -                      SetContextOptions(ctx, ctx_options, "server", conf);
 -                      SetContextOptions(clictx, clictx_options, "client", conf);
 -              }
 +                      /* Load our keys and certificates
 +                       * NOTE: OpenSSL's error logging API sucks, don't blame us for this clusterfuck.
 +                       */
 +                      std::string filename = ServerInstance->Config->Paths.PrependConfig(tag->getString("certfile", "cert.pem"));
 +                      if ((!ctx.SetCerts(filename)) || (!clictx.SetCerts(filename)))
 +                      {
 +                              ERR_print_errors_cb(error_callback, this);
 +                              throw Exception("Can't read certificate file: " + lasterr);
 +                      }
  
 -              std::string ciphers = conf->getString("ciphers", "");
 +                      filename = ServerInstance->Config->Paths.PrependConfig(tag->getString("keyfile", "key.pem"));
 +                      if ((!ctx.SetPrivateKey(filename)) || (!clictx.SetPrivateKey(filename)))
 +                      {
 +                              ERR_print_errors_cb(error_callback, this);
 +                              throw Exception("Can't read key file: " + lasterr);
 +                      }
  
 -              if (!ciphers.empty())
 -              {
 -                      ERR_clear_error();
 -                      if ((!SSL_CTX_set_cipher_list(ctx, ciphers.c_str())) || (!SSL_CTX_set_cipher_list(clictx, ciphers.c_str())))
 +                      // Load the CAs we trust
 +                      filename = ServerInstance->Config->Paths.PrependConfig(tag->getString("cafile", "ca.pem"));
 +                      if ((!ctx.SetCA(filename)) || (!clictx.SetCA(filename)))
                        {
 -                              ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't set cipher list to %s.", ciphers.c_str());
                                ERR_print_errors_cb(error_callback, this);
 +                              ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Can't read CA list from %s. This is only a problem if you want to verify client certificates, otherwise it's safe to ignore this message. Error: %s", filename.c_str(), lasterr.c_str());
                        }
                }
  
 -              /* Load our keys and certificates
 -               * NOTE: OpenSSL's error logging API sucks, don't blame us for this clusterfuck.
 -               */
 -              ERR_clear_error();
 -              if ((!SSL_CTX_use_certificate_chain_file(ctx, certfile.c_str())) || (!SSL_CTX_use_certificate_chain_file(clictx, certfile.c_str())))
 -              {
 -                      ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read certificate file %s. %s", certfile.c_str(), strerror(errno));
 -                      ERR_print_errors_cb(error_callback, this);
 -              }
 +              const std::string& GetName() const { return name; }
 +              SSL* CreateServerSession() { return ctx.CreateServerSession(); }
 +              SSL* CreateClientSession() { return clictx.CreateClientSession(); }
 +              const EVP_MD* GetDigest() { return digest; }
 +              bool AllowRenegotiation() const { return allowrenego; }
 +      };
 +}
  
 -              ERR_clear_error();
 -              if (((!SSL_CTX_use_PrivateKey_file(ctx, keyfile.c_str(), SSL_FILETYPE_PEM))) || (!SSL_CTX_use_PrivateKey_file(clictx, keyfile.c_str(), SSL_FILETYPE_PEM)))
 -              {
 -                      ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read key file %s. %s", keyfile.c_str(), strerror(errno));
 -                      ERR_print_errors_cb(error_callback, this);
 -              }
 +static int OnVerify(int preverify_ok, X509_STORE_CTX *ctx)
 +{
 +      /* XXX: This will allow self signed certificates.
 +       * In the future if we want an option to not allow this,
 +       * we can just return preverify_ok here, and openssl
 +       * will boot off self-signed and invalid peer certs.
 +       */
 +      int ve = X509_STORE_CTX_get_error(ctx);
  
 -              /* Load the CAs we trust*/
 -              ERR_clear_error();
 -              if (((!SSL_CTX_load_verify_locations(ctx, cafile.c_str(), 0))) || (!SSL_CTX_load_verify_locations(clictx, cafile.c_str(), 0)))
 -              {
 -                      ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Can't read CA list from %s. This is only a problem if you want to verify client certificates, otherwise it's safe to ignore this message. Error: %s", cafile.c_str(), strerror(errno));
 -                      ERR_print_errors_cb(error_callback, this);
 -              }
 +      SelfSigned = (ve == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT);
  
 -#ifdef _WIN32
 -              BIO* dhpfile = BIO_new_file(dhfile.c_str(), "r");
 -#else
 -              FILE* dhpfile = fopen(dhfile.c_str(), "r");
 -#endif
 -              DH* ret;
 +      return 1;
 +}
  
 -              if (dhpfile == NULL)
 -              {
 -                      ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so Couldn't open DH file %s: %s", dhfile.c_str(), strerror(errno));
 -                      throw ModuleException("Couldn't open DH file " + dhfile + ": " + strerror(errno));
 -              }
 -              else
 +class OpenSSLIOHook : public SSLIOHook
 +{
 + private:
 +      SSL* sess;
 +      issl_status status;
 +      bool data_to_write;
 +      reference<OpenSSL::Profile> profile;
 +
 +      // Returns 1 if handshake succeeded, 0 if it is still in progress, -1 if it failed
 +      int Handshake(StreamSocket* user)
 +      {
 +              ERR_clear_error();
 +              int ret = SSL_do_handshake(sess);
 +              if (ret < 0)
                {
 -#ifdef _WIN32
 -                      ret = PEM_read_bio_DHparams(dhpfile, NULL, NULL, NULL);
 -                      BIO_free(dhpfile);
 -#else
 -                      ret = PEM_read_DHparams(dhpfile, NULL, NULL, NULL);
 -#endif
 +                      int err = SSL_get_error(sess, ret);
  
 -                      ERR_clear_error();
 -                      if ((SSL_CTX_set_tmp_dh(ctx, ret) < 0) || (SSL_CTX_set_tmp_dh(clictx, ret) < 0))
 +                      if (err == SSL_ERROR_WANT_READ)
                        {
 -                              ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "m_ssl_openssl.so: Couldn't set DH parameters %s. SSL errors follow:", dhfile.c_str());
 -                              ERR_print_errors_cb(error_callback, this);
 +                              SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
 +                              this->status = ISSL_HANDSHAKING;
 +                              return 0;
 +                      }
 +                      else if (err == SSL_ERROR_WANT_WRITE)
 +                      {
 +                              SocketEngine::ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
 +                              this->status = ISSL_HANDSHAKING;
 +                              return 0;
 +                      }
 +                      else
 +                      {
 +                              CloseSession();
 +                              return -1;
                        }
 -                      DH_free(ret);
                }
 +              else if (ret > 0)
 +              {
 +                      // Handshake complete.
 +                      VerifyCertificate();
  
 -#ifndef _WIN32
 -              fclose(dhpfile);
 -#endif
 -
 -#ifdef INSPIRCD_OPENSSL_ENABLE_ECDH
 -              SetupECDH(conf);
 -#endif
 -      }
 -
 -      void On005Numeric(std::string &output)
 -      {
 -              if (!sslports.empty())
 -                      output.append(" SSL=" + sslports);
 -      }
 +                      status = ISSL_OPEN;
  
 -      ~ModuleSSLOpenSSL()
 -      {
 -              SSL_CTX_free(ctx);
 -              SSL_CTX_free(clictx);
 -              delete[] sessions;
 -      }
 +                      SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE | FD_ADD_TRIAL_WRITE);
  
 -      void OnUserConnect(LocalUser* user)
 -      {
 -              if (user->eh.GetIOHook() == this)
 +                      return 1;
 +              }
 +              else if (ret == 0)
                {
 -                      if (sessions[user->eh.GetFd()].sess)
 -                      {
 -                              if (!sessions[user->eh.GetFd()].cert->fingerprint.empty())
 -                                      user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\""
 -                                              " and your SSL fingerprint is %s", user->nick.c_str(), SSL_get_cipher(sessions[user->eh.GetFd()].sess), sessions[user->eh.GetFd()].cert->fingerprint.c_str());
 -                              else
 -                                      user->WriteServ("NOTICE %s :*** You are connected using SSL cipher \"%s\"", user->nick.c_str(), SSL_get_cipher(sessions[user->eh.GetFd()].sess));
 -                      }
 +                      CloseSession();
                }
 +              return -1;
        }
  
 -      void OnCleanup(int target_type, void* item)
 +      void CloseSession()
        {
 -              if (target_type == TYPE_USER)
 +              if (sess)
                {
 -                      LocalUser* user = IS_LOCAL((User*)item);
 -
 -                      if (user && user->eh.GetIOHook() == this)
 -                      {
 -                              // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
 -                              // Potentially there could be multiple SSL modules loaded at once on different ports.
 -                              ServerInstance->Users->QuitUser(user, "SSL module unloading");
 -                      }
 +                      SSL_shutdown(sess);
 +                      SSL_free(sess);
                }
 +              sess = NULL;
 +              certificate = NULL;
 +              status = ISSL_NONE;
        }
  
 -      Version GetVersion()
 +      void VerifyCertificate()
        {
 -              return Version("Provides SSL support for clients", VF_VENDOR);
 -      }
 +              X509* cert;
 +              ssl_cert* certinfo = new ssl_cert;
 +              this->certificate = certinfo;
 +              unsigned int n;
 +              unsigned char md[EVP_MAX_MD_SIZE];
  
 -      void OnRequest(Request& request)
 -      {
 -              if (strcmp("GET_SSL_CERT", request.id) == 0)
 +              cert = SSL_get_peer_certificate(sess);
 +
 +              if (!cert)
                {
 -                      SocketCertificateRequest& req = static_cast<SocketCertificateRequest&>(request);
 -                      int fd = req.sock->GetFd();
 -                      issl_session* session = &sessions[fd];
 +                      certinfo->error = "Could not get peer certificate: "+std::string(get_error());
 +                      return;
 +              }
 +
 +              certinfo->invalid = (SSL_get_verify_result(sess) != X509_V_OK);
  
 -                      req.cert = session->cert;
 +              if (!SelfSigned)
 +              {
 +                      certinfo->unknownsigner = false;
 +                      certinfo->trusted = true;
                }
 -              else if (!strcmp("GET_RAW_SSL_SESSION", request.id))
 +              else
                {
 -                      SSLRawSessionRequest& req = static_cast<SSLRawSessionRequest&>(request);
 -                      if ((req.fd >= 0) && (req.fd < ServerInstance->SE->GetMaxFds()))
 -                              req.data = reinterpret_cast<void*>(sessions[req.fd].sess);
 +                      certinfo->unknownsigner = true;
 +                      certinfo->trusted = false;
                }
 -      }
 -
 -      void OnStreamSocketAccept(StreamSocket* user, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
 -      {
 -              int fd = user->GetFd();
  
 -              issl_session* session = &sessions[fd];
 +              char buf[512];
 +              X509_NAME_oneline(X509_get_subject_name(cert), buf, sizeof(buf));
 +              certinfo->dn = buf;
 +              // Make sure there are no chars in the string that we consider invalid
 +              if (certinfo->dn.find_first_of("\r\n") != std::string::npos)
 +                      certinfo->dn.clear();
  
 -              session->sess = SSL_new(ctx);
 -              session->status = ISSL_NONE;
 -              session->outbound = false;
 -              session->data_to_write = false;
 +              X509_NAME_oneline(X509_get_issuer_name(cert), buf, sizeof(buf));
 +              certinfo->issuer = buf;
 +              if (certinfo->issuer.find_first_of("\r\n") != std::string::npos)
 +                      certinfo->issuer.clear();
  
 -              if (session->sess == NULL)
 -                      return;
 +              if (!X509_digest(cert, profile->GetDigest(), md, &n))
 +              {
 +                      certinfo->error = "Out of memory generating fingerprint";
 +              }
 +              else
 +              {
 +                      certinfo->fingerprint = BinToHex(md, n);
 +              }
  
 -              if (SSL_set_fd(session->sess, fd) == 0)
 +              if ((ASN1_UTCTIME_cmp_time_t(X509_get_notAfter(cert), ServerInstance->Time()) == -1) || (ASN1_UTCTIME_cmp_time_t(X509_get_notBefore(cert), ServerInstance->Time()) == 0))
                {
 -                      ServerInstance->Logs->Log("m_ssl_openssl",DEBUG,"BUG: Can't set fd with SSL_set_fd: %d", fd);
 -                      return;
 +                      certinfo->error = "Not activated, or expired certificate";
                }
  
 -              Handshake(user, session);
 +              X509_free(cert);
        }
  
 -      void OnStreamSocketConnect(StreamSocket* user)
 +#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
 +      void SSLInfoCallback(int where, int rc)
        {
 -              int fd = user->GetFd();
 -              /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
 -              if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() -1))
 -                      return;
 +              if ((where & SSL_CB_HANDSHAKE_START) && (status == ISSL_OPEN))
 +              {
 +                      if (profile->AllowRenegotiation())
 +                              return;
  
 -              issl_session* session = &sessions[fd];
 +                      // The other side is trying to renegotiate, kill the connection and change status
 +                      // to ISSL_NONE so CheckRenego() closes the session
 +                      status = ISSL_NONE;
 +                      SocketEngine::Shutdown(SSL_get_fd(sess), 2);
 +              }
 +      }
  
 -              session->sess = SSL_new(clictx);
 -              session->status = ISSL_NONE;
 -              session->outbound = true;
 -              session->data_to_write = false;
 +      bool CheckRenego(StreamSocket* sock)
 +      {
 +              if (status != ISSL_NONE)
 +                      return true;
  
 -              if (session->sess == NULL)
 -                      return;
 +              ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Session %p killed, attempted to renegotiate", (void*)sess);
 +              CloseSession();
 +              sock->SetError("Renegotiation is not allowed");
 +              return false;
 +      }
 +#endif
  
 -              if (SSL_set_fd(session->sess, fd) == 0)
 +      // Returns 1 if application I/O should proceed, 0 if it must wait for the underlying protocol to progress, -1 on fatal error
 +      int PrepareIO(StreamSocket* sock)
 +      {
 +              if (status == ISSL_OPEN)
 +                      return 1;
 +              else if (status == ISSL_HANDSHAKING)
                {
 -                      ServerInstance->Logs->Log("m_ssl_openssl",DEBUG,"BUG: Can't set fd with SSL_set_fd: %d", fd);
 -                      return;
 +                      // The handshake isn't finished, try to finish it
 +                      return Handshake(sock);
                }
  
 -              Handshake(user, session);
 +              CloseSession();
 +              return -1;
        }
  
 -      void OnStreamSocketClose(StreamSocket* user)
 +      // Calls our private SSLInfoCallback()
 +      friend void StaticSSLInfoCallback(const SSL* ssl, int where, int rc);
 +
 + public:
 +      OpenSSLIOHook(IOHookProvider* hookprov, StreamSocket* sock, SSL* session, const reference<OpenSSL::Profile>& sslprofile)
 +              : SSLIOHook(hookprov)
 +              , sess(session)
 +              , status(ISSL_NONE)
 +              , data_to_write(false)
 +              , profile(sslprofile)
        {
 -              int fd = user->GetFd();
 -              /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
 -              if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
 +              if (sess == NULL)
                        return;
 +              if (SSL_set_fd(sess, sock->GetFd()) == 0)
 +                      throw ModuleException("Can't set fd with SSL_set_fd: " + ConvToStr(sock->GetFd()));
  
 -              CloseSession(&sessions[fd]);
 +              SSL_set_ex_data(sess, exdataindex, this);
 +              sock->AddIOHook(this);
 +              Handshake(sock);
        }
  
 -      int OnStreamSocketRead(StreamSocket* user, std::string& recvq)
 +      void OnStreamSocketClose(StreamSocket* user) CXX11_OVERRIDE
        {
 -              int fd = user->GetFd();
 -              /* Are there any possibilities of an out of range fd? Hope not, but lets be paranoid */
 -              if ((fd < 0) || (fd > ServerInstance->SE->GetMaxFds() - 1))
 -                      return -1;
 -
 -              issl_session* session = &sessions[fd];
 -
 -              if (!session->sess)
 -              {
 -                      CloseSession(session);
 -                      return -1;
 -              }
 -
 -              if (session->status == ISSL_HANDSHAKING)
 -              {
 -                      // The handshake isn't finished and it wants to read, try to finish it.
 -                      if (!Handshake(user, session))
 -                      {
 -                              // Couldn't resume handshake.
 -                              if (session->status == ISSL_NONE)
 -                                      return -1;
 -                              return 0;
 -                      }
 -              }
 +              CloseSession();
 +      }
  
 -              // If we resumed the handshake then session->status will be ISSL_OPEN
 +      int OnStreamSocketRead(StreamSocket* user, std::string& recvq) CXX11_OVERRIDE
 +      {
 +              // Finish handshake if needed
 +              int prepret = PrepareIO(user);
 +              if (prepret <= 0)
 +                      return prepret;
  
 -              if (session->status == ISSL_OPEN)
 +              // If we resumed the handshake then this->status will be ISSL_OPEN
                {
                        ERR_clear_error();
                        char* buffer = ServerInstance->GetReadBuffer();
                        size_t bufsiz = ServerInstance->Config->NetBufferSize;
 -                      int ret = SSL_read(session->sess, buffer, bufsiz);
 +                      int ret = SSL_read(sess, buffer, bufsiz);
  
  #ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
 -                      if (!CheckRenego(user, session))
 +                      if (!CheckRenego(user))
                                return -1;
  #endif
  
                        if (ret > 0)
                        {
                                recvq.append(buffer, ret);
 -                              if (session->data_to_write)
 -                                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_SINGLE_WRITE);
 +                              if (data_to_write)
 +                                      SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_SINGLE_WRITE);
                                return 1;
                        }
                        else if (ret == 0)
                        {
                                // Client closed connection.
 -                              CloseSession(session);
 +                              CloseSession();
                                user->SetError("Connection closed");
                                return -1;
                        }
 -                      else if (ret < 0)
 +                      else // if (ret < 0)
                        {
 -                              int err = SSL_get_error(session->sess, ret);
 +                              int err = SSL_get_error(sess, ret);
  
                                if (err == SSL_ERROR_WANT_READ)
                                {
 -                                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ);
 +                                      SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ);
                                        return 0;
                                }
                                else if (err == SSL_ERROR_WANT_WRITE)
                                {
 -                                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
 +                                      SocketEngine::ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
                                        return 0;
                                }
                                else
                                {
 -                                      CloseSession(session);
 +                                      CloseSession();
                                        return -1;
                                }
                        }
                }
 -
 -              return 0;
        }
  
 -      int OnStreamSocketWrite(StreamSocket* user, std::string& buffer)
 +      int OnStreamSocketWrite(StreamSocket* user, std::string& buffer) CXX11_OVERRIDE
        {
 -              int fd = user->GetFd();
 -
 -              issl_session* session = &sessions[fd];
 -
 -              if (!session->sess)
 -              {
 -                      CloseSession(session);
 -                      return -1;
 -              }
 +              // Finish handshake if needed
 +              int prepret = PrepareIO(user);
 +              if (prepret <= 0)
 +                      return prepret;
  
 -              session->data_to_write = true;
 -
 -              if (session->status == ISSL_HANDSHAKING)
 -              {
 -                      if (!Handshake(user, session))
 -                      {
 -                              // Couldn't resume handshake.
 -                              if (session->status == ISSL_NONE)
 -                                      return -1;
 -                              return 0;
 -                      }
 -              }
 +              data_to_write = true;
  
 -              if (session->status == ISSL_OPEN)
 +              // Session is ready for transferring application data
                {
                        ERR_clear_error();
 -                      int ret = SSL_write(session->sess, buffer.data(), buffer.size());
 +                      int ret = SSL_write(sess, buffer.data(), buffer.size());
  
  #ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
 -                      if (!CheckRenego(user, session))
 +                      if (!CheckRenego(user))
                                return -1;
  #endif
  
                        if (ret == (int)buffer.length())
                        {
 -                              session->data_to_write = false;
 -                              ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
 +                              data_to_write = false;
 +                              SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
                                return 1;
                        }
                        else if (ret > 0)
                        {
 -                              buffer = buffer.substr(ret);
 -                              ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
 +                              buffer.erase(0, ret);
 +                              SocketEngine::ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
                                return 0;
                        }
                        else if (ret == 0)
                        {
 -                              CloseSession(session);
 +                              CloseSession();
                                return -1;
                        }
 -                      else if (ret < 0)
 +                      else // if (ret < 0)
                        {
 -                              int err = SSL_get_error(session->sess, ret);
 +                              int err = SSL_get_error(sess, ret);
  
                                if (err == SSL_ERROR_WANT_WRITE)
                                {
 -                                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
 +                                      SocketEngine::ChangeEventMask(user, FD_WANT_SINGLE_WRITE);
                                        return 0;
                                }
                                else if (err == SSL_ERROR_WANT_READ)
                                {
 -                                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ);
 +                                      SocketEngine::ChangeEventMask(user, FD_WANT_POLL_READ);
                                        return 0;
                                }
                                else
                                {
 -                                      CloseSession(session);
 +                                      CloseSession();
                                        return -1;
                                }
                        }
                }
 -              return 0;
        }
  
 -      bool Handshake(StreamSocket* user, issl_session* session)
 +      void TellCiphersAndFingerprint(LocalUser* user)
        {
 -              int ret;
 +              if (sess)
 +              {
 +                      std::string text = "*** You are connected using SSL cipher '";
 +                      GetCiphersuite(text);
 +                      text += '\'';
 +                      const std::string& fingerprint = certificate->fingerprint;
 +                      if (!fingerprint.empty())
 +                              text += " and your SSL certificate fingerprint is " + fingerprint;
  
 -              ERR_clear_error();
 -              if (session->outbound)
 -                      ret = SSL_connect(session->sess);
 -              else
 -                      ret = SSL_accept(session->sess);
 +                      user->WriteNotice(text);
 +              }
 +      }
  
 -              if (ret < 0)
 +      void GetCiphersuite(std::string& out) const
 +      {
 +              out.append(SSL_get_version(sess)).push_back('-');
 +              out.append(SSL_get_cipher(sess));
 +      }
++
++      bool IsHandshakeDone() const { return (status == ISSL_OPEN); }
 +};
 +
 +static void StaticSSLInfoCallback(const SSL* ssl, int where, int rc)
 +{
 +#ifdef INSPIRCD_OPENSSL_ENABLE_RENEGO_DETECTION
 +      OpenSSLIOHook* hook = static_cast<OpenSSLIOHook*>(SSL_get_ex_data(ssl, exdataindex));
 +      hook->SSLInfoCallback(where, rc);
 +#endif
 +}
 +
 +class OpenSSLIOHookProvider : public refcountbase, public IOHookProvider
 +{
 +      reference<OpenSSL::Profile> profile;
 +
 + public:
 +      OpenSSLIOHookProvider(Module* mod, reference<OpenSSL::Profile>& prof)
 +              : IOHookProvider(mod, "ssl/" + prof->GetName(), IOHookProvider::IOH_SSL)
 +              , profile(prof)
 +      {
 +              ServerInstance->Modules->AddService(*this);
 +      }
 +
 +      ~OpenSSLIOHookProvider()
 +      {
 +              ServerInstance->Modules->DelService(*this);
 +      }
 +
 +      void OnAccept(StreamSocket* sock, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server) CXX11_OVERRIDE
 +      {
 +              new OpenSSLIOHook(this, sock, profile->CreateServerSession(), profile);
 +      }
 +
 +      void OnConnect(StreamSocket* sock) CXX11_OVERRIDE
 +      {
 +              new OpenSSLIOHook(this, sock, profile->CreateClientSession(), profile);
 +      }
 +};
 +
 +class ModuleSSLOpenSSL : public Module
 +{
 +      typedef std::vector<reference<OpenSSLIOHookProvider> > ProfileList;
 +
 +      ProfileList profiles;
 +
 +      void ReadProfiles()
 +      {
 +              ProfileList newprofiles;
 +              ConfigTagList tags = ServerInstance->Config->ConfTags("sslprofile");
 +              if (tags.first == tags.second)
                {
 -                      int err = SSL_get_error(session->sess, ret);
 +                      // Create a default profile named "openssl"
 +                      const std::string defname = "openssl";
 +                      ConfigTag* tag = ServerInstance->Config->ConfValue(defname);
 +                      ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "No <sslprofile> tags found, using settings from the <openssl> tag");
  
 -                      if (err == SSL_ERROR_WANT_READ)
 +                      try
                        {
 -                              ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
 -                              session->status = ISSL_HANDSHAKING;
 -                              return true;
 +                              reference<OpenSSL::Profile> profile(new OpenSSL::Profile(defname, tag));
 +                              newprofiles.push_back(new OpenSSLIOHookProvider(this, profile));
                        }
 -                      else if (err == SSL_ERROR_WANT_WRITE)
 +                      catch (OpenSSL::Exception& ex)
                        {
 -                              ServerInstance->SE->ChangeEventMask(user, FD_WANT_NO_READ | FD_WANT_SINGLE_WRITE);
 -                              session->status = ISSL_HANDSHAKING;
 -                              return true;
 +                              throw ModuleException("Error while initializing the default SSL profile - " + ex.GetReason());
                        }
 -                      else
 -                      {
 -                              CloseSession(session);
 -                      }
 -
 -                      return false;
                }
 -              else if (ret > 0)
 +
 +              for (ConfigIter i = tags.first; i != tags.second; ++i)
                {
 -                      // Handshake complete.
 -                      VerifyCertificate(session, user);
 +                      ConfigTag* tag = i->second;
 +                      if (tag->getString("provider") != "openssl")
 +                              continue;
  
 -                      session->status = ISSL_OPEN;
 +                      std::string name = tag->getString("name");
 +                      if (name.empty())
 +                      {
 +                              ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Ignoring <sslprofile> tag without name at " + tag->getTagLocation());
 +                              continue;
 +                      }
  
 -                      ServerInstance->SE->ChangeEventMask(user, FD_WANT_POLL_READ | FD_WANT_NO_WRITE | FD_ADD_TRIAL_WRITE);
 +                      reference<OpenSSL::Profile> profile;
 +                      try
 +                      {
 +                              profile = new OpenSSL::Profile(name, tag);
 +                      }
 +                      catch (CoreException& ex)
 +                      {
 +                              throw ModuleException("Error while initializing SSL profile \"" + name + "\" at " + tag->getTagLocation() + " - " + ex.GetReason());
 +                      }
  
 -                      return true;
 +                      newprofiles.push_back(new OpenSSLIOHookProvider(this, profile));
                }
 -              else if (ret == 0)
 -              {
 -                      CloseSession(session);
 -              }
 -              return false;
 +
 +              profiles.swap(newprofiles);
        }
  
 -      void CloseSession(issl_session* session)
 + public:
 +      ModuleSSLOpenSSL()
        {
 -              if (session->sess)
 -              {
 -                      SSL_shutdown(session->sess);
 -                      SSL_free(session->sess);
 -              }
 -
 -              session->sess = NULL;
 -              session->status = ISSL_NONE;
 -              session->cert = NULL;
 +              // Initialize OpenSSL
 +              SSL_library_init();
 +              SSL_load_error_strings();
        }
  
 -      void VerifyCertificate(issl_session* session, StreamSocket* user)
 +      void init() CXX11_OVERRIDE
        {
 -              if (!session->sess || !user)
 -                      return;
 -
 -              X509* cert;
 -              ssl_cert* certinfo = new ssl_cert;
 -              session->cert = certinfo;
 -              unsigned int n;
 -              unsigned char md[EVP_MAX_MD_SIZE];
 -              const EVP_MD *digest = use_sha ? EVP_sha1() : EVP_md5();
 +              // Register application specific data
 +              char exdatastr[] = "inspircd";
 +              exdataindex = SSL_get_ex_new_index(0, exdatastr, NULL, NULL, NULL);
 +              if (exdataindex < 0)
 +                      throw ModuleException("Failed to register application specific data");
  
 -              cert = SSL_get_peer_certificate((SSL*)session->sess);
 +              ReadProfiles();
 +      }
  
 -              if (!cert)
 -              {
 -                      certinfo->error = "Could not get peer certificate: "+std::string(get_error());
 +      void OnModuleRehash(User* user, const std::string &param) CXX11_OVERRIDE
 +      {
 +              if (param != "ssl")
                        return;
 -              }
  
 -              certinfo->invalid = (SSL_get_verify_result(session->sess) != X509_V_OK);
 -
 -              if (!SelfSigned)
 +              try
                {
 -                      certinfo->unknownsigner = false;
 -                      certinfo->trusted = true;
 +                      ReadProfiles();
                }
 -              else
 +              catch (ModuleException& ex)
                {
 -                      certinfo->unknownsigner = true;
 -                      certinfo->trusted = false;
 +                      ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, ex.GetReason() + " Not applying settings.");
                }
 +      }
  
 -              char buf[512];
 -              X509_NAME_oneline(X509_get_subject_name(cert), buf, sizeof(buf));
 -              certinfo->dn = buf;
 -              // Make sure there are no chars in the string that we consider invalid
 -              if (certinfo->dn.find_first_of("\r\n") != std::string::npos)
 -                      certinfo->dn.clear();
 -
 -              X509_NAME_oneline(X509_get_issuer_name(cert), buf, sizeof(buf));
 -              certinfo->issuer = buf;
 -              if (certinfo->issuer.find_first_of("\r\n") != std::string::npos)
 -                      certinfo->issuer.clear();
 +      void OnUserConnect(LocalUser* user) CXX11_OVERRIDE
 +      {
 +              IOHook* hook = user->eh.GetIOHook();
 +              if (hook && hook->prov->creator == this)
 +                      static_cast<OpenSSLIOHook*>(hook)->TellCiphersAndFingerprint(user);
 +      }
  
 -              if (!X509_digest(cert, digest, md, &n))
 -              {
 -                      certinfo->error = "Out of memory generating fingerprint";
 -              }
 -              else
 +      void OnCleanup(int target_type, void* item) CXX11_OVERRIDE
 +      {
 +              if (target_type == TYPE_USER)
                {
 -                      certinfo->fingerprint = irc::hex(md, n);
 +                      LocalUser* user = IS_LOCAL((User*)item);
 +
 +                      if (user && user->eh.GetIOHook() && user->eh.GetIOHook()->prov->creator == this)
 +                      {
 +                              // User is using SSL, they're a local user, and they're using one of *our* SSL ports.
 +                              // Potentially there could be multiple SSL modules loaded at once on different ports.
 +                              ServerInstance->Users->QuitUser(user, "SSL module unloading");
 +                      }
                }
 +      }
  
 -              if ((ASN1_UTCTIME_cmp_time_t(X509_get_notAfter(cert), ServerInstance->Time()) == -1) || (ASN1_UTCTIME_cmp_time_t(X509_get_notBefore(cert), ServerInstance->Time()) == 0))
++      ModResult OnCheckReady(LocalUser* user) CXX11_OVERRIDE
++      {
++              if ((user->eh.GetIOHook()) && (user->eh.GetIOHook()->prov->creator == this))
+               {
 -                      certinfo->error = "Not activated, or expired certificate";
++                      OpenSSLIOHook* iohook = static_cast<OpenSSLIOHook*>(user->eh.GetIOHook());
++                      if (!iohook->IsHandshakeDone())
++                              return MOD_RES_DENY;
+               }
 -              X509_free(cert);
++              return MOD_RES_PASSTHRU;
+       }
 -};
 -static int error_callback(const char *str, size_t len, void *u)
 -{
 -      ServerInstance->Logs->Log("m_ssl_openssl",DEFAULT, "SSL error: " + std::string(str, len - 1));
 -
 -      //
 -      // XXX: Remove this line, it causes valgrind warnings...
 -      //
 -      // MD_update(&m, buf, j);
 -      //
 -      //
 -      // ... ONLY JOKING! :-)
 -      //
 -
 -      return 0;
 -}
 +      Version GetVersion() CXX11_OVERRIDE
 +      {
 +              return Version("Provides SSL support for clients", VF_VENDOR);
 +      }
 +};
  
  MODULE_INIT(ModuleSSLOpenSSL)
index e0887e58714dc051e8a3945e6dab10e8cd9ef5b5,2a9f1dc9328646a228ac846c0be8d76d3e6cc9c3..279775d480570621bb58a9f3464c390271a0d0b7
  
  #include "inspircd.h"
  
 -/* $ModDesc: Forbids users from messaging each other. Users may still message opers and opers may message other opers. */
 -
 -
  class ModuleRestrictMsg : public Module
  {
 - private:
 -      bool uline;
 -
   public:
 -
 -      void init()
 -      {
 -              OnRehash(NULL);
 -              Implementation eventlist[] = { I_OnRehash, I_OnUserPreMessage, I_OnUserPreNotice };
 -              ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 -      }
 -
 -      void OnRehash(User*)
 -      {
 -              uline = ServerInstance->Config->ConfValue("restrictmsg")->getBool("uline", false);
 -      }
 -
 -      virtual ModResult OnUserPreMessage(User* user,void* dest,int target_type, std::string &text, char status, CUList &exempt_list)
 +      ModResult OnUserPreMessage(User* user, void* dest, int target_type, std::string& text, char status, CUList& exempt_list, MessageType msgtype) CXX11_OVERRIDE
        {
                if ((target_type == TYPE_USER) && (IS_LOCAL(user)))
                {
                        // message allowed if:
                        // (1) the sender is opered
                        // (2) the recipient is opered
+                       // (3) the recipient is on a ulined server
                        // anything else, blocked.
-                       if (u->IsOper() || user->IsOper())
 -                      if (IS_OPER(u) || IS_OPER(user) || (uline && ServerInstance->ULine(u->server)))
++                      if (u->IsOper() || user->IsOper() || u->server->IsULine())
                        {
                                return MOD_RES_PASSTHRU;
                        }
 -                      user->WriteNumeric(ERR_CANTSENDTOUSER, "%s %s :You are not permitted to send private messages to this user",user->nick.c_str(),u->nick.c_str());
 +                      user->WriteNumeric(ERR_CANTSENDTOUSER, "%s :You are not permitted to send private messages to this user", u->nick.c_str());
                        return MOD_RES_DENY;
                }
  
                return MOD_RES_PASSTHRU;
        }
  
 -      virtual ModResult OnUserPreNotice(User* user,void* dest,int target_type, std::string &text, char status, CUList &exempt_list)
 -      {
 -              return this->OnUserPreMessage(user,dest,target_type,text,status,exempt_list);
 -      }
 -
 -      virtual ~ModuleRestrictMsg()
 -      {
 -      }
 -
 -      virtual Version GetVersion()
 +      Version GetVersion() CXX11_OVERRIDE
        {
                return Version("Forbids users from messaging each other. Users may still message opers and opers may message other opers.",VF_VENDOR);
        }