userrec::CountGlobalClones malfunctioning, spotted by jamie, fixes bug#157 effecting...

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@5369 e03df62e-2008-0410-955e-edbf42e46eb7

diff --git a/src/users.cpp b/src/users.cpp
index bb6b71782cdf454f6955ccfbca34db0ef05b7265..a67826fe5a8ecfc8604cbb54a3646adb6ac94b2a 100644 (file)
--- a/src/users.cpp
+++ b/src/users.cpp
@@ -983,18 +983,16 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
 
 long userrec::GlobalCloneCount()
 {
-       char u1[128] = {0};
-       char u2[128] = {0};
+       char u1[128];
+       char u2[128];
        long x = 0;
-       
-       this->GetIPString(u2);
-       
+
        for (user_hash::const_iterator a = ServerInstance->clientlist.begin(); a != ServerInstance->clientlist.end(); a++)
        {
                /* We have to match ip's as strings - we don't know what protocol
                 * a remote user may be using
                 */
-               if (strcmp(a->second->GetIPString(u1), u2) == 0)
+               if (strcmp(a->second->GetIPString(u1), this->GetIPString(u2)) == 0)
                        x++;
        }