From: w00t <w00t@e03df62e-2008-0410-955e-edbf42e46eb7>
Date: Wed, 21 May 2008 09:58:31 +0000 (+0000)
Subject: Remove some of this, this isn't (strictly speaking) an issue now
X-Git-Tag: v2.0.23~3116
X-Git-Url: https://git.netwichtig.de/gitweb/?a=commitdiff_plain;h=4501f0ec9ccff833e20a99ff90bd9b13a7d80fe2;hp=6f15bf7aa083ff56b3d2ce965a6a3dcb6e46bd63;p=user%2Fhenk%2Fcode%2Finspircd.git

Remove some of this, this isn't (strictly speaking) an issue now

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@9784 e03df62e-2008-0410-955e-edbf42e46eb7
---

diff --git a/src/cull_list.cpp b/src/cull_list.cpp
index 9d8bb3bae..ddbf6acae 100644
--- a/src/cull_list.cpp
+++ b/src/cull_list.cpp
@@ -117,20 +117,13 @@ int CullList::Apply()
 			u->AddToWhoWas();
 		}
 
-		bool deleteu = true;
-
 		if (iter != ServerInstance->Users->clientlist->end())
 		{
 			ServerInstance->Users->clientlist->erase(iter);
 		}
 		else
 		{
-			/*
-			 * Trying to track down Jason's issue.. this should never happen obviously.
-			 */
-			ServerInstance->Logs->Log("CULLLIST", DEBUG, "iter == clientlist->end, can't remove them from hash... problematic?");
-//			deleteu = false;
-// actually, delete them anyway.. the local vector is the real problem here
+			ServerInstance->Logs->Log("CULLLIST", DEBUG, "iter == clientlist->end, can't remove them from hash... problematic..");
 		}
 
 		if (IS_LOCAL(u))
@@ -140,22 +133,11 @@ int CullList::Apply()
 				ServerInstance->Users->local_users.erase(x);
 			else
 			{
-				/*
-				 * This code is in here to monitor an issue of Jason's, where it seems to be trying to quit already quit users.
-				 * The only way that can happen is if this find fails, so log it just in case.
-				 * Also, (perhaps incorrectly, but oh well), return here so we don't delete the user and then start trampling
-				 * on deleted memory, which leads to big problems..
-				 */
-				ServerInstance->Logs->Log("CULLLIST", DEBUG, "Failed to remove user from vector, we're all gonna die!!! Not deleting the user to save our sanity");
-				deleteu = false;
+				ServerInstance->Logs->Log("CULLLIST", DEBUG, "Failed to remove user from vector..");
 			}
 		}
 
-		if (deleteu)
-		{
-			delete u;
-		}
-
+		delete u;
 		list.erase(list.begin());
 	}