From: Attila Molnar <attilamolnar@hush.com>
Date: Sun, 22 Jun 2014 11:22:44 +0000 (+0200)
Subject: core_ison Use iterators
X-Git-Url: https://git.netwichtig.de/gitweb/?a=commitdiff_plain;h=ee0c7d07afb33935e1f7f23144e2e33ced33f762;hp=8670d8c51f1debd8afb6732e782fc61d2e479349;p=user%2Fhenk%2Fcode%2Finspircd.git

core_ison Use iterators
---

diff --git a/src/coremods/core_ison.cpp b/src/coremods/core_ison.cpp
index 8c1c3d2f5..ebb43bdf9 100644
--- a/src/coremods/core_ison.cpp
+++ b/src/coremods/core_ison.cpp
@@ -65,20 +65,21 @@ bool CommandIson::AddNick(User* user, User* toadd, std::string& reply, const std
  */
 CmdResult CommandIson::Handle (const std::vector<std::string>& parameters, User *user)
 {
-	User *u;
 	std::string reply = "303 " + user->nick + " :";
 	const std::string::size_type pos = reply.size();
 
-	for (unsigned int i = 0; i < parameters.size(); i++)
+	for (std::vector<std::string>::const_iterator i = parameters.begin(); i != parameters.end(); ++i)
 	{
-		u = ServerInstance->FindNickOnly(parameters[i]);
+		const std::string& targetstr = *i;
+
+		User* const u = ServerInstance->FindNickOnly(targetstr);
 		if (!AddNick(user, u, reply, pos))
 		{
-			if ((i == parameters.size() - 1) && (parameters[i].find(' ') != std::string::npos))
+			if ((i == parameters.end() - 1) && (targetstr.find(' ') != std::string::npos))
 			{
 				/* Its a space seperated list of nicks (RFC1459 says to support this)
 				 */
-				irc::spacesepstream list(parameters[i]);
+				irc::spacesepstream list(targetstr);
 				std::string item;
 
 				while (list.GetToken(item))