]> git.netwichtig.de Git - user/henk/code/inspircd.git/log
user/henk/code/inspircd.git
4 years agoImprove the issue templates slightly.
Sadie Powell [Wed, 25 Mar 2020 14:28:01 +0000 (14:28 +0000)]
Improve the issue templates slightly.

4 years agoOnly send a local X-line SNOTICE.
Matt Schatz [Tue, 24 Mar 2020 06:25:33 +0000 (00:25 -0600)]
Only send a local X-line SNOTICE.

Spanningtree sends a local SNOTICE to 'X' when adding
a line. No need to send a global SNOTICE from here.

4 years agoFix the signed-ness within ConvToNum char overloads.
Matt Schatz [Tue, 24 Mar 2020 17:50:14 +0000 (11:50 -0600)]
Fix the signed-ness within ConvToNum char overloads.

It should be signed int with signed char and vice-versa.
Currently, anything over 127 as unsigned char would return 0.

4 years agoCorrect a module name typo.
Matt Schatz [Tue, 24 Mar 2020 06:21:01 +0000 (00:21 -0600)]
Correct a module name typo.

4 years agoAdd a raw source/target PRIVMSG overload for sending a status msg.
Sadie Powell [Thu, 19 Mar 2020 07:34:04 +0000 (07:34 +0000)]
Add a raw source/target PRIVMSG overload for sending a status msg.

4 years agoAllow commands to override ERR_{NEEDSMOREPARAMS,NOTREGISTERED}.
Sadie Powell [Wed, 18 Mar 2020 10:54:37 +0000 (10:54 +0000)]
Allow commands to override ERR_{NEEDSMOREPARAMS,NOTREGISTERED}.

4 years agoForce people to use an issue template.
Sadie Powell [Fri, 13 Mar 2020 07:58:34 +0000 (07:58 +0000)]
Force people to use an issue template.

4 years agoMove CHANMODES to core_mode and add USERMODES.
Sadie Powell [Thu, 12 Mar 2020 18:24:50 +0000 (18:24 +0000)]
Move CHANMODES to core_mode and add USERMODES.

4 years agoImplement support for the SERVLIST command.
Sadie Powell [Thu, 12 Mar 2020 17:27:11 +0000 (17:27 +0000)]
Implement support for the SERVLIST command.

4 years agoAdd a CapReference class for the message-tags capability.
Sadie Powell [Wed, 11 Mar 2020 19:51:26 +0000 (19:51 +0000)]
Add a CapReference class for the message-tags capability.

4 years agoImprove logging for the m_ldap and m_ldapauth modules (#1757).
Joel Sing [Thu, 12 Mar 2020 05:20:46 +0000 (16:20 +1100)]
Improve logging for the m_ldap and m_ldapauth modules (#1757).

Currently, it is difficult to diagnose LDAP authentication failures,
since the logs do not provide sufficient information about what is
actually being queried and what actually failed.

This increases logging details so that information about the LDAP query
is included, for example:

  Fri Mar 06 2020 08:02:59 ANNOUNCEMENT: Error binding as manager to LDAP
  server: Invalid credentials (bind dn=cn=adminz,dc=nodomain)

Rather than:

  Fri Mar 06 2020 08:02:59 ANNOUNCEMENT: Error binding as manager to LDAP
  server: Invalid credentials

Same with connection logging:

  Fri Mar 06 2020 07:59:53 CONNECT: Forbidden connection from
  jsing!jsing@192.168.200.1 (Invalid credentials (bind
  dn=uid=jsing,dc=nodomain))

  Fri Mar 06 2020 08:01:19 CONNECT: Successful connection from
  jsing!jsing@192.168.200.1 (dn=uid=jsing,dc=nodomain)

4 years agoWarn if the server config contains an unhashed password.
Sadie Powell [Wed, 11 Mar 2020 14:32:46 +0000 (14:32 +0000)]
Warn if the server config contains an unhashed password.

This will be made a hard failure in v4.

4 years agoFix detection of the "plaintext" pseudo-hash being case sensitive.
Sadie Powell [Wed, 11 Mar 2020 13:58:45 +0000 (13:58 +0000)]
Fix detection of the "plaintext" pseudo-hash being case sensitive.

4 years agoFix unnecessary inlining in command handler constructors.
Sadie Powell [Mon, 9 Mar 2020 22:50:48 +0000 (22:50 +0000)]
Fix unnecessary inlining in command handler constructors.

4 years agoFix not assigning bits to capabilities correctly.
Sadie Powell [Mon, 9 Mar 2020 13:57:06 +0000 (13:57 +0000)]
Fix not assigning bits to capabilities correctly.

This makes it correctly throw when the capability limit is reached
and allows up to 64 capabilities to be created instead of 32.

4 years agoImplement support for multi-line CAP responses.
Sadie Powell [Mon, 9 Mar 2020 13:44:07 +0000 (13:44 +0000)]
Implement support for multi-line CAP responses.

4 years agoFix <connect:requiressl> being case sensitive.
Sadie Powell [Mon, 9 Mar 2020 04:34:11 +0000 (04:34 +0000)]
Fix <connect:requiressl> being case sensitive.

4 years agoFix get_cpu_count not being evaluated as a scalar.
Sadie Powell [Mon, 9 Mar 2020 03:44:41 +0000 (03:44 +0000)]
Fix get_cpu_count not being evaluated as a scalar.

This fixes a bug where the changes in 0c34d28447 did not work.

4 years agoStandardise the characters allowed in config identifiers.
Sadie Powell [Thu, 27 Feb 2020 18:52:00 +0000 (18:52 +0000)]
Standardise the characters allowed in config identifiers.

4 years agoMove command stuff to a more appropriate source file.
Sadie Powell [Thu, 27 Feb 2020 12:16:25 +0000 (12:16 +0000)]
Move command stuff to a more appropriate source file.

4 years agoClean up the documentation of the Command and SplitCommand classes.
Sadie Powell [Thu, 27 Feb 2020 11:50:30 +0000 (11:50 +0000)]
Clean up the documentation of the Command and SplitCommand classes.

4 years agoMove user command stuff from CommandBase to Command.
Sadie Powell [Thu, 27 Feb 2020 11:01:32 +0000 (11:01 +0000)]
Move user command stuff from CommandBase to Command.

4 years agoAllow modules to prevent a message from updating the idle time.
Sadie Powell [Mon, 24 Feb 2020 02:10:36 +0000 (02:10 +0000)]
Allow modules to prevent a message from updating the idle time.

4 years agoImprove the description of the sslinfo module (#1755).
Matt Schatz [Wed, 26 Feb 2020 05:11:50 +0000 (22:11 -0700)]
Improve the description of the sslinfo module (#1755).

4 years agoUse "yes" instead of "true" in the example configs.
Sadie Powell [Fri, 21 Feb 2020 20:37:00 +0000 (20:37 +0000)]
Use "yes" instead of "true" in the example configs.

4 years agoAdd support for requiring users to use SSL in order to use SASL.
Sadie Powell [Fri, 21 Feb 2020 20:27:05 +0000 (20:27 +0000)]
Add support for requiring users to use SSL in order to use SASL.

4 years agoImprove the documentation of <sasl:server>.
Sadie Powell [Fri, 21 Feb 2020 20:26:23 +0000 (20:26 +0000)]
Improve the documentation of <sasl:server>.

4 years agoAdd support for using environment variables in the config.
Sadie Powell [Thu, 20 Feb 2020 18:02:51 +0000 (18:02 +0000)]
Add support for using environment variables in the config.

4 years agoFix a memory leak in the httpd module when sockets are closed late.
Sadie Powell [Wed, 19 Feb 2020 18:00:36 +0000 (18:00 +0000)]
Fix a memory leak in the httpd module when sockets are closed late.

4 years agoLower <sts:duration> to 5m to prevent misconfigs denying access.
Sadie Powell [Wed, 19 Feb 2020 09:58:47 +0000 (09:58 +0000)]
Lower <sts:duration> to 5m to prevent misconfigs denying access.

4 years agoExtract time skip warning code to a static function.
Sadie Powell [Wed, 19 Feb 2020 08:24:40 +0000 (08:24 +0000)]
Extract time skip warning code to a static function.

4 years agoConvert some things to HasFd that were previously missed.
Sadie Powell [Wed, 19 Feb 2020 05:12:53 +0000 (05:12 +0000)]
Convert some things to HasFd that were previously missed.

4 years agoBump the module ABI version.
Sadie Powell [Wed, 19 Feb 2020 00:39:53 +0000 (00:39 +0000)]
Bump the module ABI version.

4 years agoFix a copy/paste error in IRCv3::Replies::Reply.
Sadie Powell [Wed, 19 Feb 2020 00:39:10 +0000 (00:39 +0000)]
Fix a copy/paste error in IRCv3::Replies::Reply.

4 years agoFix the syntax of the filter module's stats.
Sadie Powell [Tue, 18 Feb 2020 20:23:43 +0000 (20:23 +0000)]
Fix the syntax of the filter module's stats.

4 years agoAdd enum constants for list mode numerics.
Sadie Powell [Tue, 18 Feb 2020 18:03:46 +0000 (18:03 +0000)]
Add enum constants for list mode numerics.

4 years agoUse ircd-hybrid's numerics for the "pending invites" list.
Sadie Powell [Tue, 18 Feb 2020 18:02:13 +0000 (18:02 +0000)]
Use ircd-hybrid's numerics for the "pending invites" list.

This fixes a conflict with the numerics used by the invite
exception mode.

4 years agoSend RPL_KNOCKDLVR when <knock:notify> is set to numeric.
Sadie Powell [Tue, 18 Feb 2020 18:00:26 +0000 (18:00 +0000)]
Send RPL_KNOCKDLVR when <knock:notify> is set to numeric.

4 years agoGeneralise XLine stats numerics using RPL_STATS from aircd.
Sadie Powell [Tue, 18 Feb 2020 17:49:32 +0000 (17:49 +0000)]
Generalise XLine stats numerics using RPL_STATS from aircd.

4 years agoAdd support for the IRCv3 extensions to the SETNAME command.
Sadie Powell [Mon, 3 Feb 2020 10:47:44 +0000 (10:47 +0000)]
Add support for the IRCv3 extensions to the SETNAME command.

4 years agoAdd HasFd to EventHandler and switch code to use it.
Sadie Powell [Sat, 15 Feb 2020 05:58:19 +0000 (05:58 +0000)]
Add HasFd to EventHandler and switch code to use it.

4 years agoFix leaking the dccallow list instead of setting it in FromInternal.
Sadie Powell [Sat, 15 Feb 2020 05:43:02 +0000 (05:43 +0000)]
Fix leaking the dccallow list instead of setting it in FromInternal.

4 years agoFix logic calling OnList when sending a cap notification.
Sadie Powell [Sat, 15 Feb 2020 05:24:24 +0000 (05:24 +0000)]
Fix logic calling OnList when sending a cap notification.

It is possible for the cap to be null when a DEL for an unloaded
module is sent out so we should not blindly call it.

4 years agoGitHub Actions: ensure that all packages are up to date on macOS.
Sadie Powell [Sat, 15 Feb 2020 03:53:16 +0000 (03:53 +0000)]
GitHub Actions: ensure that all packages are up to date on macOS.

This ensures that Homebrew does not explode when installing new
packages because thats apparently a challenge for it.

4 years agoMarginally improve the error pages created by httpd and httpd_acl.
Sadie Powell [Fri, 14 Feb 2020 06:25:06 +0000 (06:25 +0000)]
Marginally improve the error pages created by httpd and httpd_acl.

4 years agoAdd overloads of SendIfCap to the standard replies API.
Sadie Powell [Fri, 14 Feb 2020 04:04:44 +0000 (04:04 +0000)]
Add overloads of SendIfCap to the standard replies API.

4 years agoOnly register the sts capability when we have a valid config.
Sadie Powell [Fri, 14 Feb 2020 03:20:25 +0000 (03:20 +0000)]
Only register the sts capability when we have a valid config.

This avoids announcing a bare sts cap when the config is wrong.

4 years agoClean up ModuleDLLManager from the Module::cull() method.
Sadie Powell [Fri, 14 Feb 2020 01:25:09 +0000 (01:25 +0000)]
Clean up ModuleDLLManager from the Module::cull() method.

This avoids a leak which happens in some rare circumstances.

4 years agoFix GitHub Actions on macOS for real this time.
Sadie Powell [Thu, 13 Feb 2020 22:39:05 +0000 (22:39 +0000)]
Fix GitHub Actions on macOS for real this time.

4 years agoUpdate modules.conf.example to use the new --enable-extras syntax.
Sadie Powell [Thu, 13 Feb 2020 22:22:33 +0000 (22:22 +0000)]
Update modules.conf.example to use the new --enable-extras syntax.

4 years agoUpdate the vendored http_parser library to v2.9.3.
Sadie Powell [Thu, 13 Feb 2020 03:00:34 +0000 (03:00 +0000)]
Update the vendored http_parser library to v2.9.3.

4 years agoTell people to run make with the number of CPU cores plus 1.
Sadie Powell [Mon, 10 Feb 2020 11:59:15 +0000 (11:59 +0000)]
Tell people to run make with the number of CPU cores plus 1.

This results in faster builds as there's always one job waiting.

4 years agoUpdate the pull request template for recent module changes.
Sadie Powell [Mon, 10 Feb 2020 01:56:56 +0000 (01:56 +0000)]
Update the pull request template for recent module changes.

4 years agoRemove a mistakenly repeated word in the README (#1753).
Akinwale Ariwodola [Mon, 10 Feb 2020 01:54:34 +0000 (02:54 +0100)]
Remove a mistakenly repeated word in the README (#1753).

4 years agoInitialise batchendmsg to NULL.
Sadie Powell [Thu, 6 Feb 2020 11:36:32 +0000 (11:36 +0000)]
Initialise batchendmsg to NULL.

4 years agoInclude the ABI version with the incompatible module error message.
Sadie Powell [Mon, 3 Feb 2020 21:43:15 +0000 (21:43 +0000)]
Include the ABI version with the incompatible module error message.

4 years agoStandard replies have been ratified.
Sadie Powell [Mon, 3 Feb 2020 10:55:38 +0000 (10:55 +0000)]
Standard replies have been ratified.

4 years agoClean special chars from module conf example
Wade Cline [Mon, 3 Feb 2020 03:57:14 +0000 (19:57 -0800)]
Clean special chars from module conf example

4 years agoMake loading modules considerably more robust and user friendly.
Sadie Powell [Sun, 2 Feb 2020 17:07:34 +0000 (17:07 +0000)]
Make loading modules considerably more robust and user friendly.

4 years agoFix GitHub Actions building on macOS.
Sadie Powell [Sun, 2 Feb 2020 17:07:34 +0000 (17:07 +0000)]
Fix GitHub Actions building on macOS.

For some reason Homebrew is imploding on upgrade and this is making
our builds fail. Let's not upgrade for now.

4 years agoFix being able to see the modes of private/secret channels.
Sadie Powell [Sun, 2 Feb 2020 15:52:41 +0000 (15:52 +0000)]
Fix being able to see the modes of private/secret channels.

4 years agoRelease v3.5.0.
Sadie Powell [Fri, 31 Jan 2020 12:49:58 +0000 (12:49 +0000)]
Release v3.5.0.

4 years agoUpdate copyright headers.
InspIRCd Robot [Fri, 31 Jan 2020 12:48:25 +0000 (12:48 +0000)]
Update copyright headers.

4 years agoBump the ABI version.
Sadie Powell [Fri, 31 Jan 2020 12:42:54 +0000 (12:42 +0000)]
Bump the ABI version.

4 years agoThe labeled response spec is no longer a draft.
Sadie Powell [Fri, 31 Jan 2020 10:37:14 +0000 (10:37 +0000)]
The labeled response spec is no longer a draft.

4 years agoFix the chanhistory module not storing CTCP ACTIONs.
Sadie Powell [Fri, 31 Jan 2020 10:32:28 +0000 (10:32 +0000)]
Fix the chanhistory module not storing CTCP ACTIONs.

4 years agoUse the default OnParameterMissing in ModeUserServerNoticeMask.
Sadie Powell [Thu, 30 Jan 2020 14:41:25 +0000 (14:41 +0000)]
Use the default OnParameterMissing in ModeUserServerNoticeMask.

4 years agoThe KNOCK command is broadcast so we should only send local notices.
Sadie Powell [Wed, 29 Jan 2020 14:14:25 +0000 (14:14 +0000)]
The KNOCK command is broadcast so we should only send local notices.

See also: #1749.

4 years agoAdd Channel::WriteRemoteNotice and revert WriteNotice changes.
Sadie Powell [Wed, 29 Jan 2020 11:44:50 +0000 (11:44 +0000)]
Add Channel::WriteRemoteNotice and revert WriteNotice changes.

This is a partial reversion of 687778b72e.

See also: #1749.

4 years agoFix "control reaches end of non-void function" warning.
Sadie Powell [Tue, 28 Jan 2020 16:55:06 +0000 (16:55 +0000)]
Fix "control reaches end of non-void function" warning.

This is harmless because it will always be set to one of the items
in the TargetType enum.

4 years agoImplement support for the IRCv3 labeled-response specification.
Sadie Powell [Fri, 3 Jan 2020 14:55:04 +0000 (14:55 +0000)]
Implement support for the IRCv3 labeled-response specification.

4 years agoAdd a vendor cap which rejects any attempts to enable it.
Sadie Powell [Tue, 28 Jan 2020 14:31:40 +0000 (14:31 +0000)]
Add a vendor cap which rejects any attempts to enable it.

This is similar to the oragono.io/nope capability only instead of
killing the connection it just rejects the request. This should be
less intrusive for users.

4 years agoRemove the preceding - in messages sent by opermotd and showfile.
Sadie Powell [Fri, 24 Jan 2020 21:14:35 +0000 (21:14 +0000)]
Remove the preceding - in messages sent by opermotd and showfile.

4 years agodccallow: use IsCTCP instead of parsing the message manually.
Sadie Powell [Thu, 23 Jan 2020 19:25:37 +0000 (19:25 +0000)]
dccallow: use IsCTCP instead of parsing the message manually.

4 years agodccallow: Use irc::equals for messages received over IRC.
Sadie Powell [Thu, 23 Jan 2020 19:24:26 +0000 (19:24 +0000)]
dccallow: Use irc::equals for messages received over IRC.

4 years agoAdd a method for getting the name of a MessageTarget.
Sadie Powell [Thu, 23 Jan 2020 17:16:17 +0000 (17:16 +0000)]
Add a method for getting the name of a MessageTarget.

This fixes a minor bug in the filter module where the target would
be blank in messages when a server-targetted message matches a
filter.

4 years agoUse PushParam instead of PushParamRef in TagMessage#PushTarget.
Sadie Powell [Wed, 22 Jan 2020 11:47:20 +0000 (11:47 +0000)]
Use PushParam instead of PushParamRef in TagMessage#PushTarget.

This could be a temporary string so copy it instead of risking a
crash and/or dumping the contents of memory into messages.

This fixes a crash introduced last week.

4 years agoAdd an event for when a command is blocked before execution.
Sadie Powell [Wed, 22 Jan 2020 01:20:08 +0000 (01:20 +0000)]
Add an event for when a command is blocked before execution.

4 years agoRemove unnecessary copies of CommandBase::Params in LoopCall.
Sadie Powell [Wed, 22 Jan 2020 10:04:35 +0000 (10:04 +0000)]
Remove unnecessary copies of CommandBase::Params in LoopCall.

4 years agoMake the dynref bool operator constant.
Sadie Powell [Mon, 20 Jan 2020 21:59:17 +0000 (21:59 +0000)]
Make the dynref bool operator constant.

4 years agoTweak the default motd/opermotd slightly.
Sadie Powell [Mon, 20 Jan 2020 20:36:39 +0000 (20:36 +0000)]
Tweak the default motd/opermotd slightly.

Also, remove the - at the start of the MOTD field. This is cargo
culted from irc2 and theres no real reason to actually do this.

4 years agoMove DeleteZero to stdalgo::delete_zero.
Sadie Powell [Sun, 19 Jan 2020 15:41:23 +0000 (15:41 +0000)]
Move DeleteZero to stdalgo::delete_zero.

4 years agoUse irc::equals instead of transforming to upper case in CAP.
Sadie Powell [Sat, 18 Jan 2020 20:48:53 +0000 (20:48 +0000)]
Use irc::equals instead of transforming to upper case in CAP.

4 years agoUse case insensitive comparisons in getBool.
Sadie Powell [Sat, 18 Jan 2020 20:38:57 +0000 (20:38 +0000)]
Use case insensitive comparisons in getBool.

4 years agoAdd a function for showing a command whilst executing it.
Sadie Powell [Sat, 18 Jan 2020 14:03:18 +0000 (14:03 +0000)]
Add a function for showing a command whilst executing it.

4 years agoDisable auto extras when TEST_BUILD_MODULES is set in test-build.
Sadie Powell [Sat, 18 Jan 2020 13:32:41 +0000 (13:32 +0000)]
Disable auto extras when TEST_BUILD_MODULES is set in test-build.

4 years agoImprove manually enabling extra modules.
Sadie Powell [Sat, 18 Jan 2020 13:27:09 +0000 (13:27 +0000)]
Improve manually enabling extra modules.

- Allow modules to be specified without their prefix and extensions
  in --{disable,enable}-extras.
- Allow modules to be space delimited in --{disable,enable}-extras.

4 years agoAdd a tool for updating the vendored libaries.
Sadie Powell [Fri, 17 Jan 2020 22:45:56 +0000 (22:45 +0000)]
Add a tool for updating the vendored libaries.

4 years agoImprove the DNS cache expiration log message.
Sadie Powell [Fri, 17 Jan 2020 16:13:32 +0000 (16:13 +0000)]
Improve the DNS cache expiration log message.

Instead of constantly spamming the log file only show the message
when an entry is actually expired and show how many entries were
expired.

4 years agoMigrate from Travis CI to GitHub Actions.
Sadie Powell [Fri, 17 Jan 2020 12:50:42 +0000 (12:50 +0000)]
Migrate from Travis CI to GitHub Actions.

This brings shiny new GitHub integrations as well as allowing us to
bring back the macOS builds which were disabled because of the very
broken Travis CI macOS infrastructure.

4 years agoFix a harmless warning in the ssl_mbedtls module.
Sadie Powell [Fri, 17 Jan 2020 15:22:34 +0000 (15:22 +0000)]
Fix a harmless warning in the ssl_mbedtls module.

4 years agoFix Perl tools not using the correct directory name in 'use lib'.
Sadie Powell [Fri, 17 Jan 2020 14:40:44 +0000 (14:40 +0000)]
Fix Perl tools not using the correct directory name in 'use lib'.

4 years agoFix the ordering of custom event handlers.
Sadie Powell [Fri, 17 Jan 2020 10:50:26 +0000 (10:50 +0000)]
Fix the ordering of custom event handlers.

Closes #1742.

4 years agoUse irc::equals instead of strcasecmp where appropriate.
Sadie Powell [Thu, 16 Jan 2020 18:33:18 +0000 (18:33 +0000)]
Use irc::equals instead of strcasecmp where appropriate.

4 years agoFix a GCC shadowing warning.
Sadie Powell [Thu, 16 Jan 2020 17:37:51 +0000 (17:37 +0000)]
Fix a GCC shadowing warning.

4 years agoFix STATUSMSG tag messages not including the status in the target.
Sadie Powell [Thu, 16 Jan 2020 15:23:40 +0000 (15:23 +0000)]
Fix STATUSMSG tag messages not including the status in the target.

4 years agoCheck tag list after checking if the message-tag cap is enabled.
Sadie Powell [Thu, 16 Jan 2020 15:18:17 +0000 (15:18 +0000)]
Check tag list after checking if the message-tag cap is enabled.

This fixes a confusion created in c299adb31a where users without
the message-tags cap would get errors instead of being silently
ignored.

4 years agoAdd support for setting the help topic in helpop.
Sadie Powell [Wed, 15 Jan 2020 12:56:41 +0000 (12:56 +0000)]
Add support for setting the help topic in helpop.

4 years agoPrevent users from sending an empty TAGMSG.
Sadie Powell [Wed, 15 Jan 2020 12:09:05 +0000 (12:09 +0000)]
Prevent users from sending an empty TAGMSG.

4 years agoVarious improvements for the helpop module.
Sadie Powell [Mon, 13 Jan 2020 14:32:49 +0000 (14:32 +0000)]
Various improvements for the helpop module.

- Ensure that the config is actually valid. This found an invalid
  entry in the default helpop configs.
- Columize the index page and build it whilst reading the config
  instead of at request time.