From 31344bbedf40756d2476062c8426413872d7d4de Mon Sep 17 00:00:00 2001 From: attilamolnar Date: Mon, 17 Dec 2012 02:40:02 +0100 Subject: [PATCH] m_xline_db Fix pointless excessive stack usage in ReadDatabase() --- src/modules/m_xline_db.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/modules/m_xline_db.cpp b/src/modules/m_xline_db.cpp index 1c5125805..5e83478c3 100644 --- a/src/modules/m_xline_db.cpp +++ b/src/modules/m_xline_db.cpp @@ -169,7 +169,6 @@ class ModuleXLineDB : public Module { FILE *f; char linebuf[MAXBUF]; - unsigned int lineno = 0; f = fopen(xlinedbpath.c_str(), "r"); if (!f) @@ -201,16 +200,14 @@ class ModuleXLineDB : public Module c++; } - // Smart man might think of initing to 1, and moving this to the bottom. Don't. We use continue in this loop. - lineno++; // Inspired by the command parser. :) irc::tokenstream tokens(linebuf); int items = 0; - std::string command_p[MAXPARAMETERS]; + std::string command_p[7]; std::string tmp; - while (tokens.GetToken(tmp) && (items < MAXPARAMETERS)) + while (tokens.GetToken(tmp) && (items < 7)) { command_p[items] = tmp; items++; -- 2.39.5