From 8a458c02a29b1d7c41b9420eabc90ba40bbe960a Mon Sep 17 00:00:00 2001 From: Giuseppe Bilotta Date: Fri, 4 Jun 2021 16:44:03 +0200 Subject: [PATCH] logger: don't actually close the console logger We nil the internal variable, but we should not close the logger itself, since this leads to STDERR being closed and the interpreter reopening it for its own needs, or something like that, which ultimately leads to the interpreter's warning appearing in console (probably due to ruby itself reopening stderr to be able to output the messages). If we simply nil the variable, the interpreter is content with sending us the messages per our shenanigangs, and everything works just as expected. --- lib/rbot/logger.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/rbot/logger.rb b/lib/rbot/logger.rb index 4189151c..494324d9 100644 --- a/lib/rbot/logger.rb +++ b/lib/rbot/logger.rb @@ -21,7 +21,6 @@ class Bot end def disable_console_logger - @console_logger.close if @console_logger @console_logger = nil end @@ -84,6 +83,8 @@ class Bot end def log_session_start + # if we forked, the thread may be dead, so let's restart it if necessary + start_thread if @file_logger @file_logger << "\n\n=== session started on #{Time.now.strftime(@dateformat)} ===\n\n" end -- 2.39.2