diff options
author | Peter Powell <petpow@saberuk.com> | 2017-07-11 17:37:20 +0100 |
---|---|---|
committer | Peter Powell <petpow@saberuk.com> | 2017-07-11 17:37:20 +0100 |
commit | 3cf2dd8247aea43221bfef98b8afcc3845ead4f9 (patch) | |
tree | 537dc218889b5a5d921c6796229b0b7df6fa7ab3 /make/directive.pm | |
parent | f0ca3397eacaa829127ca7f344de0a8658012ace (diff) |
Remove use of global barewords in most file handling code.
This is not considered good practise in modern Perl code.
A few cases of this still remain in code which is due to be
rewritten anyway.
Diffstat (limited to 'make/directive.pm')
-rw-r--r-- | make/directive.pm | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/make/directive.pm b/make/directive.pm index 4501fc5ec..2e9e7ed61 100644 --- a/make/directive.pm +++ b/make/directive.pm @@ -41,16 +41,16 @@ our @EXPORT = qw(get_directive sub get_directive($$;$) { my ($file, $property, $default) = @_; - open(MODULE, $file) or return $default; + open(my $fh, $file) or return $default; my $value = ''; - while (<MODULE>) { + while (<$fh>) { if ($_ =~ /^\/\* \$(\S+): (.+) \*\/$/ || $_ =~ /^\/\/\/ \$(\S+): (.+)/) { next unless $1 eq $property; $value .= ' ' . execute_functions($file, $1, $2); } } - close(MODULE); + close $fh; # Strip all extraneous whitespace. $value =~ s/^\s+|\s+$//g; |