diff options
| author | attilamolnar <attilamolnar@hush.com> | 2012-09-30 01:10:57 +0200 |
|---|---|---|
| committer | attilamolnar <attilamolnar@hush.com> | 2012-09-30 03:04:07 +0200 |
| commit | 02859be56d43bcece02aab350e02bc95ed1bf446 (patch) | |
| tree | bbb68a91e26f4502c22047ad2b26ed8918c5fbb1 /src/dns.cpp | |
| parent | 83e90c4baa1215caf05295aec86a0a4d7bfff3f9 (diff) | |
Fix more undefined behavior caused by referencing the returned buffer by std::string::c_str() when the object is temporary
See 83c7cc45daf6fb1f8c36f15297a4657e45a34e88
Diffstat (limited to 'src/dns.cpp')
| -rw-r--r-- | src/dns.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/dns.cpp b/src/dns.cpp index 17641c585..1c23710a4 100644 --- a/src/dns.cpp +++ b/src/dns.cpp @@ -596,8 +596,10 @@ DNSResult DNS::GetResult() */ if (from != myserver) { + std::string server1 = from.str(); + std::string server2 = myserver.str(); ServerInstance->Logs->Log("RESOLVER",DEBUG,"Got a result from the wrong server! Bad NAT or DNS forging attempt? '%s' != '%s'", - from.str().c_str(), myserver.str().c_str()); + server1.c_str(), server2.c_str()); return DNSResult(-1,"",0,""); } |