Windows: In-depth cleanup (see details)

-Fix x64 builds for Windows. Now all configurations compile.
-Remove the non-working rebase stuff.
-Remove the Windows fork hack and instead use FreeConsole() to emulate the behavior. This directly allows us to compile with ASLR, which is turned on now.
-Remove the old IPC mechanism for the removed GUI. This is not needed anymore as the GUI wasn't ever supported on anything newer than 1.2
-Remove the WIN32/WINDOWS macros. _WIN32 is supported on all x86-based VC++ targets, so that's what we need.
-Enable optimizations for release builds.
-De-duplicate printf_c(), it was previously copy-pasted into colors.h for configure
-Add the VC++ specific bad files in .gitignore
-Disable PID writing on Windows. This is only making sense for *nix builds.
-Replace the CPU usage retrieval with an algorithm analogous to the *nix behavior. Also supports separated now/total values. (Tested with a dummy busy loop - seems working)
-Removed certain unused functions and variables
-Remove stdint defines from the windows wrapper
-Remove CRT debug alloc. This is a bad idea as it would define a macro to replace free which breaks builds.
-Re-evaluated the warnings list, commented it.
-Moved inspircd_config/_version to include/ to match *nix
-Removed the creation of inspircd_se_config, as it isn't used at all.
-Made non-git builds show as "r0" instead of "r" (thanks to @SaberUK for pointing this out)
-Fixed up m_spanningtree's project paths. Now all configurations (debug/release x86/x64) have been tested and build properly.
-Moved FindDNS out of the wrapper and matched its log behavior with *nix. (It's pointless having it in the wrapper after the recent slimming down)
-Replaced random/srandom wrappers with a mechanism that tries to use Windows' Random API first is no SSL module is loaded.
-Removed more old junk from support for compilers older than VC++ 2010 (we don't have project files for these, so compiling them would be hard anyways)
-Removed the unused ClearConsole()
-Removed unused includes from the wrapper. Also, do not include psapi.h here if we don't link psapi.lib. This should be done where appropriate.
-Made inet_aton an inline function for increased performance
-C4800, performance warning about bool forcing, resolved at all occurrences.
-C4701, uninitialized variable 'cached', resolved at all occurrences.
-dlerror() was migrated out of the wrapper for more thread safety (no global buffer being shared) and increased performance.
-Removed the wrong CRT debug flags. This drains a lot of performance.
-Removed the clock_gettime/gettimeofday wrappers
-Replaced all TCHAR/ANSI mix-ups of functions with the correct respective function.
-Added a block of C4355 for < VS2012
-Update project files for c870714

1 files changed, 24 insertions, 16 deletions

diff --git a/win/win32service.cpp b/win/win32service.cpp
index 1d4cbad3b..b677b6662 100644
--- a/win/win32service.cpp
+++ b/win/win32service.cpp
@@ -51,6 +51,14 @@ struct Commandline
 /* A function pointer for dynamic linking tricks */
 SETSERVDESC ChangeServiceConf;
 
+LPCSTR RetrieveLastError()
+{
+	static char err[100];
+	FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM, 0, GetLastError(), MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPSTR)err, sizeof(err), 0);
+	SetLastError(ERROR_SUCCESS);
+	return err;
+}
+
 /* Returns true if this program is running as a service, false if it is running interactive */
 bool IsAService()
 {
@@ -76,7 +84,7 @@ void KillService()
 DWORD WINAPI WorkerThread(LPDWORD param)
 {
 	char modname[MAX_PATH];
-	GetModuleFileName(NULL, modname, sizeof(modname));
+	GetModuleFileNameA(NULL, modname, sizeof(modname));
 	char* argv[] = { modname, "--nofork" };
 	smain(2, argv);
 	KillService();
@@ -189,7 +197,7 @@ VOID ServiceMain(DWORD argc, LPTSTR *argv)
 {
 	BOOL success;
 
-	serviceStatusHandle = RegisterServiceCtrlHandler("InspIRCd", (LPHANDLER_FUNCTION)ServiceCtrlHandler);
+	serviceStatusHandle = RegisterServiceCtrlHandler(TEXT("InspIRCd"), (LPHANDLER_FUNCTION)ServiceCtrlHandler);
 	if (!serviceStatusHandle)
 	{
 		terminateService(EXIT_STATUS_RSCH_FAILED, GetLastError());
@@ -230,22 +238,22 @@ void InstallService()
 	SERVICE_DESCRIPTION svDesc;
 	HINSTANCE advapi32;
 
-	char modname[MAX_PATH];
+	TCHAR modname[MAX_PATH];
 	GetModuleFileName(NULL, modname, sizeof(modname));
 
 	scm = OpenSCManager(0,0,SC_MANAGER_CREATE_SERVICE);
 	if (!scm)
 	{
-		printf("Unable to open service control manager: %s\n", dlerror());
+		printf("Unable to open service control manager: %s\n", RetrieveLastError());
 		return;
 	}
 
-	myService = CreateService(scm,"InspIRCd","Inspire IRC Daemon", SERVICE_ALL_ACCESS, SERVICE_WIN32_OWN_PROCESS,
+	myService = CreateService(scm,TEXT("InspIRCd"),TEXT("Inspire IRC Daemon"), SERVICE_ALL_ACCESS, SERVICE_WIN32_OWN_PROCESS,
 		SERVICE_AUTO_START, SERVICE_ERROR_NORMAL, modname, 0, 0, 0, NULL, NULL);
 
 	if (!myService)
 	{
-		printf("Unable to create service: %s\n", dlerror());
+		printf("Unable to create service: %s\n", RetrieveLastError());
 		CloseServiceHandle(scm);
 		return;
 	}
@@ -254,19 +262,19 @@ void InstallService()
 	// this is supported from 5.0 (win2k) onwards only, so we can't link to the definition of
 	// this function in advapi32.lib, otherwise the program will not run on windows NT 4. We
 	// must use LoadLibrary and GetProcAddress to export the function name from advapi32.dll
-	advapi32 = LoadLibrary("advapi32.dll");
+	advapi32 = LoadLibrary(TEXT("advapi32.dll"));
 	if (advapi32)
 	{
 		ChangeServiceConf = (SETSERVDESC)GetProcAddress(advapi32,"ChangeServiceConfig2A");
 		if (ChangeServiceConf)
 		{
-			char desc[] = "The Inspire Internet Relay Chat Daemon hosts IRC channels and conversations.\
- If this service is stopped, the IRC server will not run.";
+			TCHAR desc[] = TEXT("The Inspire Internet Relay Chat Daemon hosts IRC channels and conversations.\
+ If this service is stopped, the IRC server will not run.");
 			svDesc.lpDescription = desc;
 			BOOL success = ChangeServiceConf(myService,SERVICE_CONFIG_DESCRIPTION, &svDesc);
 			if (!success)
 			{
-				printf("Unable to set service description: %s\n", dlerror());
+				printf("Unable to set service description: %s\n", RetrieveLastError());
 				CloseServiceHandle(myService);
 				CloseServiceHandle(scm);
 				return;
@@ -288,21 +296,21 @@ void RemoveService()
 	scm = OpenSCManager(0,0,SC_MANAGER_CREATE_SERVICE);
 	if (!scm)
 	{
-		printf("Unable to open service control manager: %s\n", dlerror());
+		printf("Unable to open service control manager: %s\n", RetrieveLastError());
 		return;
 	}
 
-	myService = OpenService(scm,"InspIRCd",SERVICE_ALL_ACCESS);
+	myService = OpenService(scm,TEXT("InspIRCd"),SERVICE_ALL_ACCESS);
 	if (!myService)
 	{
-		printf("Unable to open service: %s\n", dlerror());
+		printf("Unable to open service: %s\n", RetrieveLastError());
 		CloseServiceHandle(scm);
 		return;
 	}
 
 	if (!DeleteService(myService))
 	{
-		printf("Unable to delete service: %s\n", dlerror());
+		printf("Unable to delete service: %s\n", RetrieveLastError());
 		CloseServiceHandle(myService);
 		CloseServiceHandle(scm);
 		return;
@@ -345,7 +353,7 @@ int main(int argc, char** argv)
 	scm = OpenSCManager(0,0,SC_MANAGER_CREATE_SERVICE);
 	if (scm)
 	{
-		myService = OpenService(scm,"InspIRCd",SERVICE_ALL_ACCESS);
+		myService = OpenService(scm,TEXT("InspIRCd"),SERVICE_ALL_ACCESS);
 		if (!myService)
 		{
 			/* Service not installed or no permission to modify it */
@@ -372,7 +380,7 @@ int main(int argc, char** argv)
 
 	SERVICE_TABLE_ENTRY serviceTable[] =
 	{
-		{"InspIRCd", (LPSERVICE_MAIN_FUNCTION) ServiceMain },
+		{TEXT("InspIRCd"), (LPSERVICE_MAIN_FUNCTION) ServiceMain },
 		{NULL, NULL}
 	};